Title: [186060] trunk/Source/WebKit/mac
- Revision
- 186060
- Author
- [email protected]
- Date
- 2015-06-28 20:18:02 -0700 (Sun, 28 Jun 2015)
Log Message
[Mac] Remove redundant call to colorUsingColorSpaceName:
https://bugs.webkit.org/show_bug.cgi?id=146397
Reviewed by Alexey Proskuryakov.
* WebView/WebHTMLView.mm:
(extractUnderlines): Remove call to the colorUsingColorSpaceName: method,
since colorFromNSColor already calls it. No need to do it twice.
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (186059 => 186060)
--- trunk/Source/WebKit/mac/ChangeLog 2015-06-29 01:19:30 UTC (rev 186059)
+++ trunk/Source/WebKit/mac/ChangeLog 2015-06-29 03:18:02 UTC (rev 186060)
@@ -1,3 +1,14 @@
+2015-06-28 Darin Adler <[email protected]>
+
+ [Mac] Remove redundant call to colorUsingColorSpaceName:
+ https://bugs.webkit.org/show_bug.cgi?id=146397
+
+ Reviewed by Alexey Proskuryakov.
+
+ * WebView/WebHTMLView.mm:
+ (extractUnderlines): Remove call to the colorUsingColorSpaceName: method,
+ since colorFromNSColor already calls it. No need to do it twice.
+
2015-06-26 Hyungwook Lee <[email protected]>
[Win] Implement WebViewGroup to support WebView::addxxxToGroup().
Modified: trunk/Source/WebKit/mac/WebView/WebHTMLView.mm (186059 => 186060)
--- trunk/Source/WebKit/mac/WebView/WebHTMLView.mm 2015-06-29 01:19:30 UTC (rev 186059)
+++ trunk/Source/WebKit/mac/WebView/WebHTMLView.mm 2015-06-29 03:18:02 UTC (rev 186060)
@@ -6262,7 +6262,7 @@
if (NSNumber *style = [attrs objectForKey:NSUnderlineStyleAttributeName]) {
Color color = Color::black;
if (NSColor *colorAttr = [attrs objectForKey:NSUnderlineColorAttributeName])
- color = colorFromNSColor([colorAttr colorUsingColorSpaceName:NSDeviceRGBColorSpace]);
+ color = colorFromNSColor(colorAttr);
result.append(CompositionUnderline(range.location, NSMaxRange(range), color, [style intValue] > 1));
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
