Diff
Modified: trunk/Source/WebCore/ChangeLog (183610 => 183611)
--- trunk/Source/WebCore/ChangeLog 2015-04-30 03:15:23 UTC (rev 183610)
+++ trunk/Source/WebCore/ChangeLog 2015-04-30 03:21:27 UTC (rev 183611)
@@ -1,3 +1,38 @@
+2015-04-29 Gyuyoung Kim <[email protected]>
+
+ Remove PassRefPtr in SVGFEFooElement classes
+ https://bugs.webkit.org/show_bug.cgi?id=144425
+
+ Reviewed by Darin Adler.
+
+ As a step to use Ref instead of PassRefPtr, this patch purges PassRefPtr
+ in SVGFEFooElement.
+
+ No new tests, no behavior changes.
+
+ * css/RGBColor.cpp:
+ (WebCore::RGBColor::create):
+ * css/RGBColor.h:
+ * platform/graphics/filters/PointLightSource.h:
+ (WebCore::PointLightSource::create):
+ * platform/graphics/filters/SpotLightSource.h:
+ (WebCore::SpotLightSource::create):
+ * svg/SVGColor.cpp:
+ (WebCore::SVGColor::rgbColor):
+ * svg/SVGColor.h:
+ * svg/SVGFEDistantLightElement.cpp:
+ (WebCore::SVGFEDistantLightElement::lightSource):
+ * svg/SVGFEDistantLightElement.h:
+ * svg/SVGFELightElement.cpp:
+ (WebCore::SVGFELightElement::findLightSource):
+ * svg/SVGFELightElement.h:
+ * svg/SVGFEPointLightElement.cpp:
+ (WebCore::SVGFEPointLightElement::lightSource):
+ * svg/SVGFEPointLightElement.h:
+ * svg/SVGFESpotLightElement.cpp:
+ (WebCore::SVGFESpotLightElement::lightSource):
+ * svg/SVGFESpotLightElement.h:
+
2015-04-29 Dean Jackson <[email protected]>
Create a named CSS property for system colors
Modified: trunk/Source/WebCore/css/RGBColor.cpp (183610 => 183611)
--- trunk/Source/WebCore/css/RGBColor.cpp 2015-04-30 03:15:23 UTC (rev 183610)
+++ trunk/Source/WebCore/css/RGBColor.cpp 2015-04-30 03:21:27 UTC (rev 183611)
@@ -30,9 +30,9 @@
namespace WebCore {
-PassRefPtr<RGBColor> RGBColor::create(unsigned rgbColor)
+Ref<RGBColor> RGBColor::create(unsigned rgbColor)
{
- return adoptRef(new RGBColor(rgbColor));
+ return adoptRef(*new RGBColor(rgbColor));
}
PassRefPtr<CSSPrimitiveValue> RGBColor::red()
Modified: trunk/Source/WebCore/css/RGBColor.h (183610 => 183611)
--- trunk/Source/WebCore/css/RGBColor.h 2015-04-30 03:15:23 UTC (rev 183610)
+++ trunk/Source/WebCore/css/RGBColor.h 2015-04-30 03:21:27 UTC (rev 183611)
@@ -36,7 +36,7 @@
class RGBColor : public RefCounted<RGBColor> {
public:
- static PassRefPtr<RGBColor> create(unsigned rgbColor);
+ static Ref<RGBColor> create(unsigned rgbColor);
PassRefPtr<CSSPrimitiveValue> red();
PassRefPtr<CSSPrimitiveValue> green();
Modified: trunk/Source/WebCore/platform/graphics/filters/PointLightSource.h (183610 => 183611)
--- trunk/Source/WebCore/platform/graphics/filters/PointLightSource.h 2015-04-30 03:15:23 UTC (rev 183610)
+++ trunk/Source/WebCore/platform/graphics/filters/PointLightSource.h 2015-04-30 03:21:27 UTC (rev 183611)
@@ -29,9 +29,9 @@
class PointLightSource : public LightSource {
public:
- static PassRefPtr<PointLightSource> create(const FloatPoint3D& position)
+ static Ref<PointLightSource> create(const FloatPoint3D& position)
{
- return adoptRef(new PointLightSource(position));
+ return adoptRef(*new PointLightSource(position));
}
const FloatPoint3D& position() const { return m_position; }
Modified: trunk/Source/WebCore/platform/graphics/filters/SpotLightSource.h (183610 => 183611)
--- trunk/Source/WebCore/platform/graphics/filters/SpotLightSource.h 2015-04-30 03:15:23 UTC (rev 183610)
+++ trunk/Source/WebCore/platform/graphics/filters/SpotLightSource.h 2015-04-30 03:21:27 UTC (rev 183611)
@@ -29,10 +29,10 @@
class SpotLightSource : public LightSource {
public:
- static PassRefPtr<SpotLightSource> create(const FloatPoint3D& position,
+ static Ref<SpotLightSource> create(const FloatPoint3D& position,
const FloatPoint3D& direction, float specularExponent, float limitingConeAngle)
{
- return adoptRef(new SpotLightSource(position, direction, specularExponent, limitingConeAngle));
+ return adoptRef(*new SpotLightSource(position, direction, specularExponent, limitingConeAngle));
}
const FloatPoint3D& position() const { return m_position; }
Modified: trunk/Source/WebCore/svg/SVGColor.cpp (183610 => 183611)
--- trunk/Source/WebCore/svg/SVGColor.cpp 2015-04-30 03:15:23 UTC (rev 183610)
+++ trunk/Source/WebCore/svg/SVGColor.cpp 2015-04-30 03:21:27 UTC (rev 183611)
@@ -40,7 +40,7 @@
{
}
-PassRefPtr<RGBColor> SVGColor::rgbColor() const
+Ref<RGBColor> SVGColor::rgbColor() const
{
return RGBColor::create(m_color.rgb());
}
Modified: trunk/Source/WebCore/svg/SVGColor.h (183610 => 183611)
--- trunk/Source/WebCore/svg/SVGColor.h 2015-04-30 03:15:23 UTC (rev 183610)
+++ trunk/Source/WebCore/svg/SVGColor.h 2015-04-30 03:21:27 UTC (rev 183611)
@@ -59,7 +59,7 @@
const Color& color() const { return m_color; }
const SVGColorType& colorType() const { return m_colorType; }
- PassRefPtr<RGBColor> rgbColor() const;
+ Ref<RGBColor> rgbColor() const;
static Color colorFromRGBColorString(const String&);
Modified: trunk/Source/WebCore/svg/SVGFEDistantLightElement.cpp (183610 => 183611)
--- trunk/Source/WebCore/svg/SVGFEDistantLightElement.cpp 2015-04-30 03:15:23 UTC (rev 183610)
+++ trunk/Source/WebCore/svg/SVGFEDistantLightElement.cpp 2015-04-30 03:21:27 UTC (rev 183611)
@@ -36,7 +36,7 @@
return adoptRef(*new SVGFEDistantLightElement(tagName, document));
}
-PassRefPtr<LightSource> SVGFEDistantLightElement::lightSource() const
+Ref<LightSource> SVGFEDistantLightElement::lightSource() const
{
return DistantLightSource::create(azimuth(), elevation());
}
Modified: trunk/Source/WebCore/svg/SVGFEDistantLightElement.h (183610 => 183611)
--- trunk/Source/WebCore/svg/SVGFEDistantLightElement.h 2015-04-30 03:15:23 UTC (rev 183610)
+++ trunk/Source/WebCore/svg/SVGFEDistantLightElement.h 2015-04-30 03:21:27 UTC (rev 183611)
@@ -31,7 +31,7 @@
private:
SVGFEDistantLightElement(const QualifiedName&, Document&);
- virtual PassRefPtr<LightSource> lightSource() const override;
+ virtual Ref<LightSource> lightSource() const override;
};
} // namespace WebCore
Modified: trunk/Source/WebCore/svg/SVGFELightElement.cpp (183610 => 183611)
--- trunk/Source/WebCore/svg/SVGFELightElement.cpp 2015-04-30 03:15:23 UTC (rev 183610)
+++ trunk/Source/WebCore/svg/SVGFELightElement.cpp 2015-04-30 03:21:27 UTC (rev 183611)
@@ -74,7 +74,7 @@
return nullptr;
}
-PassRefPtr<LightSource> SVGFELightElement::findLightSource(const SVGElement* svgElement)
+RefPtr<LightSource> SVGFELightElement::findLightSource(const SVGElement* svgElement)
{
SVGFELightElement* lightNode = findLightElement(svgElement);
if (!lightNode)
Modified: trunk/Source/WebCore/svg/SVGFELightElement.h (183610 => 183611)
--- trunk/Source/WebCore/svg/SVGFELightElement.h 2015-04-30 03:15:23 UTC (rev 183610)
+++ trunk/Source/WebCore/svg/SVGFELightElement.h 2015-04-30 03:21:27 UTC (rev 183611)
@@ -30,9 +30,9 @@
class SVGFELightElement : public SVGElement {
public:
- virtual PassRefPtr<LightSource> lightSource() const = 0;
+ virtual Ref<LightSource> lightSource() const = 0;
static SVGFELightElement* findLightElement(const SVGElement*);
- static PassRefPtr<LightSource> findLightSource(const SVGElement*);
+ static RefPtr<LightSource> findLightSource(const SVGElement*);
protected:
SVGFELightElement(const QualifiedName&, Document&);
Modified: trunk/Source/WebCore/svg/SVGFEPointLightElement.cpp (183610 => 183611)
--- trunk/Source/WebCore/svg/SVGFEPointLightElement.cpp 2015-04-30 03:15:23 UTC (rev 183610)
+++ trunk/Source/WebCore/svg/SVGFEPointLightElement.cpp 2015-04-30 03:21:27 UTC (rev 183611)
@@ -36,7 +36,7 @@
return adoptRef(*new SVGFEPointLightElement(tagName, document));
}
-PassRefPtr<LightSource> SVGFEPointLightElement::lightSource() const
+Ref<LightSource> SVGFEPointLightElement::lightSource() const
{
return PointLightSource::create(FloatPoint3D(x(), y(), z()));
}
Modified: trunk/Source/WebCore/svg/SVGFEPointLightElement.h (183610 => 183611)
--- trunk/Source/WebCore/svg/SVGFEPointLightElement.h 2015-04-30 03:15:23 UTC (rev 183610)
+++ trunk/Source/WebCore/svg/SVGFEPointLightElement.h 2015-04-30 03:21:27 UTC (rev 183611)
@@ -31,7 +31,7 @@
private:
SVGFEPointLightElement(const QualifiedName&, Document&);
- virtual PassRefPtr<LightSource> lightSource() const override;
+ virtual Ref<LightSource> lightSource() const override;
};
} // namespace WebCore
Modified: trunk/Source/WebCore/svg/SVGFESpotLightElement.cpp (183610 => 183611)
--- trunk/Source/WebCore/svg/SVGFESpotLightElement.cpp 2015-04-30 03:15:23 UTC (rev 183610)
+++ trunk/Source/WebCore/svg/SVGFESpotLightElement.cpp 2015-04-30 03:21:27 UTC (rev 183611)
@@ -36,7 +36,7 @@
return adoptRef(*new SVGFESpotLightElement(tagName, document));
}
-PassRefPtr<LightSource> SVGFESpotLightElement::lightSource() const
+Ref<LightSource> SVGFESpotLightElement::lightSource() const
{
FloatPoint3D pos(x(), y(), z());
FloatPoint3D direction(pointsAtX(), pointsAtY(), pointsAtZ());
Modified: trunk/Source/WebCore/svg/SVGFESpotLightElement.h (183610 => 183611)
--- trunk/Source/WebCore/svg/SVGFESpotLightElement.h 2015-04-30 03:15:23 UTC (rev 183610)
+++ trunk/Source/WebCore/svg/SVGFESpotLightElement.h 2015-04-30 03:21:27 UTC (rev 183611)
@@ -31,7 +31,7 @@
private:
SVGFESpotLightElement(const QualifiedName&, Document&);
- virtual PassRefPtr<LightSource> lightSource() const override;
+ virtual Ref<LightSource> lightSource() const override;
};
} // namespace WebCore
