Title: [183285] trunk/Source/WebCore
- Revision
- 183285
- Author
- [email protected]
- Date
- 2015-04-24 15:05:30 -0700 (Fri, 24 Apr 2015)
Log Message
Purge PassRefPtr from NamedNodeMap.
<https://webkit.org/b/144091>
Reviewed by Antti Koivisto.
Use RefPtr instead of PassRefPtr in NamedNodeMap.
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::getNamedItem):
(WebCore::NamedNodeMap::getNamedItemNS):
(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
(WebCore::NamedNodeMap::setNamedItem):
(WebCore::NamedNodeMap::setNamedItemNS):
(WebCore::NamedNodeMap::item):
* dom/NamedNodeMap.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (183284 => 183285)
--- trunk/Source/WebCore/ChangeLog 2015-04-24 22:01:44 UTC (rev 183284)
+++ trunk/Source/WebCore/ChangeLog 2015-04-24 22:05:30 UTC (rev 183285)
@@ -1,3 +1,22 @@
+2015-04-24 Andreas Kling <[email protected]>
+
+ Purge PassRefPtr from NamedNodeMap.
+ <https://webkit.org/b/144091>
+
+ Reviewed by Antti Koivisto.
+
+ Use RefPtr instead of PassRefPtr in NamedNodeMap.
+
+ * dom/NamedNodeMap.cpp:
+ (WebCore::NamedNodeMap::getNamedItem):
+ (WebCore::NamedNodeMap::getNamedItemNS):
+ (WebCore::NamedNodeMap::removeNamedItem):
+ (WebCore::NamedNodeMap::removeNamedItemNS):
+ (WebCore::NamedNodeMap::setNamedItem):
+ (WebCore::NamedNodeMap::setNamedItemNS):
+ (WebCore::NamedNodeMap::item):
+ * dom/NamedNodeMap.h:
+
2015-04-24 Commit Queue <[email protected]>
Unreviewed, rolling out r183266.
Modified: trunk/Source/WebCore/dom/NamedNodeMap.cpp (183284 => 183285)
--- trunk/Source/WebCore/dom/NamedNodeMap.cpp 2015-04-24 22:01:44 UTC (rev 183284)
+++ trunk/Source/WebCore/dom/NamedNodeMap.cpp 2015-04-24 22:05:30 UTC (rev 183285)
@@ -48,37 +48,37 @@
m_element.deref();
}
-PassRefPtr<Node> NamedNodeMap::getNamedItem(const AtomicString& name) const
+RefPtr<Node> NamedNodeMap::getNamedItem(const AtomicString& name) const
{
return m_element.getAttributeNode(name);
}
-PassRefPtr<Node> NamedNodeMap::getNamedItemNS(const AtomicString& namespaceURI, const AtomicString& localName) const
+RefPtr<Node> NamedNodeMap::getNamedItemNS(const AtomicString& namespaceURI, const AtomicString& localName) const
{
return m_element.getAttributeNodeNS(namespaceURI, localName);
}
-PassRefPtr<Node> NamedNodeMap::removeNamedItem(const AtomicString& name, ExceptionCode& ec)
+RefPtr<Node> NamedNodeMap::removeNamedItem(const AtomicString& name, ExceptionCode& ec)
{
unsigned index = m_element.hasAttributes() ? m_element.findAttributeIndexByName(name, shouldIgnoreAttributeCase(m_element)) : ElementData::attributeNotFound;
if (index == ElementData::attributeNotFound) {
ec = NOT_FOUND_ERR;
- return 0;
+ return nullptr;
}
return m_element.detachAttribute(index);
}
-PassRefPtr<Node> NamedNodeMap::removeNamedItemNS(const AtomicString& namespaceURI, const AtomicString& localName, ExceptionCode& ec)
+RefPtr<Node> NamedNodeMap::removeNamedItemNS(const AtomicString& namespaceURI, const AtomicString& localName, ExceptionCode& ec)
{
unsigned index = m_element.hasAttributes() ? m_element.findAttributeIndexByName(QualifiedName(nullAtom, localName, namespaceURI)) : ElementData::attributeNotFound;
if (index == ElementData::attributeNotFound) {
ec = NOT_FOUND_ERR;
- return 0;
+ return nullptr;
}
return m_element.detachAttribute(index);
}
-PassRefPtr<Node> NamedNodeMap::setNamedItem(Node* node, ExceptionCode& ec)
+RefPtr<Node> NamedNodeMap::setNamedItem(Node* node, ExceptionCode& ec)
{
if (!node) {
ec = NOT_FOUND_ERR;
@@ -94,12 +94,12 @@
return m_element.setAttributeNode(downcast<Attr>(node), ec);
}
-PassRefPtr<Node> NamedNodeMap::setNamedItemNS(Node* node, ExceptionCode& ec)
+RefPtr<Node> NamedNodeMap::setNamedItemNS(Node* node, ExceptionCode& ec)
{
return setNamedItem(node, ec);
}
-PassRefPtr<Node> NamedNodeMap::item(unsigned index) const
+RefPtr<Node> NamedNodeMap::item(unsigned index) const
{
if (index >= length())
return 0;
Modified: trunk/Source/WebCore/dom/NamedNodeMap.h (183284 => 183285)
--- trunk/Source/WebCore/dom/NamedNodeMap.h 2015-04-24 22:01:44 UTC (rev 183284)
+++ trunk/Source/WebCore/dom/NamedNodeMap.h 2015-04-24 22:05:30 UTC (rev 183285)
@@ -26,7 +26,7 @@
#define NamedNodeMap_h
#include "ScriptWrappable.h"
-#include <wtf/PassRefPtr.h>
+#include <wtf/RefPtr.h>
#include <wtf/text/AtomicString.h>
namespace WebCore {
@@ -51,16 +51,16 @@
// Public DOM interface.
- PassRefPtr<Node> getNamedItem(const AtomicString&) const;
- PassRefPtr<Node> removeNamedItem(const AtomicString& name, ExceptionCode&);
+ RefPtr<Node> getNamedItem(const AtomicString&) const;
+ RefPtr<Node> removeNamedItem(const AtomicString& name, ExceptionCode&);
- PassRefPtr<Node> getNamedItemNS(const AtomicString& namespaceURI, const AtomicString& localName) const;
- PassRefPtr<Node> removeNamedItemNS(const AtomicString& namespaceURI, const AtomicString& localName, ExceptionCode&);
+ RefPtr<Node> getNamedItemNS(const AtomicString& namespaceURI, const AtomicString& localName) const;
+ RefPtr<Node> removeNamedItemNS(const AtomicString& namespaceURI, const AtomicString& localName, ExceptionCode&);
- PassRefPtr<Node> setNamedItem(Node*, ExceptionCode&);
- PassRefPtr<Node> setNamedItemNS(Node*, ExceptionCode&);
+ RefPtr<Node> setNamedItem(Node*, ExceptionCode&);
+ RefPtr<Node> setNamedItemNS(Node*, ExceptionCode&);
- PassRefPtr<Node> item(unsigned index) const;
+ RefPtr<Node> item(unsigned index) const;
unsigned length() const;
Element& element() const { return m_element; }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
