Title: [183223] trunk/Tools
- Revision
- 183223
- Author
- [email protected]
- Date
- 2015-04-23 15:52:37 -0700 (Thu, 23 Apr 2015)
Log Message
lldb macro btjs sometimes can't get a frame description
https://bugs.webkit.org/show_bug.cgi?id=144130
Reviewed by Filip Pizlo.
We look to execute ExecState::describeFrame(). It appears that in some contexts the
debugger can't find ExecState. In those cases, CallFrame works as it is a typedef of
ExecState. Therefore we can fallback to using CallFrame::describeFrame().
* lldb/lldb_webkit.py:
(btjs):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (183222 => 183223)
--- trunk/Tools/ChangeLog 2015-04-23 22:45:59 UTC (rev 183222)
+++ trunk/Tools/ChangeLog 2015-04-23 22:52:37 UTC (rev 183223)
@@ -1,3 +1,17 @@
+2015-04-23 Michael Saboff <[email protected]>
+
+ lldb macro btjs sometimes can't get a frame description
+ https://bugs.webkit.org/show_bug.cgi?id=144130
+
+ Reviewed by Filip Pizlo.
+
+ We look to execute ExecState::describeFrame(). It appears that in some contexts the
+ debugger can't find ExecState. In those cases, CallFrame works as it is a typedef of
+ ExecState. Therefore we can fallback to using CallFrame::describeFrame().
+
+ * lldb/lldb_webkit.py:
+ (btjs):
+
2015-04-23 Alex Christensen <[email protected]>
Use less memory when compiling content extensions.
Modified: trunk/Tools/lldb/lldb_webkit.py (183222 => 183223)
--- trunk/Tools/lldb/lldb_webkit.py 2015-04-23 22:45:59 UTC (rev 183222)
+++ trunk/Tools/lldb/lldb_webkit.py 2015-04-23 22:52:37 UTC (rev 183223)
@@ -142,6 +142,8 @@
callFrame = frame.GetSP()
JSFrameDescription = frame.EvaluateExpression("((JSC::ExecState*)0x%x)->describeFrame()" % frame.GetFP()).GetSummary()
if not JSFrameDescription:
+ JSFrameDescription = frame.EvaluateExpression("((JSC::CallFrame*)0x%x)->describeFrame()" % frame.GetFP()).GetSummary()
+ if not JSFrameDescription:
JSFrameDescription = frame.EvaluateExpression("(char*)_ZN3JSC9ExecState13describeFrameEv(0x%x)" % frame.GetFP()).GetSummary()
if JSFrameDescription:
JSFrameDescription = string.strip(JSFrameDescription, '"')
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
