Title: [171770] branches/safari-600.1.4-branch/Source/WebCore
- Revision
- 171770
- Author
- [email protected]
- Date
- 2014-07-29 15:40:37 -0700 (Tue, 29 Jul 2014)
Log Message
Rollout r171702. <rdar://problem/16828238>
Modified Paths
Diff
Modified: branches/safari-600.1.4-branch/Source/WebCore/ChangeLog (171769 => 171770)
--- branches/safari-600.1.4-branch/Source/WebCore/ChangeLog 2014-07-29 22:38:58 UTC (rev 171769)
+++ branches/safari-600.1.4-branch/Source/WebCore/ChangeLog 2014-07-29 22:40:37 UTC (rev 171770)
@@ -1,5 +1,32 @@
2014-07-29 Matthew Hanson <[email protected]>
+ Rollout r171702. <rdar://problem/16828238>
+
+ 2014-07-29 Matthew Hanson <[email protected]>
+
+ Merge r171702. <rdar://problem/16828238>
+
+ 2014-07-28 Antti Koivisto <[email protected]>
+
+ <embed> videos flashes constantly while playing inline on iPad, making it unwatchable
+ https://bugs.webkit.org/show_bug.cgi?id=135356
+ <rdar://problem/16828238>
+
+ Reviewed by Simon Fraser.
+
+ The shadow tree for media controls is scheduling style recalc. The general silliness of
+ HTMLPlugInImageElement::willRecalcStyle/willDetachRenderers is turning those into render
+ tree reconstructions causing flicker.
+
+ * html/HTMLPlugInImageElement.cpp:
+ (WebCore::HTMLPlugInImageElement::willRecalcStyle):
+
+ Don't do the forced renderer reconstruction if there is no style change for the element
+ or its ancestors. This way recalcs scheduled by the shadow tree don't trigger the widget
+ update code path.
+
+2014-07-29 Matthew Hanson <[email protected]>
+
Rollout r171703. <rdar://problem/17833422>
2014-07-29 Matthew Hanson <[email protected]>
Modified: branches/safari-600.1.4-branch/Source/WebCore/html/HTMLPlugInImageElement.cpp (171769 => 171770)
--- branches/safari-600.1.4-branch/Source/WebCore/html/HTMLPlugInImageElement.cpp 2014-07-29 22:38:58 UTC (rev 171769)
+++ branches/safari-600.1.4-branch/Source/WebCore/html/HTMLPlugInImageElement.cpp 2014-07-29 22:40:37 UTC (rev 171770)
@@ -223,12 +223,8 @@
return HTMLPlugInElement::createElementRenderer(WTF::move(style));
}
-bool HTMLPlugInImageElement::willRecalcStyle(Style::Change change)
+bool HTMLPlugInImageElement::willRecalcStyle(Style::Change)
{
- // Make sure style recalcs scheduled by a child shadow tree don't trigger reconstruction and cause flicker.
- if (change == Style::NoChange && styleChangeType() == NoStyleChange)
- return true;
-
// FIXME: There shoudn't be need to force render tree reconstruction here.
// It is only done because loading and load event dispatching is tied to render tree construction.
if (!useFallbackContent() && needsWidgetUpdate() && renderer() && !isImageType() && (displayState() != DisplayingSnapshot))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
