Title: [165252] trunk/Source/WebCore
- Revision
- 165252
- Author
- [email protected]
- Date
- 2014-03-06 23:20:51 -0800 (Thu, 06 Mar 2014)
Log Message
WebCoreResourceHandleAsOperationQueueDelegate over-retains NSURLRequest.
<https://webkit.org/b/129862>
Don't retain the pointer before assigning it to a RetainPtr, since that
will cause the object to leak.
Reviewed by Alexey Proskuryakov.
* platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate continueWillSendRequest:]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (165251 => 165252)
--- trunk/Source/WebCore/ChangeLog 2014-03-07 06:39:51 UTC (rev 165251)
+++ trunk/Source/WebCore/ChangeLog 2014-03-07 07:20:51 UTC (rev 165252)
@@ -1,3 +1,16 @@
+2014-03-06 Andreas Kling <[email protected]>
+
+ WebCoreResourceHandleAsOperationQueueDelegate over-retains NSURLRequest.
+ <https://webkit.org/b/129862>
+
+ Don't retain the pointer before assigning it to a RetainPtr, since that
+ will cause the object to leak.
+
+ Reviewed by Alexey Proskuryakov.
+
+ * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
+ (-[WebCoreResourceHandleAsOperationQueueDelegate continueWillSendRequest:]):
+
2014-03-06 Dan Bernstein <[email protected]>
Don’t copy WebInputs.json into the framework.
Modified: trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm (165251 => 165252)
--- trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm 2014-03-07 06:39:51 UTC (rev 165251)
+++ trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm 2014-03-07 07:20:51 UTC (rev 165252)
@@ -77,7 +77,7 @@
- (void)continueWillSendRequest:(NSURLRequest *)newRequest
{
- m_requestResult = [newRequest retain];
+ m_requestResult = newRequest;
dispatch_semaphore_signal(m_semaphore);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
