Title: [165242] trunk/Source/WebCore
Revision
165242
Author
[email protected]
Date
2014-03-06 18:23:54 -0800 (Thu, 06 Mar 2014)

Log Message

CodeGeneratorJS.pm doesn't need to add spaces between consecutive closing template brackets
https://bugs.webkit.org/show_bug.cgi?id=129836

Reviewed by Andreas Kling.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
(GetNativeVectorInnerType):
(GetSVGPropertyTypes):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (165241 => 165242)


--- trunk/Source/WebCore/ChangeLog	2014-03-07 02:23:02 UTC (rev 165241)
+++ trunk/Source/WebCore/ChangeLog	2014-03-07 02:23:54 UTC (rev 165242)
@@ -1,3 +1,15 @@
+2014-03-06  Brian Burg  <[email protected]>
+
+        CodeGeneratorJS.pm doesn't need to add spaces between consecutive closing template brackets
+        https://bugs.webkit.org/show_bug.cgi?id=129836
+
+        Reviewed by Andreas Kling.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (GenerateParametersCheck):
+        (GetNativeVectorInnerType):
+        (GetSVGPropertyTypes):
+
 2014-03-06  Jinwoo Song  <[email protected]>
 
         Remove unused method from BatteryController

Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (165241 => 165242)


--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2014-03-07 02:23:02 UTC (rev 165241)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2014-03-07 02:23:54 UTC (rev 165242)
@@ -3216,9 +3216,6 @@
                 $nativeElementType = "String";
             } else {
                 $nativeElementType = GetNativeType($argType);
-                if ($nativeElementType =~ />$/) {
-                    $nativeElementType .= " ";
-                }
             }
 
             if (!IsNativeType($argType)) {
@@ -3599,7 +3596,7 @@
 
     return "String" if $arrayOrSequenceType eq "DOMString";
     return $nativeType{$arrayOrSequenceType} if exists $nativeType{$arrayOrSequenceType};
-    return "RefPtr<${arrayOrSequenceType}> ";
+    return "RefPtr<${arrayOrSequenceType}>";
 }
 
 sub GetNativeTypeForCallbacks
@@ -3620,13 +3617,10 @@
     my $svgNativeType;
 
     return ($svgPropertyType, $svgListPropertyType, $svgNativeType) if not $implType =~ /SVG/;
-    
+
     $svgNativeType = $codeGenerator->GetSVGTypeNeedingTearOff($implType);
     return ($svgPropertyType, $svgListPropertyType, $svgNativeType) if not $svgNativeType;
 
-    # Append space to avoid compilation errors when using  PassRefPtr<$svgNativeType>
-    $svgNativeType = "$svgNativeType ";
-
     my $svgWrappedNativeType = $codeGenerator->GetSVGWrappedTypeNeedingTearOff($implType);
     if ($svgNativeType =~ /SVGPropertyTearOff/) {
         $svgPropertyType = $svgWrappedNativeType;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to