Title: [165239] trunk/Tools
- Revision
- 165239
- Author
- [email protected]
- Date
- 2014-03-06 18:18:38 -0800 (Thu, 06 Mar 2014)
Log Message
detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
https://bugs.webkit.org/show_bug.cgi?id=129837
Reviewed by Michael Saboff.
ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
The fix is to use find instead of ls like we do in shell-runner.sh.
* Scripts/run-jsc-stress-tests:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (165238 => 165239)
--- trunk/Tools/ChangeLog 2014-03-07 02:16:20 UTC (rev 165238)
+++ trunk/Tools/ChangeLog 2014-03-07 02:18:38 UTC (rev 165239)
@@ -1,3 +1,15 @@
+2014-03-06 Mark Hahnenberg <[email protected]>
+
+ detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
+ https://bugs.webkit.org/show_bug.cgi?id=129837
+
+ Reviewed by Michael Saboff.
+
+ ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
+ The fix is to use find instead of ls like we do in shell-runner.sh.
+
+ * Scripts/run-jsc-stress-tests:
+
2014-03-06 Joseph Pecoraro <[email protected]>
filter-build-webkit should not strip .o
Modified: trunk/Tools/Scripts/run-jsc-stress-tests (165238 => 165239)
--- trunk/Tools/Scripts/run-jsc-stress-tests 2014-03-07 02:16:20 UTC (rev 165238)
+++ trunk/Tools/Scripts/run-jsc-stress-tests 2014-03-07 02:18:38 UTC (rev 165239)
@@ -1217,7 +1217,7 @@
raise if $bundle
if $remote
- output = sshRead("cd #{$remoteDirectory}/#{$outputDir.basename}/.runner && (ls test_fail_* 2> /dev/null || true)")
+ output = sshRead("cd #{$remoteDirectory}/#{$outputDir.basename}/.runner && find . -name \"test_fail_*\" -depth 1")
output.split(/\n/).each {
| line |
next unless line =~ /test_fail_/
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
