Title: [165230] trunk/Source/WebKit2
- Revision
- 165230
- Author
- [email protected]
- Date
- 2014-03-06 16:47:18 -0800 (Thu, 06 Mar 2014)
Log Message
[iOS] didUpdateVisibleRect: should use fabs, not abs
https://bugs.webkit.org/show_bug.cgi?id=129843
Reviewed by Benjamin Poulain.
When zooming we sent messages to the web process with an unchanging
zoom scale because of use of abs() rather than fabs().
* UIProcess/ios/WKContentView.mm:
(-[WKContentView didUpdateVisibleRect:unobscuredRect:scale:inStableState:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (165229 => 165230)
--- trunk/Source/WebKit2/ChangeLog 2014-03-07 00:26:55 UTC (rev 165229)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-07 00:47:18 UTC (rev 165230)
@@ -1,3 +1,16 @@
+2014-03-06 Simon Fraser <[email protected]>
+
+ [iOS] didUpdateVisibleRect: should use fabs, not abs
+ https://bugs.webkit.org/show_bug.cgi?id=129843
+
+ Reviewed by Benjamin Poulain.
+
+ When zooming we sent messages to the web process with an unchanging
+ zoom scale because of use of abs() rather than fabs().
+
+ * UIProcess/ios/WKContentView.mm:
+ (-[WKContentView didUpdateVisibleRect:unobscuredRect:scale:inStableState:]):
+
2014-03-06 Anders Carlsson <[email protected]>
Remove WebKit1 header includes from WebKit2
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm (165229 => 165230)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm 2014-03-07 00:26:55 UTC (rev 165229)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentView.mm 2014-03-07 00:47:18 UTC (rev 165230)
@@ -166,7 +166,7 @@
- (void)didUpdateVisibleRect:(CGRect)visibleRect unobscuredRect:(CGRect)unobscuredRect scale:(CGFloat)scale inStableState:(BOOL)isStableState
{
double scaleNoiseThreshold = 0.0005;
- if (!isStableState && abs(scale - _page->displayedContentScale()) < scaleNoiseThreshold) {
+ if (!isStableState && fabs(scale - _page->displayedContentScale()) < scaleNoiseThreshold) {
// Tiny changes of scale during interactive zoom cause content to jump by one pixel, creating
// visual noise. We filter those useless updates.
scale = _page->displayedContentScale();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
