Title: [165190] trunk/Source/WebCore
Revision
165190
Author
[email protected]
Date
2014-03-06 07:42:55 -0800 (Thu, 06 Mar 2014)

Log Message

Subpixel rendering: Setting content to opaque on m_graphicsLayer depends on subpixel accumulation.
https://bugs.webkit.org/show_bug.cgi?id=129776

Reviewed by Simon Fraser.

isEmpty() returns true when any of the dimensions is <= 0. Subpixel accumulation could happen
in one direction only. Use isZero() instead().

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (165189 => 165190)


--- trunk/Source/WebCore/ChangeLog	2014-03-06 15:01:12 UTC (rev 165189)
+++ trunk/Source/WebCore/ChangeLog	2014-03-06 15:42:55 UTC (rev 165190)
@@ -1,3 +1,16 @@
+2014-03-06  Zalan Bujtas  <[email protected]>
+
+        Subpixel rendering: Setting content to opaque on m_graphicsLayer depends on subpixel accumulation.
+        https://bugs.webkit.org/show_bug.cgi?id=129776
+
+        Reviewed by Simon Fraser.
+
+        isEmpty() returns true when any of the dimensions is <= 0. Subpixel accumulation could happen
+        in one direction only. Use isZero() instead().
+
+        * rendering/RenderLayerBacking.cpp:
+        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+
 2014-03-06  Gurpreet Kaur  <[email protected]>
 
         REGRESSION (r158254): Rubber-banding at Bing image search causes the toolbar to move up and away

Modified: trunk/Source/WebCore/rendering/RenderLayerBacking.cpp (165189 => 165190)


--- trunk/Source/WebCore/rendering/RenderLayerBacking.cpp	2014-03-06 15:01:12 UTC (rev 165189)
+++ trunk/Source/WebCore/rendering/RenderLayerBacking.cpp	2014-03-06 15:42:55 UTC (rev 165190)
@@ -819,7 +819,7 @@
     if (!m_isMainFrameRenderViewLayer) {
         // For non-root layers, background is always painted by the primary graphics layer.
         ASSERT(!m_backgroundLayer);
-        bool hadSubpixelRounding = !m_devicePixelFractionFromRenderer.isEmpty();
+        bool hadSubpixelRounding = !m_devicePixelFractionFromRenderer.isZero();
         m_graphicsLayer->setContentsOpaque(!hadSubpixelRounding && m_owningLayer.backgroundIsKnownToBeOpaqueInRect(localCompositingBounds));
     }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to