Title: [164967] trunk
- Revision
- 164967
- Author
- [email protected]
- Date
- 2014-03-02 20:49:38 -0800 (Sun, 02 Mar 2014)
Log Message
Remove ASSERT in ~IDBRequest since it is firing during legitimate uses in Web Inspector.
Adding the ASSERT back is tracked by https://webkit.org/b/129593.
https://bugs.webkit.org/show_bug.cgi?id=129328
Reviewed by Sam Weinig.
Source/WebCore:
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::~IDBRequest):
LayoutTests:
* TestExpectations: Remove skipped tests.
* inspector-protocol/model/probe-manager-add-remove-actions-expected.txt: Rebaselined.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (164966 => 164967)
--- trunk/LayoutTests/ChangeLog 2014-03-03 03:42:43 UTC (rev 164966)
+++ trunk/LayoutTests/ChangeLog 2014-03-03 04:49:38 UTC (rev 164967)
@@ -1,3 +1,16 @@
+2014-03-02 Timothy Hatcher <[email protected]>
+
+ Remove ASSERT in ~IDBRequest since it is firing during legitimate uses in Web Inspector.
+
+ Adding the ASSERT back is tracked by https://webkit.org/b/129593.
+
+ https://bugs.webkit.org/show_bug.cgi?id=129328
+
+ Reviewed by Sam Weinig.
+
+ * TestExpectations: Remove skipped tests.
+ * inspector-protocol/model/probe-manager-add-remove-actions-expected.txt: Rebaselined.
+
2014-03-02 Brian Burg <[email protected]>
Web Inspector model tests load wrong inspector page under WebKitTestRunner
Modified: trunk/LayoutTests/TestExpectations (164966 => 164967)
--- trunk/LayoutTests/TestExpectations 2014-03-03 03:42:43 UTC (rev 164966)
+++ trunk/LayoutTests/TestExpectations 2014-03-03 04:49:38 UTC (rev 164967)
@@ -95,9 +95,6 @@
webkit.org/b/129327 inspector-protocol/indexeddb/basics.html [ Pass Failure ]
-# These assert in IndexedDB code very freqyently.
-webkit.org/b/129328 inspector-protocol/model [ Skip ]
-
# Apparent fallout from http://trac.webkit.org/changeset/164830
webkit.org/b/129462 [ Release ] inspector-protocol/dom/dom-search-crash.html [ Skip ]
Modified: trunk/LayoutTests/inspector-protocol/model/probe-manager-add-remove-actions-expected.txt (164966 => 164967)
--- trunk/LayoutTests/inspector-protocol/model/probe-manager-add-remove-actions-expected.txt 2014-03-03 03:42:43 UTC (rev 164966)
+++ trunk/LayoutTests/inspector-protocol/model/probe-manager-add-remove-actions-expected.txt 2014-03-03 04:49:38 UTC (rev 164967)
@@ -8,6 +8,9 @@
Probe with identifier 2 was added to probe set.
Probe set's probe count: 2
Breakpoint actions changed. New count: 2
+Breakpoint resolved state changed: true
+Breakpoint resolved state changed: true
+Breakpoint resolved state changed: false
Breakpoint was added.
PASS: Breakpoint should be resolved.
inside breakpointActions a:(12) b:([object Object])
Modified: trunk/Source/WebCore/ChangeLog (164966 => 164967)
--- trunk/Source/WebCore/ChangeLog 2014-03-03 03:42:43 UTC (rev 164966)
+++ trunk/Source/WebCore/ChangeLog 2014-03-03 04:49:38 UTC (rev 164967)
@@ -1,3 +1,16 @@
+2014-03-02 Timothy Hatcher <[email protected]>
+
+ Remove ASSERT in ~IDBRequest since it is firing during legitimate uses in Web Inspector.
+
+ Adding the ASSERT back is tracked by https://webkit.org/b/129593.
+
+ https://bugs.webkit.org/show_bug.cgi?id=129328
+
+ Reviewed by Sam Weinig.
+
+ * Modules/indexeddb/IDBRequest.cpp:
+ (WebCore::IDBRequest::~IDBRequest):
+
2014-03-02 Commit Queue <[email protected]>
Unreviewed, rolling out r164961.
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp (164966 => 164967)
--- trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp 2014-03-03 03:42:43 UTC (rev 164966)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBRequest.cpp 2014-03-03 04:49:38 UTC (rev 164967)
@@ -90,7 +90,6 @@
IDBRequest::~IDBRequest()
{
- ASSERT(m_readyState == DONE || m_readyState == EarlyDeath || !scriptExecutionContext());
}
PassRefPtr<IDBAny> IDBRequest::result(ExceptionCode& ec) const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
