Title: [164750] trunk/Source/WebKit2
- Revision
- 164750
- Author
- [email protected]
- Date
- 2014-02-26 14:30:21 -0800 (Wed, 26 Feb 2014)
Log Message
Keyboard keeps showing up when clicking links after being shown once.
https://bugs.webkit.org/show_bug.cgi?id=129392
Reviewed by Benjamin Poulain.
This is a regression introduced by http://trac.webkit.org/changeset/164690.
_requiresKeyboardWhenFirstResponder should always return NO, if there is
no assisted node.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _requiresKeyboardWhenFirstResponder]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (164749 => 164750)
--- trunk/Source/WebKit2/ChangeLog 2014-02-26 22:20:47 UTC (rev 164749)
+++ trunk/Source/WebKit2/ChangeLog 2014-02-26 22:30:21 UTC (rev 164750)
@@ -1,3 +1,17 @@
+2014-02-26 Enrica Casucci <[email protected]>
+
+ Keyboard keeps showing up when clicking links after being shown once.
+ https://bugs.webkit.org/show_bug.cgi?id=129392
+
+ Reviewed by Benjamin Poulain.
+
+ This is a regression introduced by http://trac.webkit.org/changeset/164690.
+ _requiresKeyboardWhenFirstResponder should always return NO, if there is
+ no assisted node.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView _requiresKeyboardWhenFirstResponder]):
+
2014-02-26 Myles C. Maxfield <[email protected]>
WebProcessProxy::updateProcessState() is causing duplicate symbol linker errors
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (164749 => 164750)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2014-02-26 22:20:47 UTC (rev 164749)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2014-02-26 22:30:21 UTC (rev 164750)
@@ -361,6 +361,8 @@
{
// FIXME: We should add the logic to handle keyboard visibility during focus redirects.
switch (_assistedNodeInformation.elementType) {
+ case WebKit::WKTypeNone:
+ return NO;
case WebKit::WKTypeSelect:
return !UICurrentUserInterfaceIdiomIsPad();
case WebKit::WKTypeDate:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
