Title: [164423] trunk
- Revision
- 164423
- Author
- [email protected]
- Date
- 2014-02-20 02:24:14 -0800 (Thu, 20 Feb 2014)
Log Message
AX: Children Nodes for Canvas objects are not equal to Render Objects.
https://bugs.webkit.org/show_bug.cgi?id=123568
Patch by Artur Moryc <[email protected]> on 2014-02-20
Reviewed by Chris Fleizach.
Source/WebCore:
There is a difference in children nodes taken into account for RenderObject
and for NodeObject types. There is a problem with text nodes that are
focusable for EFL/GTK and therefore are not filtered out in the test like it
happens for the MAC port. Text nodes are eliminated in the
AccessibilityRenderObject::computeAccessibilityIsIgnored() method. The same
approach has been applied to the NodeObject to eliminate text nodes.
Covered by existing tests.
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored):
LayoutTests:
The canvas-accessibilitynodeobject.html test is not failing anymore.
* platform/efl-wk1/TestExpectations:
* platform/efl-wk2/TestExpectations:
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (164422 => 164423)
--- trunk/LayoutTests/ChangeLog 2014-02-20 09:57:03 UTC (rev 164422)
+++ trunk/LayoutTests/ChangeLog 2014-02-20 10:24:14 UTC (rev 164423)
@@ -1,3 +1,16 @@
+2014-02-20 Artur Moryc <[email protected]>
+
+ AX: Children Nodes for Canvas objects are not equal to Render Objects.
+ https://bugs.webkit.org/show_bug.cgi?id=123568
+
+ Reviewed by Chris Fleizach.
+
+ The canvas-accessibilitynodeobject.html test is not failing anymore.
+
+ * platform/efl-wk1/TestExpectations:
+ * platform/efl-wk2/TestExpectations:
+ * platform/gtk/TestExpectations:
+
2014-02-20 Frédéric Wang <[email protected]>
Implement the MathML Operator Dictionary.
Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (164422 => 164423)
--- trunk/LayoutTests/platform/efl-wk1/TestExpectations 2014-02-20 09:57:03 UTC (rev 164422)
+++ trunk/LayoutTests/platform/efl-wk1/TestExpectations 2014-02-20 10:24:14 UTC (rev 164423)
@@ -106,7 +106,6 @@
webkit.org/b/111988 accessibility/aria-readonly.html [ Failure ]
webkit.org/b/111991 accessibility/aria-text-role.html [ Failure ]
webkit.org/b/111992 accessibility/aria-used-on-image-maps.html [ Failure ]
-webkit.org/b/111994 accessibility/canvas-accessibilitynodeobject.html [ Failure ]
webkit.org/b/111996 accessibility/canvas-fallback-content-2.html [ Failure ]
webkit.org/b/111999 accessibility/disabled-controls-not-focusable.html [ Failure ]
webkit.org/b/122109 accessibility/file-upload-button-stringvalue.html [ Failure ]
Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (164422 => 164423)
--- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2014-02-20 09:57:03 UTC (rev 164422)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2014-02-20 10:24:14 UTC (rev 164423)
@@ -264,7 +264,6 @@
webkit.org/b/111984 accessibility/aria-hidden-updates-alldescendants.html [ Failure ]
webkit.org/b/111988 accessibility/aria-readonly.html [ Failure ]
webkit.org/b/111991 accessibility/aria-text-role.html [ Failure ]
-webkit.org/b/111994 accessibility/canvas-accessibilitynodeobject.html [ Failure ]
webkit.org/b/111996 accessibility/canvas-fallback-content-2.html [ Failure ]
webkit.org/b/111999 accessibility/disabled-controls-not-focusable.html [ Failure ]
webkit.org/b/112002 accessibility/inline-continuations.html [ Failure ]
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (164422 => 164423)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2014-02-20 09:57:03 UTC (rev 164422)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2014-02-20 10:24:14 UTC (rev 164423)
@@ -1249,8 +1249,6 @@
# This failure appears to be GTK-specific
webkit.org/b/91319 css2.1/20110323/vertical-align-boxes-001.htm [ ImageOnlyFailure ]
-webkit.org/b/92100 accessibility/canvas-accessibilitynodeobject.html [ Failure ]
-
webkit.org/b/93976 fast/css-generated-content/quotes-lang.html [ ImageOnlyFailure ]
# This has always failed on Gtk/Efl - exposed by bug 89826
Modified: trunk/Source/WebCore/ChangeLog (164422 => 164423)
--- trunk/Source/WebCore/ChangeLog 2014-02-20 09:57:03 UTC (rev 164422)
+++ trunk/Source/WebCore/ChangeLog 2014-02-20 10:24:14 UTC (rev 164423)
@@ -1,3 +1,22 @@
+2014-02-20 Artur Moryc <[email protected]>
+
+ AX: Children Nodes for Canvas objects are not equal to Render Objects.
+ https://bugs.webkit.org/show_bug.cgi?id=123568
+
+ Reviewed by Chris Fleizach.
+
+ There is a difference in children nodes taken into account for RenderObject
+ and for NodeObject types. There is a problem with text nodes that are
+ focusable for EFL/GTK and therefore are not filtered out in the test like it
+ happens for the MAC port. Text nodes are eliminated in the
+ AccessibilityRenderObject::computeAccessibilityIsIgnored() method. The same
+ approach has been applied to the NodeObject to eliminate text nodes.
+
+ Covered by existing tests.
+
+ * accessibility/AccessibilityNodeObject.cpp:
+ (WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored):
+
2014-02-20 Zan Dobersek <[email protected]>
Move to using std::unique_ptr for KeyboardEvent, ScriptExecutionContext::PendingException
Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (164422 => 164423)
--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2014-02-20 09:57:03 UTC (rev 164422)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp 2014-02-20 10:24:14 UTC (rev 164423)
@@ -428,7 +428,12 @@
if (!string.length())
return true;
}
-
+
+ AccessibilityObjectInclusion decision = defaultObjectInclusion();
+ if (decision == IncludeObject)
+ return false;
+ if (decision == IgnoreObject)
+ return true;
// If this element is within a parent that cannot have children, it should not be exposed.
if (isDescendantOfBarrenParent())
return true;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
