Title: [164237] trunk/Source/_javascript_Core
- Revision
- 164237
- Author
- [email protected]
- Date
- 2014-02-17 11:39:50 -0800 (Mon, 17 Feb 2014)
Log Message
Fix RegisterSet::calleeSaveRegisters() by making it correct on ARM64
https://bugs.webkit.org/show_bug.cgi?id=128921
Reviewed by Mark Hahnenberg.
* jit/RegisterSet.cpp:
(JSC::RegisterSet::calleeSaveRegisters):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (164236 => 164237)
--- trunk/Source/_javascript_Core/ChangeLog 2014-02-17 19:36:01 UTC (rev 164236)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-02-17 19:39:50 UTC (rev 164237)
@@ -1,5 +1,15 @@
2014-02-17 Filip Pizlo <[email protected]>
+ Fix RegisterSet::calleeSaveRegisters() by making it correct on ARM64
+ https://bugs.webkit.org/show_bug.cgi?id=128921
+
+ Reviewed by Mark Hahnenberg.
+
+ * jit/RegisterSet.cpp:
+ (JSC::RegisterSet::calleeSaveRegisters):
+
+2014-02-17 Filip Pizlo <[email protected]>
+
RegisterSet::calleeSaveRegisters() should know about ARM64
https://bugs.webkit.org/show_bug.cgi?id=128918
Modified: trunk/Source/_javascript_Core/jit/RegisterSet.cpp (164236 => 164237)
--- trunk/Source/_javascript_Core/jit/RegisterSet.cpp 2014-02-17 19:36:01 UTC (rev 164236)
+++ trunk/Source/_javascript_Core/jit/RegisterSet.cpp 2014-02-17 19:39:50 UTC (rev 164237)
@@ -65,11 +65,19 @@
result.set(X86Registers::r14);
result.set(X86Registers::r15);
#elif CPU(ARM64)
+ // We don't include LR in the set of callee-save registers even though it technically belongs
+ // there. But, the way we use this list, it makes no sense to have it there.
for (
ARM64Registers::RegisterID reg = ARM64Registers::x19;
reg <= ARM64Registers::x28;
reg = static_cast<ARM64Registers::RegisterID>(reg + 1))
result.set(reg);
+ result.set(ARM64Registers::fp);
+ for (
+ ARM64Registers::FPRegisterID reg = ARM64Registers::q8;
+ reg <= ARM64Registers::q15;
+ reg = static_cast<ARM64Registers::FPRegisterID>(reg + 1))
+ result.set(reg);
#else
UNREACHABLE_FOR_PLATFORM();
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
