Title: [164235] trunk/Source
- Revision
- 164235
- Author
- [email protected]
- Date
- 2014-02-17 11:26:55 -0800 (Mon, 17 Feb 2014)
Log Message
WebKitGTK+ should stop calling functions to set the view source mode
https://bugs.webkit.org/show_bug.cgi?id=128919
Reviewed by Carlos Garcia Campos.
This is a first step towards getting rid of the view source mode from WebCore.
View source shouldn't be a mode on the web page and can be implemented in other ways by
embedding apps. Furthermore, the inspector has an excellent view source mode.
Source/WebKit/gtk:
* webkit/webkitwebview.cpp:
(webkit_web_view_set_view_source_mode):
(webkit_web_view_get_view_source_mode):
Turn these into no-ops.
Source/WebKit2:
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_set_view_mode):
(webkit_web_view_get_view_mode):
Turn these into no-ops.
Modified Paths
Diff
Modified: trunk/Source/WebKit/gtk/ChangeLog (164234 => 164235)
--- trunk/Source/WebKit/gtk/ChangeLog 2014-02-17 19:22:14 UTC (rev 164234)
+++ trunk/Source/WebKit/gtk/ChangeLog 2014-02-17 19:26:55 UTC (rev 164235)
@@ -1,3 +1,19 @@
+2014-02-17 Anders Carlsson <[email protected]>
+
+ WebKitGTK+ should stop calling functions to set the view source mode
+ https://bugs.webkit.org/show_bug.cgi?id=128919
+
+ Reviewed by Carlos Garcia Campos.
+
+ This is a first step towards getting rid of the view source mode from WebCore.
+ View source shouldn't be a mode on the web page and can be implemented in other ways by
+ embedding apps. Furthermore, the inspector has an excellent view source mode.
+
+ * webkit/webkitwebview.cpp:
+ (webkit_web_view_set_view_source_mode):
+ (webkit_web_view_get_view_source_mode):
+ Turn these into no-ops.
+
2014-02-11 Zalan Bujtas <[email protected]>
Subpixel rendering: Make GraphicsLayerClient::paintContents's clip rect subpixel based.
Modified: trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp (164234 => 164235)
--- trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp 2014-02-17 19:22:14 UTC (rev 164234)
+++ trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp 2014-02-17 19:26:55 UTC (rev 164235)
@@ -5191,7 +5191,7 @@
{
g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
- core(webView)->mainFrame().setInViewSourceMode(mode);
+ g_warning("webkit_web_view_set_view_source_mode has been deprecated and is a no-op.");
}
/**
@@ -5206,7 +5206,8 @@
{
g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(webView), FALSE);
- return core(webView)->mainFrame().inViewSourceMode();
+ g_warning("webkit_web_view_get_view_source_mode has been deprecated and always returns FALSE.");
+ return FALSE;
}
// Internal subresource management
Modified: trunk/Source/WebKit2/ChangeLog (164234 => 164235)
--- trunk/Source/WebKit2/ChangeLog 2014-02-17 19:22:14 UTC (rev 164234)
+++ trunk/Source/WebKit2/ChangeLog 2014-02-17 19:26:55 UTC (rev 164235)
@@ -1,5 +1,21 @@
2014-02-17 Anders Carlsson <[email protected]>
+ WebKitGTK+ should stop calling functions to set the view source mode
+ https://bugs.webkit.org/show_bug.cgi?id=128919
+
+ Reviewed by Carlos Garcia Campos.
+
+ This is a first step towards getting rid of the view source mode from WebCore.
+ View source shouldn't be a mode on the web page and can be implemented in other ways by
+ embedding apps. Furthermore, the inspector has an excellent view source mode.
+
+ * UIProcess/API/gtk/WebKitWebView.cpp:
+ (webkit_web_view_set_view_mode):
+ (webkit_web_view_get_view_mode):
+ Turn these into no-ops.
+
+2014-02-17 Anders Carlsson <[email protected]>
+
Turn the history client into a fancy API::HistoryClient abstract base class
https://bugs.webkit.org/show_bug.cgi?id=128917
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (164234 => 164235)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-02-17 19:22:14 UTC (rev 164234)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2014-02-17 19:26:55 UTC (rev 164235)
@@ -163,7 +163,6 @@
double estimatedLoadProgress;
CString activeURI;
bool isLoading;
- WebKitViewMode viewMode;
bool waitingForMainResource;
unsigned long mainResourceResponseHandlerID;
@@ -3033,13 +3032,7 @@
{
g_return_if_fail(WEBKIT_IS_WEB_VIEW(webView));
- if (webView->priv->viewMode == viewMode)
- return;
-
- getPage(webView)->setMainFrameInViewSourceMode(viewMode == WEBKIT_VIEW_MODE_SOURCE);
-
- webView->priv->viewMode = viewMode;
- g_object_notify(G_OBJECT(webView), "view-mode");
+ g_warning("webkit_web_view_set_view_mode has been deprecated and is a no-op.");
}
/**
@@ -3054,7 +3047,8 @@
{
g_return_val_if_fail(WEBKIT_IS_WEB_VIEW(webView), WEBKIT_VIEW_MODE_WEB);
- return webView->priv->viewMode;
+ g_warning("webkit_web_view_get_view_mode has been deprecated and always returns WEBKIT_VIEW_MODE_WEB.");
+ return WEBKIT_VIEW_MODE_WEB;
}
/**
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
