Title: [160238] trunk/Source/_javascript_Core
Revision
160238
Author
[email protected]
Date
2013-12-06 12:30:31 -0800 (Fri, 06 Dec 2013)

Log Message

FTL shouldn't have a doubleToUInt32 path
https://bugs.webkit.org/show_bug.cgi?id=125360

Reviewed by Mark Hahnenberg.
        
This code existed because I incorrectly thought it was necessary. It's now basically
dead.

* ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (160237 => 160238)


--- trunk/Source/_javascript_Core/ChangeLog	2013-12-06 20:17:50 UTC (rev 160237)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-12-06 20:30:31 UTC (rev 160238)
@@ -1,3 +1,16 @@
+2013-12-06  Filip Pizlo  <[email protected]>
+
+        FTL shouldn't have a doubleToUInt32 path
+        https://bugs.webkit.org/show_bug.cgi?id=125360
+
+        Reviewed by Mark Hahnenberg.
+        
+        This code existed because I incorrectly thought it was necessary. It's now basically
+        dead.
+
+        * ftl/FTLLowerDFGToLLVM.cpp:
+        (JSC::FTL::LowerDFGToLLVM::compilePutByVal):
+
 2013-12-06  Laszlo Vidacs  <[email protected]>
 
         Define SHA1 hash size in SHA1.h and use it at various places.

Modified: trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp (160237 => 160238)


--- trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2013-12-06 20:17:50 UTC (rev 160237)
+++ trunk/Source/_javascript_Core/ftl/FTLLowerDFGToLLVM.cpp	2013-12-06 20:30:31 UTC (rev 160238)
@@ -1705,10 +1705,8 @@
                             
                             m_out.appendTo(continuation, lastNext);
                             intValue = m_out.phi(m_out.int32, intValues);
-                        } else if (isSigned(type))
+                        } else
                             intValue = doubleToInt32(doubleValue);
-                        else
-                            intValue = doubleToUInt32(doubleValue);
                         break;
                     }
                         
@@ -3018,14 +3016,6 @@
         return doubleToInt32(doubleValue, -limit, limit);
     }
     
-    LValue doubleToUInt32(LValue doubleValue)
-    {
-        if (Output::hasSensibleDoubleToInt())
-            return sensibleDoubleToInt32(doubleValue);
-        
-        return doubleToInt32(doubleValue, 0, pow(2, 32) - 1, false);
-    }
-    
     LValue sensibleDoubleToInt32(LValue doubleValue)
     {
         LBasicBlock slowPath = FTL_NEW_BLOCK(m_out, ("sensible doubleToInt32 slow path"));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to