Title: [160235] trunk/Source/WebCore
Revision
160235
Author
[email protected]
Date
2013-12-06 11:31:50 -0800 (Fri, 06 Dec 2013)

Log Message

Clean up the includes of RenderBlock.h
https://bugs.webkit.org/show_bug.cgi?id=125351

Reviewed by Darin Adler.

I turned some header includes into forward declarations. I also removed /
moved out some includes, which don't belong to RenderBlock.h anymore.

No new tests, no behavior change.

* editing/VisibleUnits.cpp:
* html/HTMLInputElement.cpp:
* html/HTMLTextAreaElement.cpp:
* html/TextFieldInputType.cpp:
* html/TextInputType.cpp:
* rendering/InlineElementBox.cpp:
* rendering/RenderBlock.h:
* rendering/RenderBlockFlow.cpp:
* rendering/line/LineBreaker.h:
* rendering/line/LineWidth.cpp:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (160234 => 160235)


--- trunk/Source/WebCore/ChangeLog	2013-12-06 19:28:30 UTC (rev 160234)
+++ trunk/Source/WebCore/ChangeLog	2013-12-06 19:31:50 UTC (rev 160235)
@@ -1,3 +1,26 @@
+2013-12-06  Zoltan Horvath  <[email protected]>
+
+        Clean up the includes of RenderBlock.h 
+        https://bugs.webkit.org/show_bug.cgi?id=125351
+
+        Reviewed by Darin Adler.
+
+        I turned some header includes into forward declarations. I also removed / 
+        moved out some includes, which don't belong to RenderBlock.h anymore.
+
+        No new tests, no behavior change.
+
+        * editing/VisibleUnits.cpp:
+        * html/HTMLInputElement.cpp:
+        * html/HTMLTextAreaElement.cpp:
+        * html/TextFieldInputType.cpp:
+        * html/TextInputType.cpp:
+        * rendering/InlineElementBox.cpp:
+        * rendering/RenderBlock.h:
+        * rendering/RenderBlockFlow.cpp:
+        * rendering/line/LineBreaker.h:
+        * rendering/line/LineWidth.cpp:
+
 2013-12-06  Laszlo Vidacs  <[email protected]>
 
         Define SHA1 hash size in SHA1.h and use it at various places.

Modified: trunk/Source/WebCore/editing/VisibleUnits.cpp (160234 => 160235)


--- trunk/Source/WebCore/editing/VisibleUnits.cpp	2013-12-06 19:28:30 UTC (rev 160234)
+++ trunk/Source/WebCore/editing/VisibleUnits.cpp	2013-12-06 19:31:50 UTC (rev 160235)
@@ -36,6 +36,7 @@
 #include "RenderedPosition.h"
 #include "Text.h"
 #include "TextBoundaries.h"
+#include "TextBreakIterator.h"
 #include "TextIterator.h"
 #include "VisibleSelection.h"
 #include "htmlediting.h"

Modified: trunk/Source/WebCore/html/HTMLInputElement.cpp (160234 => 160235)


--- trunk/Source/WebCore/html/HTMLInputElement.cpp	2013-12-06 19:28:30 UTC (rev 160234)
+++ trunk/Source/WebCore/html/HTMLInputElement.cpp	2013-12-06 19:31:50 UTC (rev 160235)
@@ -61,6 +61,7 @@
 #include "ScopedEventQueue.h"
 #include "SearchInputType.h"
 #include "StyleResolver.h"
+#include "TextBreakIterator.h"
 #include <wtf/MathExtras.h>
 #include <wtf/Ref.h>
 

Modified: trunk/Source/WebCore/html/HTMLTextAreaElement.cpp (160234 => 160235)


--- trunk/Source/WebCore/html/HTMLTextAreaElement.cpp	2013-12-06 19:28:30 UTC (rev 160234)
+++ trunk/Source/WebCore/html/HTMLTextAreaElement.cpp	2013-12-06 19:31:50 UTC (rev 160235)
@@ -45,6 +45,7 @@
 #include "RenderTextControlMultiLine.h"
 #include "ShadowRoot.h"
 #include "Text.h"
+#include "TextBreakIterator.h"
 #include "TextControlInnerElements.h"
 #include "TextIterator.h"
 #include "TextNodeTraversal.h"

Modified: trunk/Source/WebCore/html/TextFieldInputType.cpp (160234 => 160235)


--- trunk/Source/WebCore/html/TextFieldInputType.cpp	2013-12-06 19:28:30 UTC (rev 160234)
+++ trunk/Source/WebCore/html/TextFieldInputType.cpp	2013-12-06 19:31:50 UTC (rev 160235)
@@ -47,6 +47,7 @@
 #include "RenderTextControlSingleLine.h"
 #include "RenderTheme.h"
 #include "ShadowRoot.h"
+#include "TextBreakIterator.h"
 #include "TextControlInnerElements.h"
 #include "TextEvent.h"
 #include "TextIterator.h"

Modified: trunk/Source/WebCore/html/TextInputType.cpp (160234 => 160235)


--- trunk/Source/WebCore/html/TextInputType.cpp	2013-12-06 19:28:30 UTC (rev 160234)
+++ trunk/Source/WebCore/html/TextInputType.cpp	2013-12-06 19:31:50 UTC (rev 160235)
@@ -33,6 +33,7 @@
 
 #include "HTMLInputElement.h"
 #include "InputTypeNames.h"
+#include "TextBreakIterator.h"
 
 namespace WebCore {
 

Modified: trunk/Source/WebCore/rendering/InlineElementBox.cpp (160234 => 160235)


--- trunk/Source/WebCore/rendering/InlineElementBox.cpp	2013-12-06 19:28:30 UTC (rev 160234)
+++ trunk/Source/WebCore/rendering/InlineElementBox.cpp	2013-12-06 19:31:50 UTC (rev 160235)
@@ -26,6 +26,7 @@
 #include "config.h"
 #include "InlineElementBox.h"
 
+#include "InlineFlowBox.h"
 #include "PaintInfo.h"
 #include "RenderBlock.h"
 #include "RenderBox.h"

Modified: trunk/Source/WebCore/rendering/RenderBlock.h (160234 => 160235)


--- trunk/Source/WebCore/rendering/RenderBlock.h	2013-12-06 19:28:30 UTC (rev 160234)
+++ trunk/Source/WebCore/rendering/RenderBlock.h	2013-12-06 19:31:50 UTC (rev 160235)
@@ -25,25 +25,21 @@
 
 #include "ColumnInfo.h"
 #include "GapRects.h"
-#include "PODIntervalTree.h"
 #include "RenderBox.h"
-#include "RootInlineBox.h"
-#include "TextBreakIterator.h"
 #include "TextRun.h"
 #include <wtf/OwnPtr.h>
 #include <wtf/ListHashSet.h>
 
-#if ENABLE(CSS_SHAPES)
-#include "ShapeInsideInfo.h"
-#include "ShapeValue.h"
-#endif
-
 namespace WebCore {
 
 class LineLayoutState;
 class LogicalSelectionOffsetCaches;
 class RenderInline;
 class RenderText;
+#if ENABLE(CSS_SHAPES)
+class ShapeInsideInfo;
+class ShapeValue;
+#endif
 
 struct BidiRun;
 struct PaintInfo;

Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (160234 => 160235)


--- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp	2013-12-06 19:28:30 UTC (rev 160234)
+++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp	2013-12-06 19:31:50 UTC (rev 160235)
@@ -40,6 +40,10 @@
 #include "VerticalPositionCache.h"
 #include "VisiblePosition.h"
 
+#if ENABLE(CSS_SHAPES)
+#include "ShapeInsideInfo.h"
+#endif
+
 namespace WebCore {
 
 bool RenderBlock::s_canPropagateFloatIntoSibling = false;

Modified: trunk/Source/WebCore/rendering/line/LineBreaker.h (160234 => 160235)


--- trunk/Source/WebCore/rendering/line/LineBreaker.h	2013-12-06 19:28:30 UTC (rev 160234)
+++ trunk/Source/WebCore/rendering/line/LineBreaker.h	2013-12-06 19:31:50 UTC (rev 160235)
@@ -28,6 +28,7 @@
 #include "InlineIterator.h"
 #include "LineInfo.h"
 #include "LineInlineHeaders.h"
+#include "TextBreakIterator.h"
 #include <wtf/Vector.h>
 
 namespace WebCore {

Modified: trunk/Source/WebCore/rendering/line/LineWidth.cpp (160234 => 160235)


--- trunk/Source/WebCore/rendering/line/LineWidth.cpp	2013-12-06 19:28:30 UTC (rev 160234)
+++ trunk/Source/WebCore/rendering/line/LineWidth.cpp	2013-12-06 19:31:50 UTC (rev 160235)
@@ -33,6 +33,10 @@
 #include "RenderBlockFlow.h"
 #include "RenderRubyRun.h"
 
+#if ENABLE(CSS_SHAPES)
+#include "ShapeInsideInfo.h"
+#endif
+
 namespace WebCore {
 
 LineWidth::LineWidth(RenderBlockFlow& block, bool isFirstLine, IndentTextOrNot shouldIndentText)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to