Title: [155059] trunk
- Revision
- 155059
- Author
- [email protected]
- Date
- 2013-09-04 12:57:18 -0700 (Wed, 04 Sep 2013)
Log Message
AX: aria-valuetext property not exposing AXValueDescription
https://bugs.webkit.org/show_bug.cgi?id=120375
Reviewed by Darin Adler.
Source/WebCore:
Expose value based attributes for incrementor roles (which are called spinbuttons by ARIA).
Test: platform/mac/accessibility/spinbutton-valuedescription.html
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
LayoutTests:
* platform/mac/accessibility/spinbutton-valuedescription-expected.txt: Added.
* platform/mac/accessibility/spinbutton-valuedescription.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (155058 => 155059)
--- trunk/LayoutTests/ChangeLog 2013-09-04 19:52:25 UTC (rev 155058)
+++ trunk/LayoutTests/ChangeLog 2013-09-04 19:57:18 UTC (rev 155059)
@@ -1,3 +1,13 @@
+2013-09-04 Chris Fleizach <[email protected]>
+
+ AX: aria-valuetext property not exposing AXValueDescription
+ https://bugs.webkit.org/show_bug.cgi?id=120375
+
+ Reviewed by Darin Adler.
+
+ * platform/mac/accessibility/spinbutton-valuedescription-expected.txt: Added.
+ * platform/mac/accessibility/spinbutton-valuedescription.html: Added.
+
2013-09-04 Javier Fernandez <[email protected]>
<https://webkit.org/b/119622> [CSSRegions] Not possible to clear the selection when mixing content from different FlowThreads
Added: trunk/LayoutTests/platform/mac/accessibility/spinbutton-valuedescription-expected.txt (0 => 155059)
--- trunk/LayoutTests/platform/mac/accessibility/spinbutton-valuedescription-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/spinbutton-valuedescription-expected.txt 2013-09-04 19:57:18 UTC (rev 155059)
@@ -0,0 +1,17 @@
+spinbutton
+This tests that aria-value* properties work on spinbutton roles.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS spin.valueDescription is 'Monday'
+PASS spin.stringValue is 'AXValue: 4'
+PASS spin.minValue is 1
+PASS spin.maxValue is 7
+PASS spin.isAttributeSupported('AXValueDescription') is true
+PASS spin.isAttributeSupported('AXMaxValue') is true
+PASS spin.isAttributeSupported('AXMinValue') is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/platform/mac/accessibility/spinbutton-valuedescription.html (0 => 155059)
--- trunk/LayoutTests/platform/mac/accessibility/spinbutton-valuedescription.html (rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/spinbutton-valuedescription.html 2013-09-04 19:57:18 UTC (rev 155059)
@@ -0,0 +1,34 @@
+<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
+<html>
+<head>
+<script src=""
+</head>
+<body id="body">
+
+<div role="spinbutton" id="spin" aria-valuetext="Monday" aria-valuemin="1" aria-valuemax="7" aria-valuenow="4">spinbutton</div>
+
+<p id="description"></p>
+<div id="console"></div>
+
+<script>
+
+ description("This tests that aria-value* properties work on spinbutton roles.");
+
+ if (window.accessibilityController) {
+
+ var spin = accessibilityController.accessibleElementById("spin");
+ shouldBe("spin.valueDescription", "'Monday'");
+ shouldBe("spin.stringValue", "'AXValue: 4'");
+ shouldBe("spin.minValue", "1");
+ shouldBe("spin.maxValue", "7");
+
+ shouldBeTrue("spin.isAttributeSupported('AXValueDescription')");
+ shouldBeTrue("spin.isAttributeSupported('AXMaxValue')");
+ shouldBeTrue("spin.isAttributeSupported('AXMinValue')");
+ }
+
+</script>
+
+<script src=""
+</body>
+</html>
Modified: trunk/Source/WebCore/ChangeLog (155058 => 155059)
--- trunk/Source/WebCore/ChangeLog 2013-09-04 19:52:25 UTC (rev 155058)
+++ trunk/Source/WebCore/ChangeLog 2013-09-04 19:57:18 UTC (rev 155059)
@@ -1,3 +1,17 @@
+2013-09-04 Chris Fleizach <[email protected]>
+
+ AX: aria-valuetext property not exposing AXValueDescription
+ https://bugs.webkit.org/show_bug.cgi?id=120375
+
+ Reviewed by Darin Adler.
+
+ Expose value based attributes for incrementor roles (which are called spinbuttons by ARIA).
+
+ Test: platform/mac/accessibility/spinbutton-valuedescription.html
+
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):
+
2013-09-04 Javier Fernandez <[email protected]>
<https://webkit.org/b/119622> [CSSRegions] Not possible to clear the selection when mixing content from different FlowThreads
Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (155058 => 155059)
--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2013-09-04 19:52:25 UTC (rev 155058)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm 2013-09-04 19:57:18 UTC (rev 155059)
@@ -1244,6 +1244,9 @@
tempArray = [[NSMutableArray alloc] initWithArray:attributes];
[tempArray addObject:NSAccessibilityIncrementButtonAttribute];
[tempArray addObject:NSAccessibilityDecrementButtonAttribute];
+ [tempArray addObject:NSAccessibilityValueDescriptionAttribute];
+ [tempArray addObject:NSAccessibilityMinValueAttribute];
+ [tempArray addObject:NSAccessibilityMaxValueAttribute];
incrementorAttrs = [[NSArray alloc] initWithArray:tempArray];
[tempArray release];
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
