[webkit-changes] [154818] trunk/Source/WebKit2

Thu, 29 Aug 2013 10:22:08 -0700

Title: [154818] trunk/Source/WebKit2
Revision
154818
Author
[email protected]
Date
2013-08-29 10:22:16 -0700 (Thu, 29 Aug 2013)

Log Message

[GTK] [WK2] TestWebKitWebView page-visibility fails
https://bugs.webkit.org/show_bug.cgi?id=120406

Patch by Brian Holt <[email protected]> on 2013-08-29
Reviewed by Gustavo Noronha Silva.

Removed the webkit prefix for document visibility properties.

* UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
(testWebViewPageVisibility):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (154817 => 154818)


--- trunk/Source/WebKit2/ChangeLog	2013-08-29 17:03:32 UTC (rev 154817)
+++ trunk/Source/WebKit2/ChangeLog	2013-08-29 17:22:16 UTC (rev 154818)
@@ -1,3 +1,15 @@
+2013-08-29  Brian Holt  <[email protected]>
+
+        [GTK] [WK2] TestWebKitWebView page-visibility fails
+        https://bugs.webkit.org/show_bug.cgi?id=120406
+
+        Reviewed by Gustavo Noronha Silva.
+
+        Removed the webkit prefix for document visibility properties.
+
+        * UIProcess/API/gtk/tests/TestWebKitWebView.cpp:
+        (testWebViewPageVisibility):
+
 2013-08-28  Chris Curtis  <[email protected]>
 
         https://bugs.webkit.org/show_bug.cgi?id=119548

Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp (154817 => 154818)


--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp	2013-08-29 17:03:32 UTC (rev 154817)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp	2013-08-29 17:22:16 UTC (rev 154818)
@@ -1093,9 +1093,9 @@
     test->loadHtml("<html><title></title>"
         "<body><p>Test Web Page Visibility</p>"
         "<script>"
-        "document.addEventListener(\"webkitvisibilitychange\", onVisibilityChange, false);"
+        "document.addEventListener(\"visibilitychange\", onVisibilityChange, false);"
         "function onVisibilityChange() {"
-        "    document.title = document.webkitVisibilityState;"
+        "    document.title = document.visibilityState;"
         "}"
         "</script>"
         "</body></html>",
@@ -1105,13 +1105,13 @@
     test->waitUntilLoadFinished();
 
     GOwnPtr<GError> error;
-    WebKitJavascriptResult* _javascript_Result = test->runJavaScriptAndWaitUntilFinished("document.webkitVisibilityState;", &error.outPtr());
+    WebKitJavascriptResult* _javascript_Result = test->runJavaScriptAndWaitUntilFinished("document.visibilityState;", &error.outPtr());
     g_assert(_javascript_Result);
     g_assert(!error.get());
     GOwnPtr<char> valueString(WebViewTest::_javascript_ResultToCString(_javascript_Result));
     g_assert_cmpstr(valueString.get(), ==, "hidden");
 
-    _javascript_Result = test->runJavaScriptAndWaitUntilFinished("document.webkitHidden;", &error.outPtr());
+    _javascript_Result = test->runJavaScriptAndWaitUntilFinished("document.hidden;", &error.outPtr());
     g_assert(_javascript_Result);
     g_assert(!error.get());
     g_assert(WebViewTest::_javascript_ResultToBoolean(_javascript_Result));
@@ -1120,13 +1120,13 @@
     test->showInWindow();
     test->waitUntilTitleChanged();
 
-    _javascript_Result = test->runJavaScriptAndWaitUntilFinished("document.webkitVisibilityState;", &error.outPtr());
+    _javascript_Result = test->runJavaScriptAndWaitUntilFinished("document.visibilityState;", &error.outPtr());
     g_assert(_javascript_Result);
     g_assert(!error.get());
     valueString.set(WebViewTest::_javascript_ResultToCString(_javascript_Result));
     g_assert_cmpstr(valueString.get(), ==, "visible");
 
-    _javascript_Result = test->runJavaScriptAndWaitUntilFinished("document.webkitHidden;", &error.outPtr());
+    _javascript_Result = test->runJavaScriptAndWaitUntilFinished("document.hidden;", &error.outPtr());
     g_assert(_javascript_Result);
     g_assert(!error.get());
     g_assert(!WebViewTest::_javascript_ResultToBoolean(_javascript_Result));
@@ -1135,13 +1135,13 @@
     gtk_widget_hide(GTK_WIDGET(test->m_webView));
     test->waitUntilTitleChanged();
 
-    _javascript_Result = test->runJavaScriptAndWaitUntilFinished("document.webkitVisibilityState;", &error.outPtr());
+    _javascript_Result = test->runJavaScriptAndWaitUntilFinished("document.visibilityState;", &error.outPtr());
     g_assert(_javascript_Result);
     g_assert(!error.get());
     valueString.set(WebViewTest::_javascript_ResultToCString(_javascript_Result));
     g_assert_cmpstr(valueString.get(), ==, "hidden");
 
-    _javascript_Result = test->runJavaScriptAndWaitUntilFinished("document.webkitHidden;", &error.outPtr());
+    _javascript_Result = test->runJavaScriptAndWaitUntilFinished("document.hidden;", &error.outPtr());
     g_assert(_javascript_Result);
     g_assert(!error.get());
     g_assert(WebViewTest::_javascript_ResultToBoolean(_javascript_Result));

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to