Title: [154589] trunk/Source/WebKit2
Revision
154589
Author
[email protected]
Date
2013-08-26 00:47:55 -0700 (Mon, 26 Aug 2013)

Log Message

[GTK] webkitCredentialGetCredential returns a temporary in g_return_val_if_fail
https://bugs.webkit.org/show_bug.cgi?id=120287

Reviewed by Philippe Normand.

* UIProcess/API/gtk/WebKitCredential.cpp:
(webkitCredentialGetCredential): Use ASSERT() instead of
g_return_val_if_fail() since this is a private function.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (154588 => 154589)


--- trunk/Source/WebKit2/ChangeLog	2013-08-26 07:45:16 UTC (rev 154588)
+++ trunk/Source/WebKit2/ChangeLog	2013-08-26 07:47:55 UTC (rev 154589)
@@ -1,3 +1,14 @@
+2013-08-26  Carlos Garcia Campos  <[email protected]>
+
+        [GTK] webkitCredentialGetCredential returns a temporary in g_return_val_if_fail
+        https://bugs.webkit.org/show_bug.cgi?id=120287
+
+        Reviewed by Philippe Normand.
+
+        * UIProcess/API/gtk/WebKitCredential.cpp:
+        (webkitCredentialGetCredential): Use ASSERT() instead of
+        g_return_val_if_fail() since this is a private function.
+
 2013-08-25  Zan Dobersek  <[email protected]>
 
         Unreviewed GTK build fix after r154565.

Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitCredential.cpp (154588 => 154589)


--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitCredential.cpp	2013-08-26 07:45:16 UTC (rev 154588)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitCredential.cpp	2013-08-26 07:47:55 UTC (rev 154589)
@@ -52,8 +52,7 @@
 
 const WebCore::Credential& webkitCredentialGetCredential(WebKitCredential* credential)
 {
-    g_return_val_if_fail(credential, WebCore::Credential());
-
+    ASSERT(credential);
     return credential->credential;
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to