Title: [154301] trunk
- Revision
- 154301
- Author
- [email protected]
- Date
- 2013-08-19 14:54:29 -0700 (Mon, 19 Aug 2013)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=119915
REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
Reviewed by Darin Adler.
Tools:
The issue was that we ended up having no CFNetwork cache in the testing session due
to an incorrect cache model. There is a number of things not implemented when it
comes to dynamically changing cache model as attempted by WebKitTestRunner, but
the easiest way to get this going is to initialize it to correct value upfront.
* WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
LayoutTests:
* platform/mac-wk2/TestExpectations: Unskipping the failing test.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (154300 => 154301)
--- trunk/LayoutTests/ChangeLog 2013-08-19 21:44:17 UTC (rev 154300)
+++ trunk/LayoutTests/ChangeLog 2013-08-19 21:54:29 UTC (rev 154301)
@@ -1,3 +1,12 @@
+2013-08-19 Alexey Proskuryakov <[email protected]>
+
+ https://bugs.webkit.org/show_bug.cgi?id=119915
+ REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
+
+ Reviewed by Darin Adler.
+
+ * platform/mac-wk2/TestExpectations: Unskipping the failing test.
+
2013-08-19 Gavin Barraclough <[email protected]>
https://bugs.webkit.org/show_bug.cgi?id=119995
Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (154300 => 154301)
--- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2013-08-19 21:44:17 UTC (rev 154300)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2013-08-19 21:54:29 UTC (rev 154301)
@@ -335,9 +335,6 @@
# Only failing on WK1
webkit.org/b/104104 fast/overflow/scrollbar-click-retains-focus.html [ Pass ]
-webkit.org/b/119915 [ Release ] http/tests/navigation/post-frames-goback1.html [ Failure ]
-webkit.org/b/119915 [ Debug ] http/tests/navigation/post-frames-goback1.html [ Crash ]
-
### END OF (1) Classified failures with bug reports
########################################
Modified: trunk/Tools/ChangeLog (154300 => 154301)
--- trunk/Tools/ChangeLog 2013-08-19 21:44:17 UTC (rev 154300)
+++ trunk/Tools/ChangeLog 2013-08-19 21:54:29 UTC (rev 154301)
@@ -1,3 +1,17 @@
+2013-08-19 Alexey Proskuryakov <[email protected]>
+
+ https://bugs.webkit.org/show_bug.cgi?id=119915
+ REGRESSION(r154144): ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get()
+
+ Reviewed by Darin Adler.
+
+ The issue was that we ended up having no CFNetwork cache in the testing session due
+ to an incorrect cache model. There is a number of things not implemented when it
+ comes to dynamically changing cache model as attempted by WebKitTestRunner, but
+ the easiest way to get this going is to initialize it to correct value upfront.
+
+ * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
+
2013-08-19 Allan Sandfeld Jensen <[email protected]>
REGRESSION(r154275): webkitpy tests failing
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (154300 => 154301)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2013-08-19 21:44:17 UTC (rev 154300)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2013-08-19 21:54:29 UTC (rev 154301)
@@ -376,6 +376,7 @@
}
WKContextUseTestingNetworkSession(m_context.get());
+ WKContextSetCacheModel(m_context.get(), kWKCacheModelDocumentBrowser);
platformInitializeContext();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
