Diff
Modified: trunk/Source/WebCore/ChangeLog (152703 => 152704)
--- trunk/Source/WebCore/ChangeLog 2013-07-16 04:56:29 UTC (rev 152703)
+++ trunk/Source/WebCore/ChangeLog 2013-07-16 05:01:15 UTC (rev 152704)
@@ -1,3 +1,26 @@
+2013-07-15 Kangil Han <kangil....@samsung.com>
+
+ Introduce toHTMLIFrameElement
+ https://bugs.webkit.org/show_bug.cgi?id=118672
+
+ Reviewed by Ryosuke Niwa.
+
+ To avoid direct use of static_cast, this patch introduces toHTMLIFrameElement for code cleanup.
+
+ * bindings/js/JSHTMLDocumentCustom.cpp:
+ (WebCore::JSHTMLDocument::nameGetter):
+ * css/StyleResolver.cpp:
+ (WebCore::StyleResolver::adjustRenderStyle):
+ * dom/Document.cpp:
+ (WebCore::Document::seamlessParentIFrame):
+ * html/HTMLIFrameElement.h:
+ (WebCore::toHTMLIFrameElement):
+ * rendering/RenderEmbeddedObject.cpp:
+ (WebCore::RenderEmbeddedObject::viewCleared):
+ * rendering/RenderIFrame.cpp:
+ (WebCore::RenderIFrame::isSeamless):
+ (WebCore::RenderIFrame::flattenFrame):
+
2013-07-15 Chris Rogers <crog...@google.com>
Add support for WaveShaperNode.oversample
Modified: trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp (152703 => 152704)
--- trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp 2013-07-16 04:56:29 UTC (rev 152703)
+++ trunk/Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp 2013-07-16 05:01:15 UTC (rev 152704)
@@ -75,7 +75,7 @@
Node* node = document->documentNamedItemMap().getElementByDocumentNamedItem(atomicPropertyName, document);
Frame* frame;
- if (node->hasTagName(iframeTag) && (frame = static_cast<HTMLIFrameElement*>(node)->contentFrame()))
+ if (node->hasTagName(iframeTag) && (frame = toHTMLIFrameElement(node)->contentFrame()))
return toJS(exec, frame);
return toJS(exec, thisObj->globalObject(), node);
Modified: trunk/Source/WebCore/css/StyleResolver.cpp (152703 => 152704)
--- trunk/Source/WebCore/css/StyleResolver.cpp 2013-07-16 04:56:29 UTC (rev 152703)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2013-07-16 05:01:15 UTC (rev 152704)
@@ -1568,7 +1568,7 @@
style->setTransformStyle3D(TransformStyle3DFlat);
// Seamless iframes behave like blocks. Map their display to inline-block when marked inline.
- if (e && e->hasTagName(iframeTag) && style->display() == INLINE && static_cast<HTMLIFrameElement*>(e)->shouldDisplaySeamlessly())
+ if (e && e->hasTagName(iframeTag) && style->display() == INLINE && toHTMLIFrameElement(e)->shouldDisplaySeamlessly())
style->setDisplay(INLINE_BLOCK);
#if ENABLE(SVG)
Modified: trunk/Source/WebCore/dom/Document.cpp (152703 => 152704)
--- trunk/Source/WebCore/dom/Document.cpp 2013-07-16 04:56:29 UTC (rev 152703)
+++ trunk/Source/WebCore/dom/Document.cpp 2013-07-16 05:01:15 UTC (rev 152704)
@@ -5637,9 +5637,7 @@
if (!shouldDisplaySeamlesslyWithParent())
return 0;
- HTMLFrameOwnerElement* ownerElement = this->ownerElement();
- ASSERT(ownerElement->hasTagName(iframeTag));
- return static_cast<HTMLIFrameElement*>(ownerElement);
+ return toHTMLIFrameElement(ownerElement());
}
bool Document::shouldDisplaySeamlesslyWithParent() const
Modified: trunk/Source/WebCore/html/HTMLIFrameElement.h (152703 => 152704)
--- trunk/Source/WebCore/html/HTMLIFrameElement.h 2013-07-16 04:56:29 UTC (rev 152703)
+++ trunk/Source/WebCore/html/HTMLIFrameElement.h 2013-07-16 05:01:15 UTC (rev 152704)
@@ -52,6 +52,12 @@
#endif
};
+inline HTMLIFrameElement* toHTMLIFrameElement(Node* node)
+{
+ ASSERT_WITH_SECURITY_IMPLICATION(!node || node->hasTagName(HTMLNames::iframeTag));
+ return static_cast<HTMLIFrameElement*>(node);
+}
+
} // namespace WebCore
#endif // HTMLIFrameElement_h
Modified: trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp (152703 => 152704)
--- trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp 2013-07-16 04:56:29 UTC (rev 152703)
+++ trunk/Source/WebCore/rendering/RenderEmbeddedObject.cpp 2013-07-16 05:01:15 UTC (rev 152704)
@@ -425,7 +425,7 @@
int marginWidth = -1;
int marginHeight = -1;
if (node()->hasTagName(iframeTag)) {
- HTMLIFrameElement* frame = static_cast<HTMLIFrameElement*>(node());
+ HTMLIFrameElement* frame = toHTMLIFrameElement(node());
marginWidth = frame->marginWidth();
marginHeight = frame->marginHeight();
}
Modified: trunk/Source/WebCore/rendering/RenderIFrame.cpp (152703 => 152704)
--- trunk/Source/WebCore/rendering/RenderIFrame.cpp 2013-07-16 04:56:29 UTC (rev 152703)
+++ trunk/Source/WebCore/rendering/RenderIFrame.cpp 2013-07-16 05:01:15 UTC (rev 152704)
@@ -81,7 +81,7 @@
bool RenderIFrame::isSeamless() const
{
- return node() && node()->hasTagName(iframeTag) && static_cast<HTMLIFrameElement*>(node())->shouldDisplaySeamlessly();
+ return node() && node()->hasTagName(iframeTag) && toHTMLIFrameElement(node())->shouldDisplaySeamlessly();
}
bool RenderIFrame::requiresLayer() const
@@ -102,7 +102,7 @@
if (!node() || !node()->hasTagName(iframeTag))
return false;
- HTMLIFrameElement* element = static_cast<HTMLIFrameElement*>(node());
+ HTMLIFrameElement* element = toHTMLIFrameElement(node());
Frame* frame = element->document()->frame();
if (isSeamless())
Modified: trunk/Source/WebKit/win/ChangeLog (152703 => 152704)
--- trunk/Source/WebKit/win/ChangeLog 2013-07-16 04:56:29 UTC (rev 152703)
+++ trunk/Source/WebKit/win/ChangeLog 2013-07-16 05:01:15 UTC (rev 152704)
@@ -1,3 +1,15 @@
+2013-07-15 Kangil Han <kangil....@samsung.com>
+
+ Introduce toHTMLIFrameElement
+ https://bugs.webkit.org/show_bug.cgi?id=118672
+
+ Reviewed by Ryosuke Niwa.
+
+ To avoid direct use of static_cast, this patch introduces toHTMLIFrameElement for code cleanup.
+
+ * DOMHTMLClasses.cpp:
+ (DOMHTMLIFrameElement::contentFrame):
+
2013-07-09 Jer Noble <jer.no...@apple.com>
Reviewed by Simon Fraser.
Modified: trunk/Source/WebKit/win/DOMHTMLClasses.cpp (152703 => 152704)
--- trunk/Source/WebKit/win/DOMHTMLClasses.cpp 2013-07-16 04:56:29 UTC (rev 152703)
+++ trunk/Source/WebKit/win/DOMHTMLClasses.cpp 2013-07-16 05:01:15 UTC (rev 152704)
@@ -1610,8 +1610,8 @@
if (!result)
return E_POINTER;
*result = 0;
- ASSERT(m_element && m_element->hasTagName(iframeTag));
- HTMLIFrameElement* iFrameElement = static_cast<HTMLIFrameElement*>(m_element);
+ ASSERT(m_element);
+ HTMLIFrameElement* iFrameElement = toHTMLIFrameElement(m_element);
COMPtr<IWebFrame> webFrame = kit(iFrameElement->contentFrame());
if (!webFrame)
return E_FAIL;
Modified: trunk/Source/WebKit2/ChangeLog (152703 => 152704)
--- trunk/Source/WebKit2/ChangeLog 2013-07-16 04:56:29 UTC (rev 152703)
+++ trunk/Source/WebKit2/ChangeLog 2013-07-16 05:01:15 UTC (rev 152704)
@@ -1,3 +1,15 @@
+2013-07-15 Kangil Han <kangil....@samsung.com>
+
+ Introduce toHTMLIFrameElement
+ https://bugs.webkit.org/show_bug.cgi?id=118672
+
+ Reviewed by Ryosuke Niwa.
+
+ To avoid direct use of static_cast, this patch introduces toHTMLIFrameElement for code cleanup.
+
+ * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
+ (WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):
+
2013-07-15 Tim Horton <timothy_hor...@apple.com>
Update blocked/missing plug-in UI
Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp (152703 => 152704)
--- trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp 2013-07-16 04:56:29 UTC (rev 152703)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp 2013-07-16 05:01:15 UTC (rev 152704)
@@ -257,7 +257,7 @@
if (!m_node->hasTagName(iframeTag))
return 0;
- Frame* frame = static_cast<HTMLIFrameElement*>(m_node.get())->contentFrame();
+ Frame* frame = toHTMLIFrameElement(m_node.get())->contentFrame();
if (!frame)
return 0;
