Title: [152095] trunk
Revision
152095
Author
commit-qu...@webkit.org
Date
2013-06-27 06:48:36 -0700 (Thu, 27 Jun 2013)

Log Message

Fixing some compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=117791

Patch by Xabier Rodriguez Calvar <calva...@igalia.com> on 2013-06-27
Reviewed by Martin Robinson.

Source/WebCore:

No new tests needed.

* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetTextForOffset): Fixed warning about
uninitialized variable.

Source/WebKit2:

* UIProcess/API/gtk/tests/WebExtensionTest.cpp: Properly
initialized GDBusInterfaceVTable.
* WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkitWebPageCreate): Added missing fields to the
WKBundlePageLoaderClient.

Tools:

* GNUmakefile.am: Silenced format warning.
* TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
(TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
Solved warning about uninitialized variable.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (152094 => 152095)


--- trunk/Source/WebCore/ChangeLog	2013-06-27 13:31:31 UTC (rev 152094)
+++ trunk/Source/WebCore/ChangeLog	2013-06-27 13:48:36 UTC (rev 152095)
@@ -1,3 +1,16 @@
+2013-06-27  Xabier Rodriguez Calvar  <calva...@igalia.com>
+
+        Fixing some compiler warnings
+        https://bugs.webkit.org/show_bug.cgi?id=117791
+
+        Reviewed by Martin Robinson.
+
+        No new tests needed.
+
+        * accessibility/atk/WebKitAccessibleInterfaceText.cpp:
+        (webkitAccessibleTextGetTextForOffset): Fixed warning about
+        uninitialized variable.
+
 2013-06-27  Iago Toral Quiroga  <ito...@igalia.com>
 
         Use consistent file names for WidgetBackingStoreGtkX11 class

Modified: trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp (152094 => 152095)


--- trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp	2013-06-27 13:31:31 UTC (rev 152094)
+++ trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceText.cpp	2013-06-27 13:48:36 UTC (rev 152095)
@@ -619,14 +619,13 @@
 #if PLATFORM(GTK)
     // FIXME: Get rid of the code below once every single get_text_*_offset
     // function has been properly implemented without using Pango/Cairo.
-    GailOffsetType offsetType;
+    GailOffsetType offsetType = GAIL_AT_OFFSET;
     switch (textPosition) {
     case GetTextPositionBefore:
         offsetType = GAIL_BEFORE_OFFSET;
         break;
 
     case GetTextPositionAt:
-        offsetType = GAIL_AT_OFFSET;
         break;
 
     case GetTextPositionAfter:

Modified: trunk/Source/WebKit2/ChangeLog (152094 => 152095)


--- trunk/Source/WebKit2/ChangeLog	2013-06-27 13:31:31 UTC (rev 152094)
+++ trunk/Source/WebKit2/ChangeLog	2013-06-27 13:48:36 UTC (rev 152095)
@@ -1,3 +1,16 @@
+2013-06-27  Xabier Rodriguez Calvar  <calva...@igalia.com>
+
+        Fixing some compiler warnings
+        https://bugs.webkit.org/show_bug.cgi?id=117791
+
+        Reviewed by Martin Robinson.
+
+        * UIProcess/API/gtk/tests/WebExtensionTest.cpp: Properly
+        initialized GDBusInterfaceVTable.
+        * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
+        (webkitWebPageCreate): Added missing fields to the
+        WKBundlePageLoaderClient.
+
 2013-06-27  Iago Toral Quiroga  <ito...@igalia.com>
 
         Use consistent file names for WidgetBackingStoreGtkX11 class

Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp (152094 => 152095)


--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp	2013-06-27 13:31:31 UTC (rev 152094)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp	2013-06-27 13:48:36 UTC (rev 152095)
@@ -121,7 +121,7 @@
 }
 
 static const GDBusInterfaceVTable interfaceVirtualTable = {
-    methodCallCallback, 0, 0
+    methodCallCallback, 0, 0, { 0, }
 };
 
 static void busAcquiredCallback(GDBusConnection* connection, const char* name, gpointer userData)

Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp (152094 => 152095)


--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp	2013-06-27 13:31:31 UTC (rev 152094)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp	2013-06-27 13:48:36 UTC (rev 152095)
@@ -311,6 +311,8 @@
         0, // registerIntentServiceForFrame_unavailable
         0, // didLayout
         0, // featuresUsedInPage
+        0, // willLoadURLRequest;
+        0, // willLoadDataRequest;
     };
     WKBundlePageSetPageLoaderClient(toAPI(webPage), &loaderClient);
 

Modified: trunk/Tools/ChangeLog (152094 => 152095)


--- trunk/Tools/ChangeLog	2013-06-27 13:31:31 UTC (rev 152094)
+++ trunk/Tools/ChangeLog	2013-06-27 13:48:36 UTC (rev 152095)
@@ -1,3 +1,15 @@
+2013-06-27  Xabier Rodriguez Calvar  <calva...@igalia.com>
+
+        Fixing some compiler warnings
+        https://bugs.webkit.org/show_bug.cgi?id=117791
+
+        Reviewed by Martin Robinson.
+
+        * GNUmakefile.am: Silenced format warning.
+        * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
+        (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
+        Solved warning about uninitialized variable.
+
 2013-06-27  Christophe Dumez  <ch.du...@sisa.samsung.com>
 
         Fix bindings tests after r152080

Modified: trunk/Tools/GNUmakefile.am (152094 => 152095)


--- trunk/Tools/GNUmakefile.am	2013-06-27 13:31:31 UTC (rev 152094)
+++ trunk/Tools/GNUmakefile.am	2013-06-27 13:48:36 UTC (rev 152095)
@@ -254,7 +254,8 @@
 	-I$(srcdir)/Tools/DumpRenderTree/TestNetscapePlugIn \
 	-I$(srcdir)/Tools/DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders \
 	$(global_cppflags) \
-	$(_javascript_core_cppflags)
+	$(_javascript_core_cppflags) \
+	-Wno-missing-format-attribute
 
 # For the Gtk port we want to use XP_UNIX both on X11 and Mac
 if !TARGET_WIN32

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp (152094 => 152095)


--- trunk/Tools/TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp	2013-06-27 13:31:31 UTC (rev 152094)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp	2013-06-27 13:48:36 UTC (rev 152095)
@@ -204,7 +204,7 @@
 {
     WKBundleDOMWindowExtensionRef extension = WKBundleDOMWindowExtensionCreate(frame, world);
 
-    int index;
+    int index = 0;
     bool standard;
     standard = world == WKBundleScriptWorldNormalWorld();
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to