Title: [150654] trunk/LayoutTests
Revision
150654
Author
[email protected]
Date
2013-05-24 12:43:41 -0700 (Fri, 24 May 2013)

Log Message

[WK2] Spelling tests gardening
https://bugs.webkit.org/show_bug.cgi?id=116718

Unreviewed gardening.

The most spelling tests are skipped for wk2 platforms and they have deprecated comments.
Move the tests from global wk2/TestExpectations to the ports' TestExpectations as
the core spellchecking implementation is delivered for wk2.
This change will allow to run spelling tests easier and using [ Pass ] keyword
in TestExpectations won't be needed.


* platform/efl-wk2/TestExpectations:
* platform/gtk-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/qt-5.0-wk2/TestExpectations:
* platform/wk2/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (150653 => 150654)


--- trunk/LayoutTests/ChangeLog	2013-05-24 19:41:37 UTC (rev 150653)
+++ trunk/LayoutTests/ChangeLog	2013-05-24 19:43:41 UTC (rev 150654)
@@ -1,3 +1,22 @@
+2013-05-24  Grzegorz Czajkowski  <[email protected]>
+
+        [WK2] Spelling tests gardening
+        https://bugs.webkit.org/show_bug.cgi?id=116718
+
+        Unreviewed gardening.
+
+        The most spelling tests are skipped for wk2 platforms and they have deprecated comments.
+        Move the tests from global wk2/TestExpectations to the ports' TestExpectations as
+        the core spellchecking implementation is delivered for wk2.
+        This change will allow to run spelling tests easier and using [ Pass ] keyword
+        in TestExpectations won't be needed.
+
+        * platform/efl-wk2/TestExpectations:
+        * platform/gtk-wk2/TestExpectations:
+        * platform/mac-wk2/TestExpectations:
+        * platform/qt-5.0-wk2/TestExpectations:
+        * platform/wk2/TestExpectations:
+
 2013-05-24  Anders Carlsson  <[email protected]>
 
         Remove PagePopup code

Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (150653 => 150654)


--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2013-05-24 19:41:37 UTC (rev 150653)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2013-05-24 19:43:41 UTC (rev 150654)
@@ -33,19 +33,6 @@
 #////////////////////////////////////////////////////////////////////////////////////////
 # PASSING TESTS
 #////////////////////////////////////////////////////////////////////////////////////////
-editing/spelling/design-mode-spellcheck-off.html [ Pass ]
-editing/spelling/spellcheck-api-crash.html [ Pass ]
-editing/spelling/spellcheck-attribute.html [ Pass ]
-editing/spelling/spellcheck-input-search-crash.html [ Pass ]
-editing/spelling/spelling-attribute-at-child.html [ Pass ]
-editing/spelling/spelling-attribute-change.html [ Pass ]
-editing/spelling/spelling-backspace-between-lines.html [ Pass ]
-editing/spelling/spelling-double-clicked-word.html [ Pass ]
-editing/spelling/spelling-exactly-selected-word.html [ Pass ]
-editing/spelling/spelling-hasspellingmarker.html [ Pass ]
-editing/spelling/spelling-linebreak.html [ Pass ]
-editing/spelling/spelling-with-punctuation-selection.html [ Pass ]
-editing/spelling/spelling-with-whitespace-selection.html [ Pass ]
 
 #////////////////////////////////////////////////////////////////////////////////////////
 # TESTS EXPECTED TO FAIL
@@ -298,6 +285,7 @@
 Bug(EFL) fast/events/touch/basic-single-touch-events.html [ Failure ]
 
 # Needs grammar checking
+Bug(EFL) editing/spelling/grammar.html [ Failure ]
 Bug(EFL) editing/spelling/grammar-edit-word.html [ Failure ]
 Bug(EFL) editing/spelling/grammar-markers.html [ Failure ]
 Bug(EFL) editing/spelling/grammar-markers-hidpi.html [ Failure ]
@@ -309,7 +297,6 @@
 
 # WK2's contextClick() returns array of objects instead of strings.
 editing/spelling/spelling-exactly-selected-multiple-words.html [ Failure ]
-editing/spelling/spelling-exactly-selected-word.html [ Failure ]
 editing/spelling/spelling-multiword-selection.html [ Failure ]
 editing/spelling/spelling-should-select-multiple-words.html [ Failure ]
 editing/spelling/spelling-subword-selection.html [ Failure ]

Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (150653 => 150654)


--- trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2013-05-24 19:41:37 UTC (rev 150653)
+++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2013-05-24 19:43:41 UTC (rev 150654)
@@ -190,6 +190,24 @@
 Bug(GTK) editing/spelling/spellcheck-sequencenum.html [ Skip ]
 Bug(GTK) editing/spelling/spelling-marker-description.html [ Skip ]
 
+# Spellcheck tests don't seem to work.
+Bug(GTK) editing/spelling/spelling-backspace-between-lines.html [ Skip ]
+Bug(GTK) editing/spelling/design-mode-spellcheck-off.html [ Skip ]
+Bug(GTK) editing/spelling/spellcheck-attribute.html [ Skip ]
+Bug(GTK) editing/spelling/spelling-attribute-at-child.html [ Skip ]
+Bug(GTK) editing/spelling/spelling-attribute-change.html [ Skip ]
+Bug(GTK) editing/spelling/spelling-double-clicked-word.html [ Skip ]
+Bug(GTK) editing/spelling/spelling-exactly-selected-multiple-words.html [ Skip ]
+Bug(GTK) editing/spelling/spelling-exactly-selected-word.html [ Skip ]
+Bug(GTK) editing/spelling/spelling-hasspellingmarker.html [ Skip ]
+Bug(GTK) editing/spelling/spelling-linebreak.html [ Skip ]
+Bug(GTK) editing/spelling/spelling-multiword-selection.html [ Skip ]
+Bug(GTK) editing/spelling/spelling-should-select-multiple-words.html [ Skip ]
+Bug(GTK) editing/spelling/spelling-subword-selection.html [ Skip ]
+Bug(GTK) editing/spelling/spelling-with-punctuation-selection.html [ Skip ]
+Bug(GTK) editing/spelling/spelling-with-whitespace-selection.html [ Skip ]
+Bug(GTK) editing/spelling/grammar.html [ Skip ]
+
 # GTK port doesn't support webarchives.
 webarchive [ Skip ]
 svg/webarchive [ Skip ]

Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (150653 => 150654)


--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2013-05-24 19:41:37 UTC (rev 150653)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2013-05-24 19:43:41 UTC (rev 150654)
@@ -116,6 +116,23 @@
 # [WK2] [Mac] Spellcheck tests don't seem to work
 webkit.org/b/105616 editing/inserting/inserting-slash-inside-url-with-smart-link.html
 webkit.org/b/105616 editing/spelling/spelling-changed-text.html
+webkit.org/b/105616 editing/spelling/spelling-backspace-between-lines.html
+webkit.org/b/105616 editing/spelling/design-mode-spellcheck-off.html
+webkit.org/b/105616 editing/spelling/spellcheck-attribute.html
+webkit.org/b/105616 editing/spelling/spelling-attribute-at-child.html
+webkit.org/b/105616 editing/spelling/spelling-attribute-change.html
+webkit.org/b/105616 editing/spelling/spelling-double-clicked-word.html
+webkit.org/b/105616 editing/spelling/spelling-exactly-selected-multiple-words.html
+webkit.org/b/105616 editing/spelling/spelling-exactly-selected-word.html
+webkit.org/b/105616 editing/spelling/spelling-hasspellingmarker.html
+webkit.org/b/105616 editing/spelling/spelling-linebreak.html
+webkit.org/b/105616 editing/spelling/spelling-multiword-selection.html
+webkit.org/b/105616 editing/spelling/spelling-should-select-multiple-words.html
+webkit.org/b/105616 editing/spelling/spelling-subword-selection.html
+webkit.org/b/105616 editing/spelling/spelling-with-punctuation-selection.html
+webkit.org/b/105616 editing/spelling/spelling-with-whitespace-selection.html
+webkit.org/b/105616 editing/spelling/spellcheck-input-search-crash.html
+webkit.org/b/105616 editing/spelling/grammar.html
 webkit.org/b/105616 platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html [ Failure ]
 webkit.org/b/105616 platform/mac/editing/spelling/click-autocorrected-word.html
 webkit.org/b/105616 platform/mac/editing/spelling/move-cursor-to-beginning-of-autocorrected-word.html
@@ -123,6 +140,11 @@
 webkit.org/b/105616 platform/mac/editing/spelling/delete-into-autocorrected-word.html
 webkit.org/b/105616 platform/mac/editing/spelling/forward-delete-into-autocorrected-word.html
 webkit.org/b/105616 platform/mac/editing/spelling/autocorrection-with-multi-line-text.html
+webkit.org/b/105616 platform/mac/editing/spelling/delete-into-misspelled-word.html
+webkit.org/b/105616 platform/mac/editing/spelling/editing-multiple-words-with-markers.html
+webkit.org/b/105616 platform/mac/editing/spelling/editing-word-with-marker-1.html
+webkit.org/b/105616 platform/mac/editing/spelling/editing-word-with-marker-2.html
+webkit.org/b/105616 platform/mac/editing/spelling/move-cursor-around-misspelled-word.html
 
 # [WK2] [Mac] Support drag in mouse events for WebKit2 EventSender
 # <https://bugs.webkit.org/show_bug.cgi?id=68552>

Modified: trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations (150653 => 150654)


--- trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations	2013-05-24 19:41:37 UTC (rev 150653)
+++ trunk/LayoutTests/platform/qt-5.0-wk2/TestExpectations	2013-05-24 19:43:41 UTC (rev 150654)
@@ -768,6 +768,25 @@
 editing/spelling/spellcheck-sequencenum.html
 editing/spelling/spelling-marker-description.html
 
+# Spellcheck tests don't seem to work.
+editing/spelling/spelling-backspace-between-lines.html
+editing/spelling/design-mode-spellcheck-off.html
+editing/spelling/spellcheck-attribute.html
+editing/spelling/spelling-attribute-at-child.html
+editing/spelling/spelling-attribute-change.html
+editing/spelling/spelling-double-clicked-word.html
+editing/spelling/spelling-exactly-selected-multiple-words.html
+editing/spelling/spelling-exactly-selected-word.html
+editing/spelling/spelling-hasspellingmarker.html
+editing/spelling/spelling-linebreak.html
+editing/spelling/spelling-multiword-selection.html
+editing/spelling/spelling-should-select-multiple-words.html
+editing/spelling/spelling-subword-selection.html
+editing/spelling/spelling-with-punctuation-selection.html
+editing/spelling/spelling-with-whitespace-selection.html
+editing/spelling/spellcheck-input-search-crash.html
+editing/spelling/grammar.html
+
 # [Qt][WK2] REGRESSION(r148594): fast/events/mouseout-on-window.html fails with enabled sub-pixel layout
 webkit.org/b/42194 fast/events/mouseout-on-window.html [ Skip ]
 

Modified: trunk/LayoutTests/platform/wk2/TestExpectations (150653 => 150654)


--- trunk/LayoutTests/platform/wk2/TestExpectations	2013-05-24 19:41:37 UTC (rev 150653)
+++ trunk/LayoutTests/platform/wk2/TestExpectations	2013-05-24 19:43:41 UTC (rev 150654)
@@ -114,7 +114,6 @@
 editing/input/setting-input-value-cancel-ime-composition.html
 svg/text/caret-in-svg-text.xhtml
 editing/inserting/caret-position.html
-editing/spelling/spelling-backspace-between-lines.html
 editing/selection/5825350-1.html
 editing/selection/5825350-2.html
 editing/selection/move-left-right.html
@@ -308,30 +307,6 @@
 # WebKitTestRunner needs layoutTestController.pageProperty
 printing/page-rule-selection.html
 
-# WebKitTestRunner needs internals.hasSpellingMarker
-editing/spelling/design-mode-spellcheck-off.html
-editing/spelling/spellcheck-attribute.html
-editing/spelling/spelling-attribute-at-child.html
-editing/spelling/spelling-attribute-change.html
-editing/spelling/spelling-double-clicked-word.html
-editing/spelling/spelling-exactly-selected-multiple-words.html
-editing/spelling/spelling-exactly-selected-word.html
-editing/spelling/spelling-hasspellingmarker.html
-editing/spelling/spelling-linebreak.html
-editing/spelling/spelling-multiword-selection.html
-editing/spelling/spelling-should-select-multiple-words.html
-editing/spelling/spelling-subword-selection.html
-editing/spelling/spelling-with-punctuation-selection.html
-editing/spelling/spelling-with-whitespace-selection.html
-platform/mac/editing/spelling/delete-into-misspelled-word.html
-platform/mac/editing/spelling/editing-multiple-words-with-markers.html
-platform/mac/editing/spelling/editing-word-with-marker-1.html
-platform/mac/editing/spelling/editing-word-with-marker-2.html
-platform/mac/editing/spelling/move-cursor-around-misspelled-word.html
-
-# WebKitTestRunner needs layoutTestController.hasGrammarMarker
-editing/spelling/grammar.html
-
 # WebKitTestRunner needs layoutTestController.dumpUserGestureInFrameLoadCallbacks
 fast/frames/location-redirect-user-gesture.html
 fast/frames/meta-refresh-user-gesture.html
@@ -410,7 +385,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=86881
 editing/selection/context-menu-text-selection.html
 editing/selection/5354455-2.html
-editing/spelling/spellcheck-input-search-crash.html
 fast/events/context-nodrag.html
 
 # WKTR does not support overriding WebKitUsesPageCachePreferenceKey.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to