[webkit-changes] [150590] trunk

Thu, 23 May 2013 09:43:32 -0700

Title: [150590] trunk
Revision
150590
Author
[email protected]
Date
2013-05-23 09:45:10 -0700 (Thu, 23 May 2013)

Log Message

Unreviewed, rolling out r150586.
http://trac.webkit.org/changeset/150586
https://bugs.webkit.org/show_bug.cgi?id=116660

Those constructors should be exposed on the WorkerContext, not
the DOMWindow

Source/WebCore:

* fileapi/FileReaderSync.idl:
* workers/WorkerLocation.idl:

LayoutTests:

* fast/js/global-constructors-attributes-expected.txt:
* platform/efl/fast/js/constructor-length-expected.txt:
* platform/efl/fast/js/global-constructors-attributes-expected.txt:
* platform/gtk/fast/js/constructor-length-expected.txt:
* platform/gtk/fast/js/global-constructors-attributes-expected.txt:
* platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
* platform/mac/fast/js/constructor-length-expected.txt:
* platform/qt/fast/js/constructor-length-expected.txt:
* platform/qt/fast/js/global-constructors-attributes-expected.txt:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (150589 => 150590)


--- trunk/LayoutTests/ChangeLog	2013-05-23 16:13:35 UTC (rev 150589)
+++ trunk/LayoutTests/ChangeLog	2013-05-23 16:45:10 UTC (rev 150590)
@@ -1,3 +1,22 @@
+2013-05-23  Christophe Dumez  <[email protected]>
+
+        Unreviewed, rolling out r150586.
+        http://trac.webkit.org/changeset/150586
+        https://bugs.webkit.org/show_bug.cgi?id=116660
+
+        Those constructors should be exposed on the WorkerContext, not
+        the DOMWindow
+
+        * fast/js/global-constructors-attributes-expected.txt:
+        * platform/efl/fast/js/constructor-length-expected.txt:
+        * platform/efl/fast/js/global-constructors-attributes-expected.txt:
+        * platform/gtk/fast/js/constructor-length-expected.txt:
+        * platform/gtk/fast/js/global-constructors-attributes-expected.txt:
+        * platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
+        * platform/mac/fast/js/constructor-length-expected.txt:
+        * platform/qt/fast/js/constructor-length-expected.txt:
+        * platform/qt/fast/js/global-constructors-attributes-expected.txt:
+
 2013-05-23  Radu Stavila  <[email protected]>
 
         [CSS Regions][Mac] [WK2] Layout Test fast/regions/fixed-pos-elem-in-region.html is flaky on Debug builders

Modified: trunk/LayoutTests/fast/js/global-constructors-attributes-expected.txt (150589 => 150590)


--- trunk/LayoutTests/fast/js/global-constructors-attributes-expected.txt	2013-05-23 16:13:35 UTC (rev 150589)
+++ trunk/LayoutTests/fast/js/global-constructors-attributes-expected.txt	2013-05-23 16:45:10 UTC (rev 150590)
@@ -348,11 +348,6 @@
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').value is FileReaderSync
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').value is Float32Array
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('set') is false
@@ -1943,11 +1938,6 @@
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').value is WorkerLocation
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').value is XMLDocument
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/efl/fast/js/constructor-length-expected.txt (150589 => 150590)


--- trunk/LayoutTests/platform/efl/fast/js/constructor-length-expected.txt	2013-05-23 16:13:35 UTC (rev 150589)
+++ trunk/LayoutTests/platform/efl/fast/js/constructor-length-expected.txt	2013-05-23 16:45:10 UTC (rev 150590)
@@ -18,7 +18,7 @@
 PASS Float32Array.length is 1
 PASS Float64Array.length is 1
 PASS FileReader.length is 0
-PASS FileReaderSync.length is 0
+FAIL FileReaderSync.length should be 0. Threw exception ReferenceError: Can't find variable: FileReaderSync
 PASS HashChangeEvent.length is 1
 PASS Int16Array.length is 1
 PASS Int32Array.length is 1

Modified: trunk/LayoutTests/platform/efl/fast/js/global-constructors-attributes-expected.txt (150589 => 150590)


--- trunk/LayoutTests/platform/efl/fast/js/global-constructors-attributes-expected.txt	2013-05-23 16:13:35 UTC (rev 150589)
+++ trunk/LayoutTests/platform/efl/fast/js/global-constructors-attributes-expected.txt	2013-05-23 16:45:10 UTC (rev 150590)
@@ -348,11 +348,6 @@
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').value is FileReaderSync
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').value is Float32Array
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('set') is false
@@ -2023,11 +2018,6 @@
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').value is WorkerLocation
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').value is XMLDocument
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/gtk/fast/js/constructor-length-expected.txt (150589 => 150590)


--- trunk/LayoutTests/platform/gtk/fast/js/constructor-length-expected.txt	2013-05-23 16:13:35 UTC (rev 150589)
+++ trunk/LayoutTests/platform/gtk/fast/js/constructor-length-expected.txt	2013-05-23 16:45:10 UTC (rev 150590)
@@ -18,7 +18,7 @@
 PASS Float32Array.length is 1
 PASS Float64Array.length is 1
 PASS FileReader.length is 0
-PASS FileReaderSync.length is 0
+FAIL FileReaderSync.length should be 0. Threw exception ReferenceError: Can't find variable: FileReaderSync
 PASS HashChangeEvent.length is 1
 PASS Int16Array.length is 1
 PASS Int32Array.length is 1

Modified: trunk/LayoutTests/platform/gtk/fast/js/global-constructors-attributes-expected.txt (150589 => 150590)


--- trunk/LayoutTests/platform/gtk/fast/js/global-constructors-attributes-expected.txt	2013-05-23 16:13:35 UTC (rev 150589)
+++ trunk/LayoutTests/platform/gtk/fast/js/global-constructors-attributes-expected.txt	2013-05-23 16:45:10 UTC (rev 150590)
@@ -348,11 +348,6 @@
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').value is FileReaderSync
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').value is Float32Array
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('set') is false
@@ -2028,11 +2023,6 @@
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').value is WorkerLocation
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').value is XMLDocument
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/mac/fast/js/constructor-length-expected.txt (150589 => 150590)


--- trunk/LayoutTests/platform/mac/fast/js/constructor-length-expected.txt	2013-05-23 16:13:35 UTC (rev 150589)
+++ trunk/LayoutTests/platform/mac/fast/js/constructor-length-expected.txt	2013-05-23 16:45:10 UTC (rev 150590)
@@ -18,7 +18,7 @@
 PASS Float32Array.length is 1
 PASS Float64Array.length is 1
 PASS FileReader.length is 0
-PASS FileReaderSync.length is 0
+FAIL FileReaderSync.length should be 0. Threw exception ReferenceError: Can't find variable: FileReaderSync
 PASS HashChangeEvent.length is 1
 PASS Int16Array.length is 1
 PASS Int32Array.length is 1

Modified: trunk/LayoutTests/platform/mac-lion/fast/js/global-constructors-attributes-expected.txt (150589 => 150590)


--- trunk/LayoutTests/platform/mac-lion/fast/js/global-constructors-attributes-expected.txt	2013-05-23 16:13:35 UTC (rev 150589)
+++ trunk/LayoutTests/platform/mac-lion/fast/js/global-constructors-attributes-expected.txt	2013-05-23 16:45:10 UTC (rev 150590)
@@ -348,11 +348,6 @@
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').value is FileReaderSync
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').value is Float32Array
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('set') is false
@@ -1938,11 +1933,6 @@
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').value is WorkerLocation
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').value is XMLDocument
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('set') is false

Modified: trunk/LayoutTests/platform/qt/fast/js/constructor-length-expected.txt (150589 => 150590)


--- trunk/LayoutTests/platform/qt/fast/js/constructor-length-expected.txt	2013-05-23 16:13:35 UTC (rev 150589)
+++ trunk/LayoutTests/platform/qt/fast/js/constructor-length-expected.txt	2013-05-23 16:45:10 UTC (rev 150590)
@@ -18,7 +18,7 @@
 PASS Float32Array.length is 1
 PASS Float64Array.length is 1
 PASS FileReader.length is 0
-PASS FileReaderSync.length is 0
+FAIL FileReaderSync.length should be 0. Threw exception ReferenceError: Can't find variable: FileReaderSync
 PASS HashChangeEvent.length is 1
 PASS Int16Array.length is 1
 PASS Int32Array.length is 1

Modified: trunk/LayoutTests/platform/qt/fast/js/global-constructors-attributes-expected.txt (150589 => 150590)


--- trunk/LayoutTests/platform/qt/fast/js/global-constructors-attributes-expected.txt	2013-05-23 16:13:35 UTC (rev 150589)
+++ trunk/LayoutTests/platform/qt/fast/js/global-constructors-attributes-expected.txt	2013-05-23 16:45:10 UTC (rev 150590)
@@ -288,11 +288,6 @@
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'FileReader').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').value is FileReaderSync
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'FileReaderSync').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').value is Float32Array
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Float32Array').hasOwnProperty('set') is false
@@ -1843,11 +1838,6 @@
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'Worker').configurable is true
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').value is WorkerLocation
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('get') is false
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').hasOwnProperty('set') is false
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').enumerable is false
-PASS Object.getOwnPropertyDescriptor(global, 'WorkerLocation').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').value is XMLDocument
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'XMLDocument').hasOwnProperty('set') is false

Modified: trunk/Source/WebCore/ChangeLog (150589 => 150590)


--- trunk/Source/WebCore/ChangeLog	2013-05-23 16:13:35 UTC (rev 150589)
+++ trunk/Source/WebCore/ChangeLog	2013-05-23 16:45:10 UTC (rev 150590)
@@ -1,5 +1,17 @@
 2013-05-23  Christophe Dumez  <[email protected]>
 
+        Unreviewed, rolling out r150586.
+        http://trac.webkit.org/changeset/150586
+        https://bugs.webkit.org/show_bug.cgi?id=116660
+
+        Those constructors should be exposed on the WorkerContext, not
+        the DOMWindow
+
+        * fileapi/FileReaderSync.idl:
+        * workers/WorkerLocation.idl:
+
+2013-05-23  Christophe Dumez  <[email protected]>
+
         Remove [NoInterfaceObject] from FileReaderSync and WorkerLocation
         https://bugs.webkit.org/show_bug.cgi?id=116660

Modified: trunk/Source/WebCore/fileapi/FileReaderSync.idl (150589 => 150590)


--- trunk/Source/WebCore/fileapi/FileReaderSync.idl	2013-05-23 16:13:35 UTC (rev 150589)
+++ trunk/Source/WebCore/fileapi/FileReaderSync.idl	2013-05-23 16:45:10 UTC (rev 150590)
@@ -29,6 +29,7 @@
  */
 
 [
+    NoInterfaceObject,
     Conditional=BLOB,
     Constructor,
     JSNoStaticTables

Modified: trunk/Source/WebCore/workers/WorkerLocation.idl (150589 => 150590)


--- trunk/Source/WebCore/workers/WorkerLocation.idl	2013-05-23 16:13:35 UTC (rev 150589)
+++ trunk/Source/WebCore/workers/WorkerLocation.idl	2013-05-23 16:45:10 UTC (rev 150590)
@@ -27,6 +27,7 @@
  */
 
 [
+    NoInterfaceObject,
     Conditional=WORKERS,
     GenerateIsReachable=Impl,
     JSNoStaticTables,

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to