Title: [150233] trunk/Source/WebKit/blackberry
- Revision
- 150233
- Author
- mifen...@rim.com
- Date
- 2013-05-16 19:53:15 -0700 (Thu, 16 May 2013)
Log Message
[BlackBerry] Optimize caret bounds calculation when leaving an input field.
https://bugs.webkit.org/show_bug.cgi?id=116224
Reviewed by Rob Buis.
PR 340132.
If the caret is no longer active in the field, do not allow it
to go into the single line input logic and calculate the node
bounding box.
Internally Reviewed By Gen Mak
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (150232 => 150233)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-05-17 02:50:22 UTC (rev 150232)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-05-17 02:53:15 UTC (rev 150233)
@@ -1,3 +1,21 @@
+2013-05-16 Mike Fenton <mifen...@rim.com>
+
+ [BlackBerry] Optimize caret bounds calculation when leaving an input field.
+ https://bugs.webkit.org/show_bug.cgi?id=116224
+
+ Reviewed by Rob Buis.
+
+ PR 340132.
+
+ If the caret is no longer active in the field, do not allow it
+ to go into the single line input logic and calculate the node
+ bounding box.
+
+ Internally Reviewed By Gen Mak
+
+ * WebKitSupport/SelectionHandler.cpp:
+ (BlackBerry::WebKit::SelectionHandler::caretPositionChanged):
+
2013-05-16 Mary Wu <mary...@torchmobile.com.cn>
[BlackBerry] Unable to download blob resource
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp (150232 => 150233)
--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2013-05-17 02:50:22 UTC (rev 150232)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2013-05-17 02:53:15 UTC (rev 150233)
@@ -1303,7 +1303,7 @@
"SelectionHandler::caretPositionChanged caret Rect %s",
Platform::IntRect(caretLocation).toString().c_str());
- bool isSingleLineInput = !m_webPage->m_inputHandler->isMultilineInputMode();
+ bool isSingleLineInput = m_caretActive && !m_webPage->m_inputHandler->isMultilineInputMode();
WebCore::IntRect nodeBoundingBox = isSingleLineInput ? m_webPage->m_inputHandler->boundingBoxForInputField() : WebCore::IntRect();
if (!nodeBoundingBox.isEmpty()) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
