Title: [148141] trunk/Source/WebKit2
- Revision
- 148141
- Author
- timothy_hor...@apple.com
- Date
- 2013-04-10 15:18:49 -0700 (Wed, 10 Apr 2013)
Log Message
[wk2] REGRESSION: Find highlight does not update when the view is resized
https://bugs.webkit.org/show_bug.cgi?id=114382
<rdar://problem/13599797>
Reviewed by Simon Fraser.
Invalidate the page overlays from TiledCoreAnimationDrawingArea::updateGeometry.
This will have no effect if the page overlay hasn't previously asked to be painted
(as drawsContent will remain false on the layer).
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea): Add invalidateAllPageOverlays.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::invalidateAllPageOverlays): Factor this out of didChangeScrollOffsetForAnyFrame.
(WebKit::TiledCoreAnimationDrawingArea::didChangeScrollOffsetForAnyFrame): Call invalidateAllPageOverlays.
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry): Call invalidateAllPageOverlays.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (148140 => 148141)
--- trunk/Source/WebKit2/ChangeLog 2013-04-10 21:53:28 UTC (rev 148140)
+++ trunk/Source/WebKit2/ChangeLog 2013-04-10 22:18:49 UTC (rev 148141)
@@ -1,3 +1,22 @@
+2013-04-10 Tim Horton <timothy_hor...@apple.com>
+
+ [wk2] REGRESSION: Find highlight does not update when the view is resized
+ https://bugs.webkit.org/show_bug.cgi?id=114382
+ <rdar://problem/13599797>
+
+ Reviewed by Simon Fraser.
+
+ Invalidate the page overlays from TiledCoreAnimationDrawingArea::updateGeometry.
+ This will have no effect if the page overlay hasn't previously asked to be painted
+ (as drawsContent will remain false on the layer).
+
+ * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
+ (TiledCoreAnimationDrawingArea): Add invalidateAllPageOverlays.
+ * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
+ (WebKit::TiledCoreAnimationDrawingArea::invalidateAllPageOverlays): Factor this out of didChangeScrollOffsetForAnyFrame.
+ (WebKit::TiledCoreAnimationDrawingArea::didChangeScrollOffsetForAnyFrame): Call invalidateAllPageOverlays.
+ (WebKit::TiledCoreAnimationDrawingArea::updateGeometry): Call invalidateAllPageOverlays.
+
2013-04-10 Beth Dakin <bda...@apple.com>
FindBanner matches are offset when the WKView has a header or footer
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h (148140 => 148141)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h 2013-04-10 21:53:28 UTC (rev 148140)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h 2013-04-10 22:18:49 UTC (rev 148141)
@@ -110,6 +110,8 @@
void updateDebugInfoLayer(bool showLayer);
void updateIntrinsicContentSizeTimerFired(WebCore::Timer<TiledCoreAnimationDrawingArea>*);
+
+ void invalidateAllPageOverlays();
bool m_layerTreeStateIsFrozen;
WebCore::LayerFlushScheduler m_layerFlushScheduler;
Modified: trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm (148140 => 148141)
--- trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2013-04-10 21:53:28 UTC (rev 148140)
+++ trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm 2013-04-10 22:18:49 UTC (rev 148141)
@@ -114,12 +114,17 @@
{
}
-void TiledCoreAnimationDrawingArea::didChangeScrollOffsetForAnyFrame()
+void TiledCoreAnimationDrawingArea::invalidateAllPageOverlays()
{
for (PageOverlayLayerMap::iterator it = m_pageOverlayLayers.begin(), end = m_pageOverlayLayers.end(); it != end; ++it)
it->value->setNeedsDisplay();
}
+void TiledCoreAnimationDrawingArea::didChangeScrollOffsetForAnyFrame()
+{
+ invalidateAllPageOverlays();
+}
+
void TiledCoreAnimationDrawingArea::setRootCompositingLayer(GraphicsLayer* graphicsLayer)
{
CALayer *rootCompositingLayer = graphicsLayer ? graphicsLayer->platformLayer() : nil;
@@ -440,6 +445,8 @@
if (!m_layerTreeStateIsFrozen)
flushLayers();
+ invalidateAllPageOverlays();
+
[CATransaction begin];
[CATransaction setDisableActions:YES];
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
