Title: [148128] trunk/Source/WebCore
Revision
148128
Author
akl...@apple.com
Date
2013-04-10 12:38:07 -0700 (Wed, 10 Apr 2013)

Log Message

Disallow programmatic movement of the browser window while user gestures are in progress.
<http://webkit.org/b/114271>
<rdar://problem/13226530>

Reviewed by Oliver Hunt.

* page/DOMWindow.cpp:
(WebCore::DOMWindow::moveBy):
(WebCore::DOMWindow::moveTo):
(WebCore::DOMWindow::resizeBy):
(WebCore::DOMWindow::resizeTo):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (148127 => 148128)


--- trunk/Source/WebCore/ChangeLog	2013-04-10 19:33:39 UTC (rev 148127)
+++ trunk/Source/WebCore/ChangeLog	2013-04-10 19:38:07 UTC (rev 148128)
@@ -1,3 +1,17 @@
+2013-04-10  Andreas Kling  <akl...@apple.com>
+
+        Disallow programmatic movement of the browser window while user gestures are in progress.
+        <http://webkit.org/b/114271>
+        <rdar://problem/13226530>
+
+        Reviewed by Oliver Hunt.
+
+        * page/DOMWindow.cpp:
+        (WebCore::DOMWindow::moveBy):
+        (WebCore::DOMWindow::moveTo):
+        (WebCore::DOMWindow::resizeBy):
+        (WebCore::DOMWindow::resizeTo):
+
 2013-04-10  Ryosuke Niwa  <rn...@webkit.org>
 
         Refactor Editor::markAndReplaceFor before fixing autocorrection bugs

Modified: trunk/Source/WebCore/page/DOMWindow.cpp (148127 => 148128)


--- trunk/Source/WebCore/page/DOMWindow.cpp	2013-04-10 19:33:39 UTC (rev 148127)
+++ trunk/Source/WebCore/page/DOMWindow.cpp	2013-04-10 19:38:07 UTC (rev 148128)
@@ -1448,6 +1448,9 @@
 
 void DOMWindow::moveBy(float x, float y) const
 {
+    if (UserGestureIndicator::processingUserGesture())
+        return;
+
     if (!m_frame)
         return;
 
@@ -1467,6 +1470,9 @@
 
 void DOMWindow::moveTo(float x, float y) const
 {
+    if (UserGestureIndicator::processingUserGesture())
+        return;
+
     if (!m_frame)
         return;
 
@@ -1488,6 +1494,9 @@
 
 void DOMWindow::resizeBy(float x, float y) const
 {
+    if (UserGestureIndicator::processingUserGesture())
+        return;
+
     if (!m_frame)
         return;
 
@@ -1506,6 +1515,9 @@
 
 void DOMWindow::resizeTo(float width, float height) const
 {
+    if (UserGestureIndicator::processingUserGesture())
+        return;
+
     if (!m_frame)
         return;
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to