- Revision
- 147832
- Author
- kangil....@samsung.com
- Date
- 2013-04-05 21:41:38 -0700 (Fri, 05 Apr 2013)
Log Message
Prefer prefix ++/-- operators for non-primitive types
https://bugs.webkit.org/show_bug.cgi?id=114033
Reviewed by Alexey Proskuryakov.
Post ++/-- creates a copy of current value and it is not necessary, so use prefix instead.
* bindings/js/Dictionary.cpp:
(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):
* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
* dom/ContainerNode.cpp:
(WebCore::willRemoveChildren):
* dom/Range.cpp:
(WebCore::Range::processAncestorsAndTheirSiblings):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::detachChildren):
* platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
(WebCore):
(WebCore::LoopBlinnPathProcessor::subdivideCurvesSlow):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDocumentMarkers):
* xml/XPathFunctions.cpp:
(WebCore::XPath::Function::setArguments):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (147831 => 147832)
--- trunk/Source/WebCore/ChangeLog 2013-04-06 04:21:08 UTC (rev 147831)
+++ trunk/Source/WebCore/ChangeLog 2013-04-06 04:41:38 UTC (rev 147832)
@@ -1,3 +1,31 @@
+2013-04-05 Kangil Han <kangil....@samsung.com>
+
+ Prefer prefix ++/-- operators for non-primitive types
+ https://bugs.webkit.org/show_bug.cgi?id=114033
+
+ Reviewed by Alexey Proskuryakov.
+
+ Post ++/-- creates a copy of current value and it is not necessary, so use prefix instead.
+
+ * bindings/js/Dictionary.cpp:
+ (WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
+ (WebCore::Dictionary::getOwnPropertyNames):
+ * bindings/js/ScriptCallStackFactory.cpp:
+ (WebCore::createScriptCallStack):
+ * dom/ContainerNode.cpp:
+ (WebCore::willRemoveChildren):
+ * dom/Range.cpp:
+ (WebCore::Range::processAncestorsAndTheirSiblings):
+ * loader/FrameLoader.cpp:
+ (WebCore::FrameLoader::detachChildren):
+ * platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
+ (WebCore):
+ (WebCore::LoopBlinnPathProcessor::subdivideCurvesSlow):
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::paintDocumentMarkers):
+ * xml/XPathFunctions.cpp:
+ (WebCore::XPath::Function::setArguments):
+
2013-04-05 Hans Muller <hmul...@adobe.com>
[CSS Exclusions] Add support for the simple case of shape-margin polygonal shape-outside
Modified: trunk/Source/WebCore/bindings/js/Dictionary.cpp (147831 => 147832)
--- trunk/Source/WebCore/bindings/js/Dictionary.cpp 2013-04-06 04:21:08 UTC (rev 147831)
+++ trunk/Source/WebCore/bindings/js/Dictionary.cpp 2013-04-06 04:41:38 UTC (rev 147832)
@@ -64,7 +64,7 @@
PropertyNameArray propertyNames(exec);
JSObject::getOwnPropertyNames(object, exec, propertyNames, ExcludeDontEnumProperties);
- for (PropertyNameArray::const_iterator it = propertyNames.begin(); it != propertyNames.end(); it++) {
+ for (PropertyNameArray::const_iterator it = propertyNames.begin(); it != propertyNames.end(); ++it) {
String stringKey = it->string();
if (stringKey.isEmpty())
continue;
@@ -89,7 +89,7 @@
PropertyNameArray propertyNames(exec);
JSObject::getOwnPropertyNames(object, exec, propertyNames, ExcludeDontEnumProperties);
- for (PropertyNameArray::const_iterator it = propertyNames.begin(); it != propertyNames.end(); it++) {
+ for (PropertyNameArray::const_iterator it = propertyNames.begin(); it != propertyNames.end(); ++it) {
String stringKey = it->string();
if (!stringKey.isEmpty())
names.append(stringKey);
Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (147831 => 147832)
--- trunk/Source/WebCore/dom/ContainerNode.cpp 2013-04-06 04:21:08 UTC (rev 147831)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp 2013-04-06 04:41:38 UTC (rev 147832)
@@ -462,7 +462,7 @@
container->document()->nodeChildrenWillBeRemoved(container);
ChildListMutationScope mutation(container);
- for (NodeVector::const_iterator it = children.begin(); it != children.end(); it++) {
+ for (NodeVector::const_iterator it = children.begin(); it != children.end(); ++it) {
Node* child = it->get();
mutation.willRemoveChild(child);
child->notifyMutationObserversNodeWillDetach();
Modified: trunk/Source/WebCore/dom/Range.cpp (147831 => 147832)
--- trunk/Source/WebCore/dom/Range.cpp 2013-04-06 04:21:08 UTC (rev 147831)
+++ trunk/Source/WebCore/dom/Range.cpp 2013-04-06 04:41:38 UTC (rev 147832)
@@ -873,7 +873,7 @@
ancestors.append(n);
RefPtr<Node> firstChildInAncestorToProcess = direction == ProcessContentsForward ? container->nextSibling() : container->previousSibling();
- for (Vector<RefPtr<Node> >::const_iterator it = ancestors.begin(); it != ancestors.end(); it++) {
+ for (Vector<RefPtr<Node> >::const_iterator it = ancestors.begin(); it != ancestors.end(); ++it) {
RefPtr<Node> ancestor = *it;
if (action == EXTRACT_CONTENTS || action == CLONE_CONTENTS) {
if (RefPtr<Node> clonedAncestor = ancestor->cloneNode(false)) { // Might have been removed already during mutation event.
@@ -892,7 +892,7 @@
child = (direction == ProcessContentsForward) ? child->nextSibling() : child->previousSibling())
nodes.append(child);
- for (NodeVector::const_iterator it = nodes.begin(); it != nodes.end(); it++) {
+ for (NodeVector::const_iterator it = nodes.begin(); it != nodes.end(); ++it) {
Node* child = it->get();
switch (action) {
case DELETE_CONTENTS:
Modified: trunk/Source/WebCore/loader/FrameLoader.cpp (147831 => 147832)
--- trunk/Source/WebCore/loader/FrameLoader.cpp 2013-04-06 04:21:08 UTC (rev 147831)
+++ trunk/Source/WebCore/loader/FrameLoader.cpp 2013-04-06 04:41:38 UTC (rev 147832)
@@ -2305,7 +2305,7 @@
for (Frame* child = m_frame->tree()->lastChild(); child; child = child->tree()->previousSibling())
childrenToDetach.append(child);
FrameVector::iterator end = childrenToDetach.end();
- for (FrameVector::iterator it = childrenToDetach.begin(); it != end; it++)
+ for (FrameVector::iterator it = childrenToDetach.begin(); it != end; ++it)
(*it)->loader()->detachFromParent();
}
Modified: trunk/Source/WebCore/platform/graphics/gpu/LoopBlinnPathProcessor.cpp (147831 => 147832)
--- trunk/Source/WebCore/platform/graphics/gpu/LoopBlinnPathProcessor.cpp 2013-04-06 04:21:08 UTC (rev 147831)
+++ trunk/Source/WebCore/platform/graphics/gpu/LoopBlinnPathProcessor.cpp 2013-04-06 04:41:38 UTC (rev 147832)
@@ -1098,9 +1098,7 @@
for (Vector<Segment*>::iterator iter = curSegments.begin(); iter != curSegments.end(); ++iter) {
Segment* seg = *iter;
ASSERT(seg->kind() == Segment::Cubic);
- for (Vector<Segment*>::iterator iter2 = curSegments.begin();
- iter2 != curSegments.end();
- iter2++) {
+ for (Vector<Segment*>::iterator iter2 = curSegments.begin(); iter2 != curSegments.end(); ++iter2) {
Segment* seg2 = *iter2;
ASSERT(seg2->kind() == Segment::Cubic);
if (seg != seg2) {
Modified: trunk/Source/WebCore/rendering/InlineTextBox.cpp (147831 => 147832)
--- trunk/Source/WebCore/rendering/InlineTextBox.cpp 2013-04-06 04:21:08 UTC (rev 147831)
+++ trunk/Source/WebCore/rendering/InlineTextBox.cpp 2013-04-06 04:41:38 UTC (rev 147832)
@@ -1398,7 +1398,7 @@
// Give any document markers that touch this run a chance to draw before the text has been drawn.
// Note end() points at the last char, not one past it like endOffset and ranges do.
- for ( ; markerIt != markers.end(); markerIt++) {
+ for ( ; markerIt != markers.end(); ++markerIt) {
DocumentMarker* marker = *markerIt;
// Paint either the background markers or the foreground markers, but not both
Modified: trunk/Source/WebCore/xml/XPathFunctions.cpp (147831 => 147832)
--- trunk/Source/WebCore/xml/XPathFunctions.cpp 2013-04-06 04:21:08 UTC (rev 147831)
+++ trunk/Source/WebCore/xml/XPathFunctions.cpp 2013-04-06 04:41:38 UTC (rev 147832)
@@ -299,7 +299,7 @@
setIsContextNodeSensitive(false);
Vector<_expression_*>::const_iterator end = args.end();
- for (Vector<_expression_*>::const_iterator it = args.begin(); it != end; it++)
+ for (Vector<_expression_*>::const_iterator it = args.begin(); it != end; ++it)
addSubExpression(*it);
}
