Title: [147585] trunk/LayoutTests
- Revision
- 147585
- Author
- [email protected]
- Date
- 2013-04-03 14:35:12 -0700 (Wed, 03 Apr 2013)
Log Message
get_by_pname can become confused when iterating over objects with static properties
https://bugs.webkit.org/show_bug.cgi?id=113831
Reviewed by Jer Noble.
Improving the test results to make it more obvious why something failed. Also removed
absolute paths from the test.
* fast/js/dom-static-property-for-in-iteration-expected.txt:
* fast/js/dom-static-property-for-in-iteration.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (147584 => 147585)
--- trunk/LayoutTests/ChangeLog 2013-04-03 21:21:12 UTC (rev 147584)
+++ trunk/LayoutTests/ChangeLog 2013-04-03 21:35:12 UTC (rev 147585)
@@ -1,3 +1,16 @@
+2013-04-03 Mark Hahnenberg <[email protected]>
+
+ get_by_pname can become confused when iterating over objects with static properties
+ https://bugs.webkit.org/show_bug.cgi?id=113831
+
+ Reviewed by Jer Noble.
+
+ Improving the test results to make it more obvious why something failed. Also removed
+ absolute paths from the test.
+
+ * fast/js/dom-static-property-for-in-iteration-expected.txt:
+ * fast/js/dom-static-property-for-in-iteration.html:
+
2013-04-03 David Vest <[email protected]>
ASSERTION FAILED: resultAnimationElement->m_animatedType
Modified: trunk/LayoutTests/fast/js/dom-static-property-for-in-iteration-expected.txt (147584 => 147585)
--- trunk/LayoutTests/fast/js/dom-static-property-for-in-iteration-expected.txt 2013-04-03 21:21:12 UTC (rev 147584)
+++ trunk/LayoutTests/fast/js/dom-static-property-for-in-iteration-expected.txt 2013-04-03 21:35:12 UTC (rev 147585)
@@ -3,110 +3,107 @@
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-PASS 'file://' is 'file://'
-PASS '' is ''
-PASS 'file:///Volumes/Data/WebKit-svn-01/OpenSource/LayoutTests/fast/js/bar' is 'file:///Volumes/Data/WebKit-svn-01/OpenSource/LayoutTests/fast/js/bar'
-PASS '' is ''
-PASS 'nerget' is 'nerget'
-PASS '' is ''
-PASS '' is ''
-PASS '' is ''
-PASS '' is ''
-PASS '' is ''
-PASS '' is ''
-PASS '' is ''
-PASS '/Volumes/Data/WebKit-svn-01/OpenSource/LayoutTests/fast/js/bar' is '/Volumes/Data/WebKit-svn-01/OpenSource/LayoutTests/fast/js/bar'
-PASS '' is ''
-PASS '' is ''
-PASS '' is ''
-PASS '' is ''
-PASS '' is ''
-PASS '' is ''
-PASS 'file:' is 'file:'
-PASS '<a id="foo" href="" is '<a id="foo" href=""
-PASS 'true' is 'true'
-PASS '' is ''
-PASS 'foo' is 'foo'
-PASS '' is ''
-PASS '' is ''
-PASS 'true' is 'true'
-PASS 'false' is 'false'
-PASS 'nerget' is 'nerget'
-PASS '' is ''
-PASS 'nerget' is 'nerget'
-PASS 'inherit' is 'inherit'
-PASS '0' is '0'
-PASS 'true' is 'true'
-PASS 'nerget' is 'nerget'
-PASS '' is ''
-PASS '[object HTMLCollection]' is '[object HTMLCollection]'
-PASS 'false' is 'false'
-PASS '[object CSSStyleDeclaration]' is '[object CSSStyleDeclaration]'
-PASS '[object DOMStringMap]' is '[object DOMStringMap]'
-PASS '0' is '0'
-PASS '0' is '0'
-PASS '[object NamedNodeMap]' is '[object NamedNodeMap]'
-PASS 'undefined' is 'undefined'
-PASS '39' is '39'
-PASS '' is ''
-PASS '8' is '8'
-PASS '' is ''
-PASS '0' is '0'
-PASS 'null' is 'null'
-PASS '[object HTMLBodyElement]' is '[object HTMLBodyElement]'
-PASS '[object HTMLScriptElement]' is '[object HTMLScriptElement]'
-PASS 'A' is 'A'
-PASS '[object HTMLDivElement]' is '[object HTMLDivElement]'
-PASS '0' is '0'
-PASS '0' is '0'
-PASS 'null' is 'null'
-PASS '0' is '0'
-PASS '18' is '18'
-PASS '0' is '0'
-PASS '1014' is '1014'
-PASS '0' is '0'
-PASS '0' is '0'
-PASS '[object Text]' is '[object Text]'
-PASS '[object HTMLBodyElement]' is '[object HTMLBodyElement]'
-PASS '[object Text]' is '[object Text]'
-PASS 'file:///Volumes/Data/WebKit-svn-01/OpenSource/LayoutTests/fast/js/dom-static-property-for-in-iteration.html' is 'file:///Volumes/Data/WebKit-svn-01/OpenSource/LayoutTests/fast/js/dom-static-property-for-in-iteration.html'
-PASS '[object Text]' is '[object Text]'
-PASS 'null' is 'null'
-PASS 'nerget' is 'nerget'
-PASS '1' is '1'
-PASS 'A' is 'A'
-PASS 'null' is 'null'
-PASS '[object NodeList]' is '[object NodeList]'
-PASS '[object Text]' is '[object Text]'
-PASS '[object HTMLDocument]' is '[object HTMLDocument]'
-PASS 'http://www.w3.org/1999/xhtml' is 'http://www.w3.org/1999/xhtml'
-PASS 'a' is 'a'
-PASS '[object HTMLBodyElement]' is '[object HTMLBodyElement]'
-PASS '1' is '1'
-PASS '2' is '2'
-PASS '3' is '3'
-PASS '4' is '4'
-PASS '5' is '5'
-PASS '6' is '6'
-PASS '1' is '1'
-PASS '12' is '12'
-PASS '4' is '4'
-PASS '1' is '1'
-PASS '1' is '1'
-PASS '6' is '6'
-PASS '3' is '3'
-PASS '5' is '5'
-PASS '32' is '32'
-PASS '11' is '11'
-PASS '7' is '7'
-PASS '2' is '2'
-PASS '10' is '10'
-PASS '8' is '8'
-PASS '4' is '4'
-PASS '2' is '2'
-PASS '16' is '16'
-PASS '9' is '9'
-PASS '8' is '8'
+PASS a["origin"] is file://
+PASS a["hash"] is
+PASS a["search"] is
+PASS a["text"] is nerget
+PASS a["hostname"] is
+PASS a["rel"] is
+PASS a["name"] is
+PASS a["hreflang"] is
+PASS a["ping"] is
+PASS a["rev"] is
+PASS a["host"] is
+PASS a["charset"] is
+PASS a["target"] is
+PASS a["type"] is
+PASS a["coords"] is
+PASS a["shape"] is
+PASS a["port"] is
+PASS a["protocol"] is file:
+PASS a["outerHTML"] is <a id="foo" href=""
+PASS a["spellcheck"] is true
+PASS a["webkitdropzone"] is
+PASS a["id"] is foo
+PASS a["title"] is
+PASS a["lang"] is
+PASS a["translate"] is true
+PASS a["hidden"] is false
+PASS a["innerText"] is nerget
+PASS a["dir"] is
+PASS a["innerHTML"] is nerget
+PASS a["contentEditable"] is inherit
+PASS a["tabIndex"] is 0
+PASS a["draggable"] is true
+PASS a["outerText"] is nerget
+PASS a["accessKey"] is
+PASS a["children"] is [object HTMLCollection]
+PASS a["isContentEditable"] is false
+PASS a["style"] is [object CSSStyleDeclaration]
+PASS a["dataset"] is [object DOMStringMap]
+PASS a["clientWidth"] is 0
+PASS a["scrollWidth"] is 0
+PASS a["attributes"] is [object NamedNodeMap]
+PASS a["webkitRegionOverset"] is undefined
+PASS a["offsetWidth"] is 39
+PASS a["classList"] is
+PASS a["offsetLeft"] is 8
+PASS a["className"] is
+PASS a["clientTop"] is 0
+PASS a["lastElementChild"] is null
+PASS a["offsetParent"] is [object HTMLBodyElement]
+PASS a["nextElementSibling"] is [object HTMLScriptElement]
+PASS a["tagName"] is A
+PASS a["previousElementSibling"] is [object HTMLDivElement]
+PASS a["childElementCount"] is 0
+PASS a["scrollLeft"] is 0
+PASS a["firstElementChild"] is null
+PASS a["clientLeft"] is 0
+PASS a["offsetHeight"] is 18
+PASS a["clientHeight"] is 0
+PASS a["offsetTop"] is 954
+PASS a["scrollTop"] is 0
+PASS a["scrollHeight"] is 0
+PASS a["previousSibling"] is [object Text]
+PASS a["parentNode"] is [object HTMLBodyElement]
+PASS a["lastChild"] is [object Text]
+PASS a["firstChild"] is [object Text]
+PASS a["nodeValue"] is null
+PASS a["textContent"] is nerget
+PASS a["nodeType"] is 1
+PASS a["nodeName"] is A
+PASS a["prefix"] is null
+PASS a["childNodes"] is [object NodeList]
+PASS a["nextSibling"] is [object Text]
+PASS a["ownerDocument"] is [object HTMLDocument]
+PASS a["namespaceURI"] is http://www.w3.org/1999/xhtml
+PASS a["localName"] is a
+PASS a["parentElement"] is [object HTMLBodyElement]
+PASS a["foo"] is 1
+PASS a["bar"] is 2
+PASS a["wibble"] is 3
+PASS a["hick"] is 4
+PASS a["hock"] is 5
+PASS a["snood"] is 6
+PASS a["ALLOW_KEYBOARD_INPUT"] is 1
+PASS a["NOTATION_NODE"] is 12
+PASS a["CDATA_SECTION_NODE"] is 4
+PASS a["ELEMENT_NODE"] is 1
+PASS a["DOCUMENT_POSITION_DISCONNECTED"] is 1
+PASS a["ENTITY_NODE"] is 6
+PASS a["TEXT_NODE"] is 3
+PASS a["ENTITY_REFERENCE_NODE"] is 5
+PASS a["DOCUMENT_POSITION_IMPLEMENTATION_SPECIFIC"] is 32
+PASS a["DOCUMENT_FRAGMENT_NODE"] is 11
+PASS a["PROCESSING_INSTRUCTION_NODE"] is 7
+PASS a["DOCUMENT_POSITION_PRECEDING"] is 2
+PASS a["DOCUMENT_TYPE_NODE"] is 10
+PASS a["COMMENT_NODE"] is 8
+PASS a["DOCUMENT_POSITION_FOLLOWING"] is 4
+PASS a["ATTRIBUTE_NODE"] is 2
+PASS a["DOCUMENT_POSITION_CONTAINED_BY"] is 16
+PASS a["DOCUMENT_NODE"] is 9
+PASS a["DOCUMENT_POSITION_CONTAINS"] is 8
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/js/dom-static-property-for-in-iteration.html (147584 => 147585)
--- trunk/LayoutTests/fast/js/dom-static-property-for-in-iteration.html 2013-04-03 21:21:12 UTC (rev 147584)
+++ trunk/LayoutTests/fast/js/dom-static-property-for-in-iteration.html 2013-04-03 21:35:12 UTC (rev 147585)
@@ -7,6 +7,13 @@
<body>
<a id="foo" href=""
<script>
+ var realShouldBe = function(expectedValue, actualString, actualValue) {
+ if (expectedValue === actualValue)
+ testPassed(actualString + " is " + expectedValue);
+ else
+ testFailed(actualString + " should be " + expectedValue + ". Was " + actualValue);
+ };
+
description(
"Checks that get_by_pname doesn't get confused about which properties go where when it comes to stacic properties."
);
@@ -18,7 +25,9 @@
// Function toString causes eval to choke.
if (typeof expected === "function")
continue;
- shouldBe("'" + a[i] + "'", "'" + expected + "'");
+ if (i === "href" || i === "pathname" || i === "baseURI")
+ continue;
+ realShouldBe(expected, "a[\"" + i + "\"]", actual);
}
}
var g = document.getElementById("foo");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
