Title: [146880] trunk/Source/WebKit2
Revision
146880
Author
zeno.albis...@digia.com
Date
2013-03-26 07:52:57 -0700 (Tue, 26 Mar 2013)

Log Message

[Qt] UIProcess should initialize WebCoreSystemInterface.
https://bugs.webkit.org/show_bug.cgi?id=113300

The WebCoreSystemInterface is necessary to detect supported
mime types on Mac OS. In particular it is needed for download
support.
This patch fixes in particular the previously failing
Qt API qmltest WebViewDownload::test_downloadRequest.
The test was crashing when using QTKit, because functions
in WebCoreSystemInterface could not be resolved on the UIProcess side.

Reviewed by Jocelyn Turcotte.

* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformInitializeWebProcess):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (146879 => 146880)


--- trunk/Source/WebKit2/ChangeLog	2013-03-26 13:53:19 UTC (rev 146879)
+++ trunk/Source/WebKit2/ChangeLog	2013-03-26 14:52:57 UTC (rev 146880)
@@ -1,3 +1,21 @@
+2013-03-26  Zeno Albisser  <z...@webkit.org>
+
+        [Qt] UIProcess should initialize WebCoreSystemInterface.
+        https://bugs.webkit.org/show_bug.cgi?id=113300
+
+        The WebCoreSystemInterface is necessary to detect supported
+        mime types on Mac OS. In particular it is needed for download
+        support.
+        This patch fixes in particular the previously failing
+        Qt API qmltest WebViewDownload::test_downloadRequest.
+        The test was crashing when using QTKit, because functions
+        in WebCoreSystemInterface could not be resolved on the UIProcess side.
+
+        Reviewed by Jocelyn Turcotte.
+
+        * UIProcess/qt/WebContextQt.cpp:
+        (WebKit::WebContext::platformInitializeWebProcess):
+
 2013-03-25  Kent Tamura  <tk...@chromium.org>
 
         Rename ENABLE_INPUT_TYPE_DATETIME

Modified: trunk/Source/WebKit2/UIProcess/qt/WebContextQt.cpp (146879 => 146880)


--- trunk/Source/WebKit2/UIProcess/qt/WebContextQt.cpp	2013-03-26 13:53:19 UTC (rev 146879)
+++ trunk/Source/WebKit2/UIProcess/qt/WebContextQt.cpp	2013-03-26 14:52:57 UTC (rev 146880)
@@ -30,6 +30,7 @@
 #include "ApplicationCacheStorage.h"
 #include "WKSharedAPICast.h"
 #include "WebProcessCreationParameters.h"
+#include "WebSystemInterface.h"
 #include <QProcess>
 
 #if ENABLE(GEOLOCATION)
@@ -56,6 +57,9 @@
     static WebGeolocationProviderQt* location = WebGeolocationProviderQt::create(toAPI(supplement<WebGeolocationManagerProxy>()));
     WKGeolocationManagerSetProvider(toAPI(supplement<WebGeolocationManagerProxy>()), WebGeolocationProviderQt::provider(location));
 #endif
+#if USE(QTKIT)
+    InitWebCoreSystemInterfaceForWK2();
+#endif
 }
 
 void WebContext::platformInvalidateContext()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to