Title: [146753] trunk/Source/WebCore
- Revision
- 146753
- Author
- eus...@chromium.org
- Date
- 2013-03-25 02:50:44 -0700 (Mon, 25 Mar 2013)
Log Message
Web Inspector: [Overview] Make "drag-to-move" feature more discoverable.
https://bugs.webkit.org/show_bug.cgi?id=113032
Reviewed by Pavel Feldman.
To move overview window user could drag-n-drop over
time "ribbon" on OverviewGrid.
This feature is hard to discover.
Setting "move" cursor will make this feature more discoverable.
* inspector/front-end/inspectorCommon.css:
Set "move" cursor to draggable area.
* inspector/front-end/OverviewGrid.js: Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (146752 => 146753)
--- trunk/Source/WebCore/ChangeLog 2013-03-25 09:33:30 UTC (rev 146752)
+++ trunk/Source/WebCore/ChangeLog 2013-03-25 09:50:44 UTC (rev 146753)
@@ -1,5 +1,23 @@
2013-03-25 Eugene Klyuchnikov <eus...@chromium.org>
+ Web Inspector: [Overview] Make "drag-to-move" feature more discoverable.
+ https://bugs.webkit.org/show_bug.cgi?id=113032
+
+ Reviewed by Pavel Feldman.
+
+ To move overview window user could drag-n-drop over
+ time "ribbon" on OverviewGrid.
+
+ This feature is hard to discover.
+
+ Setting "move" cursor will make this feature more discoverable.
+
+ * inspector/front-end/inspectorCommon.css:
+ Set "move" cursor to draggable area.
+ * inspector/front-end/OverviewGrid.js: Ditto.
+
+2013-03-25 Eugene Klyuchnikov <eus...@chromium.org>
+
Web Inspector: [Profiles] Remove unused private member.
https://bugs.webkit.org/show_bug.cgi?id=113015
Modified: trunk/Source/WebCore/inspector/front-end/OverviewGrid.js (146752 => 146753)
--- trunk/Source/WebCore/inspector/front-end/OverviewGrid.js 2013-03-25 09:33:30 UTC (rev 146752)
+++ trunk/Source/WebCore/inspector/front-end/OverviewGrid.js 2013-03-25 09:50:44 UTC (rev 146753)
@@ -179,7 +179,7 @@
this._dividersLabelBarElement = dividersLabelBarElement;
WebInspector.installDragHandle(this._parentElement, this._startWindowSelectorDragging.bind(this), this._windowSelectorDragging.bind(this), this._endWindowSelectorDragging.bind(this), "ew-resize");
- WebInspector.installDragHandle(this._dividersLabelBarElement, this._startWindowDragging.bind(this), this._windowDragging.bind(this), this._endWindowDragging.bind(this), "ew-resize");
+ WebInspector.installDragHandle(this._dividersLabelBarElement, this._startWindowDragging.bind(this), this._windowDragging.bind(this), this._endWindowDragging.bind(this), "move");
this.windowLeft = 0.0;
this.windowRight = 1.0;
Modified: trunk/Source/WebCore/inspector/front-end/inspectorCommon.css (146752 => 146753)
--- trunk/Source/WebCore/inspector/front-end/inspectorCommon.css 2013-03-25 09:33:30 UTC (rev 146752)
+++ trunk/Source/WebCore/inspector/front-end/inspectorCommon.css 2013-03-25 09:50:44 UTC (rev 146753)
@@ -90,6 +90,7 @@
height: 20px;
z-index: 200;
pointer-events: none;
+ cursor: move;
}
.resources-divider {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
