Title: [146514] trunk/Tools
- Revision
- 146514
- Author
- dpra...@chromium.org
- Date
- 2013-03-21 13:56:16 -0700 (Thu, 21 Mar 2013)
Log Message
[chromium] add missing project dependencies to DRT to fix Mac Valgrind
https://bugs.webkit.org/show_bug.cgi?id=112953
Reviewed by Tony Chang.
When I created the DumpRenderTree_resources target in r144863 I
forgot to declare the needed dependencies on the other resource
targets. Due to a quirk of ordering, this appears to have been fine
w/ ninja but not w/ Xcode (which is still being used on the chromium
mac valgrind bots). Declaring the dependencies fixes the build
failures.
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (146513 => 146514)
--- trunk/Tools/ChangeLog 2013-03-21 20:53:02 UTC (rev 146513)
+++ trunk/Tools/ChangeLog 2013-03-21 20:56:16 UTC (rev 146514)
@@ -1,3 +1,19 @@
+2013-03-21 Dirk Pranke <dpra...@chromium.org>
+
+ [chromium] add missing project dependencies to DRT to fix Mac Valgrind
+ https://bugs.webkit.org/show_bug.cgi?id=112953
+
+ Reviewed by Tony Chang.
+
+ When I created the DumpRenderTree_resources target in r144863 I
+ forgot to declare the needed dependencies on the other resource
+ targets. Due to a quirk of ordering, this appears to have been fine
+ w/ ninja but not w/ Xcode (which is still being used on the chromium
+ mac valgrind bots). Declaring the dependencies fixes the build
+ failures.
+
+ * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
+
2013-03-21 Brent Fulgham <bfulg...@webkit.org>
[WinCairo] Correct assert in Empty BitmapImage Test.
Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp (146513 => 146514)
--- trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2013-03-21 20:53:02 UTC (rev 146513)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2013-03-21 20:56:16 UTC (rev 146514)
@@ -379,6 +379,12 @@
{
'target_name': 'DumpRenderTree_resources',
'type': 'none',
+ 'dependencies': [
+ '<(chromium_src_dir)/net/net.gyp:net_resources',
+ '<(chromium_src_dir)/ui/ui.gyp:ui_resources',
+ '<(chromium_src_dir)/webkit/support/webkit_support.gyp:webkit_resources',
+ '<(chromium_src_dir)/webkit/support/webkit_support.gyp:webkit_strings',
+ ],
'actions': [{
'action_name': 'repack_local',
'variables': {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
