Diff
Modified: trunk/LayoutTests/ChangeLog (146290 => 146291)
--- trunk/LayoutTests/ChangeLog 2013-03-20 01:58:51 UTC (rev 146290)
+++ trunk/LayoutTests/ChangeLog 2013-03-20 02:08:09 UTC (rev 146291)
@@ -1,3 +1,17 @@
+2013-03-19 Krzysztof Czech <k.cz...@samsung.com>
+
+ [EFL] canvas-fallback-content.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=111998
+
+ Reviewed by Chris Fleizach.
+
+ Fixed failing test. The reason of failure is different accessibility role for combobox element.
+
+ * accessibility/canvas-fallback-content.html: Use platform specific role.
+ * platform/efl-wk1/TestExpectations: Unskipped.
+ * platform/efl-wk2/TestExpectations: Unskipped.
+ * platform/efl/accessibility/canvas-fallback-content-expected.txt: Added.
+
2013-03-19 Kenneth Russell <k...@google.com>
Unreviewed rebaselining after r146279.
Modified: trunk/LayoutTests/accessibility/canvas-fallback-content.html (146290 => 146291)
--- trunk/LayoutTests/accessibility/canvas-fallback-content.html 2013-03-20 01:58:51 UTC (rev 146290)
+++ trunk/LayoutTests/accessibility/canvas-fallback-content.html 2013-03-20 02:08:09 UTC (rev 146291)
@@ -52,7 +52,7 @@
debug("");
}
- var comboBoxRole = (testRunner.platformName == "gtk") ? "AXRole: AXComboBox" : "AXRole: AXPopUpButton";
+ var comboBoxRole = (testRunner.platformName == "gtk" || testRunner.platformName == "efl") ? "AXRole: AXComboBox" : "AXRole: AXPopUpButton";
// Check rendered controls.
check("link1", "AXRole: AXLink");
Added: trunk/LayoutTests/platform/efl/accessibility/canvas-fallback-content-expected.txt (0 => 146291)
--- trunk/LayoutTests/platform/efl/accessibility/canvas-fallback-content-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/efl/accessibility/canvas-fallback-content-expected.txt 2013-03-20 02:08:09 UTC (rev 146291)
@@ -0,0 +1,101 @@
+Link Button
+Focusable
+ARIA button
+ARIA link
+This test makes sure that focusable elements in canvas fallback content are accessible.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+link1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXLink"
+
+button1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXButton"
+
+text1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXTextField"
+
+checkbox1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXCheckBox"
+
+radio1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXRadioButton"
+
+submit1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXButton"
+
+combobox1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXComboBox"
+
+focusable1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXGroup"
+
+aria-button1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXButton"
+
+aria-link1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXLink"
+
+link2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXLink"
+
+button2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXButton"
+
+text2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXTextField"
+
+checkbox2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXCheckBox"
+
+radio2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXRadioButton"
+
+submit2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXButton"
+
+combobox2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXComboBox"
+
+focusable2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXGroup"
+
+aria-button2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXButton"
+
+aria-link2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXLink"
+
+focusable1
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXButton"
+
+focusable2
+PASS document.activeElement == element is true
+PASS axElement.role is "AXRole: AXButton"
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Modified: trunk/LayoutTests/platform/efl-wk1/TestExpectations (146290 => 146291)
--- trunk/LayoutTests/platform/efl-wk1/TestExpectations 2013-03-20 01:58:51 UTC (rev 146290)
+++ trunk/LayoutTests/platform/efl-wk1/TestExpectations 2013-03-20 02:08:09 UTC (rev 146291)
@@ -118,7 +118,6 @@
webkit.org/b/111993 accessibility/button-press-action.html [ Failure ]
webkit.org/b/111994 accessibility/canvas-accessibilitynodeobject.html [ Failure ]
webkit.org/b/111996 accessibility/canvas-fallback-content-2.html [ Failure ]
-webkit.org/b/111998 accessibility/canvas-fallback-content.html [ Failure ]
webkit.org/b/111999 accessibility/disabled-controls-not-focusable.html [ Failure ]
webkit.org/b/112000 accessibility/heading-level.html [ Failure ]
webkit.org/b/112001 accessibility/ignore-spacer-elements.html [ Failure ]
Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (146290 => 146291)
--- trunk/LayoutTests/platform/efl-wk2/TestExpectations 2013-03-20 01:58:51 UTC (rev 146290)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations 2013-03-20 02:08:09 UTC (rev 146291)
@@ -255,7 +255,6 @@
webkit.org/b/111993 accessibility/button-press-action.html [ Failure ]
webkit.org/b/111994 accessibility/canvas-accessibilitynodeobject.html [ Failure ]
webkit.org/b/111996 accessibility/canvas-fallback-content-2.html [ Failure ]
-webkit.org/b/111998 accessibility/canvas-fallback-content.html [ Failure ]
webkit.org/b/111999 accessibility/disabled-controls-not-focusable.html [ Failure ]
webkit.org/b/112000 accessibility/heading-level.html [ Failure ]
webkit.org/b/112001 accessibility/ignore-spacer-elements.html [ Failure ]
Modified: trunk/Tools/ChangeLog (146290 => 146291)
--- trunk/Tools/ChangeLog 2013-03-20 01:58:51 UTC (rev 146290)
+++ trunk/Tools/ChangeLog 2013-03-20 02:08:09 UTC (rev 146291)
@@ -1,3 +1,19 @@
+2013-03-19 Krzysztof Czech <k.cz...@samsung.com>
+
+ [EFL] canvas-fallback-content.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=111998
+
+ Reviewed by Chris Fleizach.
+
+ Adds support for getting platform name.
+
+ * DumpRenderTree/TestRunner.cpp:
+ (TestRunner::staticValues):
+ * DumpRenderTree/TestRunner.h:
+ (TestRunner):
+ * DumpRenderTree/efl/TestRunnerEfl.cpp:
+ (TestRunner::platformName):
+
2013-03-19 Jochen Eisinger <joc...@chromium.org>
[chromium] move WebThemeEngine implementations to TestRunner library
Modified: trunk/Tools/DumpRenderTree/TestRunner.cpp (146290 => 146291)
--- trunk/Tools/DumpRenderTree/TestRunner.cpp 2013-03-20 01:58:51 UTC (rev 146290)
+++ trunk/Tools/DumpRenderTree/TestRunner.cpp 2013-03-20 02:08:09 UTC (rev 146291)
@@ -1817,7 +1817,7 @@
return JSValueMakeNumber(context, controller->webHistoryItemCount());
}
-#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN)
+#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN) || PLATFORM(EFL)
static JSValueRef getPlatformNameCallback(JSContextRef context, JSObjectRef thisObject, JSStringRef propertyName, JSValueRef* exception)
{
TestRunner* controller = static_cast<TestRunner*>(JSObjectGetPrivate(thisObject));
@@ -1992,7 +1992,7 @@
static JSStaticValue staticValues[] = {
{ "globalFlag", getGlobalFlagCallback, setGlobalFlagCallback, kJSPropertyAttributeNone },
{ "webHistoryItemCount", getWebHistoryItemCountCallback, 0, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
-#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN)
+#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN) || PLATFORM(EFL)
{ "platformName", getPlatformNameCallback, 0, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
#endif
{ "titleTextDirection", getTitleTextDirectionCallback, 0, kJSPropertyAttributeReadOnly | kJSPropertyAttributeDontDelete },
Modified: trunk/Tools/DumpRenderTree/TestRunner.h (146290 => 146291)
--- trunk/Tools/DumpRenderTree/TestRunner.h 2013-03-20 01:58:51 UTC (rev 146290)
+++ trunk/Tools/DumpRenderTree/TestRunner.h 2013-03-20 02:08:09 UTC (rev 146291)
@@ -120,7 +120,7 @@
size_t webHistoryItemCount();
int windowCount();
-#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN)
+#if PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN) || PLATFORM(EFL)
JSRetainPtr<JSStringRef> platformName() const;
#endif
Modified: trunk/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp (146290 => 146291)
--- trunk/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp 2013-03-20 01:58:51 UTC (rev 146290)
+++ trunk/Tools/DumpRenderTree/efl/TestRunnerEfl.cpp 2013-03-20 02:08:09 UTC (rev 146291)
@@ -838,3 +838,9 @@
{
notImplemented();
}
+
+JSRetainPtr<JSStringRef> TestRunner::platformName() const
+{
+ JSRetainPtr<JSStringRef> platformName(Adopt, JSStringCreateWithUTF8CString("efl"));
+ return platformName;
+}
