Title: [146212] trunk/Source/WebKit/chromium
- Revision
- 146212
- Author
- commit-qu...@webkit.org
- Date
- 2013-03-19 09:20:55 -0700 (Tue, 19 Mar 2013)
Log Message
Web Inspector: Remove flaky part of testRendererProcessNativeMemorySize test.
https://bugs.webkit.org/show_bug.cgi?id=112703
Patch by Alexei Filippov <a...@chromium.org> on 2013-03-19
Reviewed by Yury Semikhatsky.
The memory increase size check happened to be flaky. Remove it.
* src/js/Tests.js:
(.TestSuite.prototype.testRendererProcessNativeMemorySize.step1):
(.TestSuite.prototype.testRendererProcessNativeMemorySize):
Modified Paths
Diff
Modified: trunk/Source/WebKit/chromium/ChangeLog (146211 => 146212)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-03-19 16:17:58 UTC (rev 146211)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-03-19 16:20:55 UTC (rev 146212)
@@ -1,3 +1,16 @@
+2013-03-19 Alexei Filippov <a...@chromium.org>
+
+ Web Inspector: Remove flaky part of testRendererProcessNativeMemorySize test.
+ https://bugs.webkit.org/show_bug.cgi?id=112703
+
+ Reviewed by Yury Semikhatsky.
+
+ The memory increase size check happened to be flaky. Remove it.
+
+ * src/js/Tests.js:
+ (.TestSuite.prototype.testRendererProcessNativeMemorySize.step1):
+ (.TestSuite.prototype.testRendererProcessNativeMemorySize):
+
2013-03-18 W. James MacLean <wjmacl...@chromium.org>
[chromium] Remove NCCH code that relies on boundsContainsPageScale().
Modified: trunk/Source/WebKit/chromium/src/js/Tests.js (146211 => 146212)
--- trunk/Source/WebKit/chromium/src/js/Tests.js 2013-03-19 16:17:58 UTC (rev 146211)
+++ trunk/Source/WebKit/chromium/src/js/Tests.js 2013-03-19 16:20:55 UTC (rev 146212)
@@ -314,36 +314,12 @@
var test = this;
var KB = 1024;
var MB = KB * KB;
- var arraySize = 20000000;
- var initialSize;
- function checkFuzzyValue(value, expected, allowedDelta)
- {
- var relativeDiff = Math.abs(value - expected) / expected;
- if (relativeDiff > allowedDelta)
- test.fail("Value (" + value + ") differs from expected (" + expected + ") by more than " + (allowedDelta * 100) + "%.");
- }
-
function step1(error, memoryBlock)
{
test.assertTrue(!error, "An error has occurred: " + error);
test.assertTrue(memoryBlock.size > 1 * MB && memoryBlock.size < 1500 * MB, "Unfeasible process size: " + memoryBlock.size + " bytes.");
- initialSize = memoryBlock.size;
-
- test.evaluateInConsole_("var a = new Uint8Array(" + arraySize + ");", function() {});
-
- MemoryAgent.getProcessMemoryDistribution(false, step2);
- }
-
- function step2(error, memoryBlock)
- {
- test.assertTrue(!error, "An error has occurred: " + error);
- var deltaBytes = memoryBlock.size - initialSize;
- // Checks that the process size has grown approximately by
- // the size of the allocated array (within 10% confidence interval).
- checkFuzzyValue(deltaBytes, arraySize, 0.1);
-
test.releaseControl();
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
