Diff
Modified: trunk/LayoutTests/ChangeLog (145969 => 145970)
--- trunk/LayoutTests/ChangeLog 2013-03-16 00:37:35 UTC (rev 145969)
+++ trunk/LayoutTests/ChangeLog 2013-03-16 00:43:24 UTC (rev 145970)
@@ -1,3 +1,26 @@
+2013-03-15 Dana Jansens <dan...@chromium.org>
+
+ [chromium] Remove the background filter blur layout tests
+ https://bugs.webkit.org/show_bug.cgi?id=112372
+
+ Reviewed by James Robinson.
+
+ Given that we now have the ability to write pixel tests directly against
+ the compositor, these tests are no longer needed to guard against
+ regressions, and have been duplicated for the compositor as pixel tests
+ in https://codereview.chromium.org/12518026/ and
+ https://codereview.chromium.org/12518026/.
+
+ * platform/chromium/compositing/filters/background-filter-blur-expected.png: Removed.
+ * platform/chromium/compositing/filters/background-filter-blur-expected.txt: Removed.
+ * platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png: Removed.
+ * platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.txt: Removed.
+ * platform/chromium/compositing/filters/background-filter-blur-off-axis.html: Removed.
+ * platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png: Removed.
+ * platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt: Removed.
+ * platform/chromium/compositing/filters/background-filter-blur-outsets.html: Removed.
+ * platform/chromium/compositing/filters/background-filter-blur.html: Removed.
+
2013-03-15 Simon Fraser <simon.fra...@apple.com>
Mark fast/frames/sandboxed-iframe-scripting as flakey.
Deleted: trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur-expected.txt (145969 => 145970)
--- trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur-expected.txt 2013-03-16 00:37:35 UTC (rev 145969)
+++ trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur-expected.txt 2013-03-16 00:43:24 UTC (rev 145970)
@@ -1 +0,0 @@
-
Deleted: trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.txt (145969 => 145970)
--- trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.txt 2013-03-16 00:37:35 UTC (rev 145969)
+++ trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur-off-axis-expected.txt 2013-03-16 00:43:24 UTC (rev 145970)
@@ -1 +0,0 @@
-
Deleted: trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur-off-axis.html (145969 => 145970)
--- trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur-off-axis.html 2013-03-16 00:37:35 UTC (rev 145969)
+++ trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur-off-axis.html 2013-03-16 00:43:24 UTC (rev 145970)
@@ -1,42 +0,0 @@
-<!DOCTYPE html>
-<html><head>
-<title>Background filter blur test.</title>
-<style type="text/css">
- .composited {
- -webkit-transform: translateZ(0);
- }
- .green {
- background-color: green;
- }
- body {
- -webkit-perspective: 200px;
- }
- #blur {
- -webkit-transform-style: preserve-3d;
- -webkit-transform: rotateZ(-15deg) rotateY(90deg) rotateX(45deg) translate(70px, 60px);
- }
-</style>
-<script type="text/_javascript_">
- function setBlur() {
- testRunner.display(); // Force compositor to start.
- var blurNode = window.document.getElementById('blur');
- window.internals.setBackgroundBlurOnNode(blurNode, 2);
- }
-
- if (window.testRunner) {
- testRunner.dumpAsText(true);
- if (window.internals)
- window._onload_ = setBlur;
- }
-</script>
-</head>
-
-<body>
-<!--
- This verifies that the perspective of the clear layer (with black border) does not influence the blending of the
- green box behind it. Also verifies that the blur is correctly clipped inside the transformed clear layer.
--->
-<div id="object" class="composited green" style="position:absolute; left:50px; top:50px; width:200px; height:200px;"></div>
-<div id="blur" style="position:absolute; left:30px; top:30px; width:240px; height:240px; border:1px solid black;"></div>
-</body>
-</html>
Deleted: trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.png
(Binary files differ)
Deleted: trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt (145969 => 145970)
--- trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt 2013-03-16 00:37:35 UTC (rev 145969)
+++ trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur-outsets-expected.txt 2013-03-16 00:43:24 UTC (rev 145970)
@@ -1 +0,0 @@
-
Deleted: trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur-outsets.html (145969 => 145970)
--- trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur-outsets.html 2013-03-16 00:37:35 UTC (rev 145969)
+++ trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur-outsets.html 2013-03-16 00:43:24 UTC (rev 145970)
@@ -1,35 +0,0 @@
-<!DOCTYPE html>
-<html><head>
-<title>Background filter blur outsets test.</title>
-<style type="text/css">
- .composited {
- -webkit-transform: translateZ(0);
- }
- .green-border {
- border: 10px solid green;
- }
-</style>
-<script type="text/_javascript_">
- function setBlur() {
- testRunner.display(); // Force compositor to start.
- var blurNode = window.document.getElementById('blur');
- window.internals.setBackgroundBlurOnNode(blurNode, 5);
- }
-
- if (window.testRunner) {
- testRunner.dumpAsText(true);
- if (window.internals)
- window._onload_ = setBlur;
- }
-</script>
-</head>
-<body>
-<!--
- The green border is outside the layer with background blur, but the background blur should use pixels from outside
- its layer borders, up to the radius of the blur effect. So the border should be blurred underneath the top layer
- causing the inside of the border to be blurred.
- -->
-<div class="composited green-border" style="position:absolute; left:50px; top:50px; width:200px; height:200px;"></div>
-<div id="blur" style="position:absolute; left:59px; top:59px; width:200px; height:200px; border:1px solid black;"></div>
-</body>
-</html>
Deleted: trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur.html (145969 => 145970)
--- trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur.html 2013-03-16 00:37:35 UTC (rev 145969)
+++ trunk/LayoutTests/platform/chromium/compositing/filters/background-filter-blur.html 2013-03-16 00:43:24 UTC (rev 145970)
@@ -1,34 +0,0 @@
-<!DOCTYPE html>
-<html><head>
-<title>Background filter blur test.</title>
-<style type="text/css">
- .composited {
- -webkit-transform: translateZ(0);
- }
- .green {
- background-color: green;
- }
-</style>
-<script type="text/_javascript_">
- function setBlur() {
- testRunner.display(); // Force compositor to start.
- var blurNode = window.document.getElementById('blur');
- window.internals.setBackgroundBlurOnNode(blurNode, 2);
- }
-
- if (window.testRunner) {
- testRunner.dumpAsText(true);
- if (window.internals)
- window._onload_ = setBlur;
- }
-</script>
-</head>
-
-<body>
-<!--
- The green box is entirely behind a layer with background blur, so it should appear blurred on its edges.
- -->
-<div class="composited green" style="position:absolute; left:50px; top:50px; width:200px; height:200px;"></div>
-<div id="blur" style="position:absolute; left:30px; top:30px; width:240px; height:240px; border:1px solid white;"></div>
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (145969 => 145970)
--- trunk/Source/WebCore/ChangeLog 2013-03-16 00:37:35 UTC (rev 145969)
+++ trunk/Source/WebCore/ChangeLog 2013-03-16 00:43:24 UTC (rev 145970)
@@ -1,3 +1,18 @@
+2013-03-15 Dana Jansens <dan...@chromium.org>
+
+ [chromium] Remove the background filter blur layout tests
+ https://bugs.webkit.org/show_bug.cgi?id=112372
+
+ Reviewed by James Robinson.
+
+ Remove the now-unused hacks to regression test the background
+ filter blur compositor feature.
+
+ * testing/Internals.cpp:
+ * testing/Internals.h:
+ (Internals):
+ * testing/Internals.idl:
+
2013-03-15 Alexey Proskuryakov <a...@apple.com>
Reduce amount of platform specific code in MessagePortChannel
Modified: trunk/Source/WebCore/testing/Internals.cpp (145969 => 145970)
--- trunk/Source/WebCore/testing/Internals.cpp 2013-03-16 00:37:35 UTC (rev 145969)
+++ trunk/Source/WebCore/testing/Internals.cpp 2013-03-16 00:43:24 UTC (rev 145970)
@@ -932,42 +932,6 @@
#endif
}
-#if PLATFORM(CHROMIUM)
-void Internals::setBackgroundBlurOnNode(Node* node, int blurLength, ExceptionCode& ec)
-{
- if (!node) {
- ec = INVALID_ACCESS_ERR;
- return;
- }
-
- RenderObject* renderObject = node->renderer();
- if (!renderObject) {
- ec = INVALID_NODE_TYPE_ERR;
- return;
- }
-
- RenderLayer* renderLayer = renderObject->enclosingLayer();
- if (!renderLayer || !renderLayer->isComposited()) {
- ec = INVALID_STATE_ERR;
- return;
- }
-
- GraphicsLayer* graphicsLayer = renderLayer->backing()->graphicsLayer();
- if (!graphicsLayer) {
- ec = INVALID_NODE_TYPE_ERR;
- return;
- }
-
- FilterOperations filters;
- filters.operations().append(BlurFilterOperation::create(Length(blurLength, Fixed), FilterOperation::BLUR));
- static_cast<GraphicsLayerChromium*>(graphicsLayer)->setBackgroundFilters(filters);
-}
-#else
-void Internals::setBackgroundBlurOnNode(Node*, int, ExceptionCode&)
-{
-}
-#endif
-
unsigned Internals::markerCountForNode(Node* node, const String& markerType, ExceptionCode& ec)
{
if (!node) {
Modified: trunk/Source/WebCore/testing/Internals.h (145969 => 145970)
--- trunk/Source/WebCore/testing/Internals.h 2013-03-16 00:37:35 UTC (rev 145969)
+++ trunk/Source/WebCore/testing/Internals.h 2013-03-16 00:43:24 UTC (rev 145970)
@@ -145,8 +145,6 @@
PassRefPtr<ClientRectList> inspectorHighlightRects(Document*, ExceptionCode&);
- void setBackgroundBlurOnNode(Node*, int blurLength, ExceptionCode&);
-
unsigned markerCountForNode(Node*, const String&, ExceptionCode&);
PassRefPtr<Range> markerRangeForNode(Node*, const String& markerType, unsigned index, ExceptionCode&);
String markerDescriptionForNode(Node*, const String& markerType, unsigned index, ExceptionCode&);
Modified: trunk/Source/WebCore/testing/Internals.idl (145969 => 145970)
--- trunk/Source/WebCore/testing/Internals.idl 2013-03-16 00:37:35 UTC (rev 145969)
+++ trunk/Source/WebCore/testing/Internals.idl 2013-03-16 00:43:24 UTC (rev 145970)
@@ -104,8 +104,6 @@
ClientRectList inspectorHighlightRects(in Document document) raises (DOMException);
- void setBackgroundBlurOnNode(in Node node, in long blurLength) raises(DOMException);
-
unsigned long markerCountForNode(in Node node, in DOMString markerType) raises(DOMException);
Range markerRangeForNode(in Node node, in DOMString markerType, in unsigned long index) raises(DOMException);
DOMString markerDescriptionForNode(in Node node, in DOMString markerType, in unsigned long index) raises(DOMException);
