- Revision
- 144988
- Author
- [email protected]
- Date
- 2013-03-06 14:56:30 -0800 (Wed, 06 Mar 2013)
Log Message
Source/WebCore: Modify log method in V8DOMActivityLogger so that the apiName and
extraInfo arguments are of type const String& instead of const char*.
This change gets rid of some of the memory ownership issues that arise
with char* pointers.
https://bugs.webkit.org/show_bug.cgi?id=111483
Patch by Ankur Taly <[email protected]> on 2013-03-06
Reviewed by Adam Barth.
There are no new tests as there is no change in behavior.
* bindings/v8/V8DOMActivityLogger.h:
(WebCore::V8DOMActivityLogger::log):
Source/WebKit/chromium: Modify log method in WebDOMActivityLogger so that the apiName and
extraInfo arguments are of type const WebString& instead of const char*.
This change gets rid of some of the memory ownership issues that arise
with char* pointers.
https://bugs.webkit.org/show_bug.cgi?id=111483
Patch by Ankur Taly <[email protected]> on 2013-03-06
Reviewed by Adam Barth.
There are no new tests as there is no change in behavior.
* public/WebDOMActivityLogger.h: Added property svn:eol-style.
(WebKit::WebDOMActivityLogger::log):
* src/WebDOMActivityLogger.cpp: Added property svn:eol-style.
(WebKit::DOMActivityLoggerContainer::log):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (144987 => 144988)
--- trunk/Source/WebCore/ChangeLog 2013-03-06 22:55:28 UTC (rev 144987)
+++ trunk/Source/WebCore/ChangeLog 2013-03-06 22:56:30 UTC (rev 144988)
@@ -1,3 +1,18 @@
+2013-03-06 Ankur Taly <[email protected]>
+
+ Modify log method in V8DOMActivityLogger so that the apiName and
+ extraInfo arguments are of type const String& instead of const char*.
+ This change gets rid of some of the memory ownership issues that arise
+ with char* pointers.
+ https://bugs.webkit.org/show_bug.cgi?id=111483
+
+ Reviewed by Adam Barth.
+
+ There are no new tests as there is no change in behavior.
+
+ * bindings/v8/V8DOMActivityLogger.h:
+ (WebCore::V8DOMActivityLogger::log):
+
2013-03-06 Mike Reed <[email protected]>
Use SkTypeface API directly, rather than (soon to be private) SkFontHost
Modified: trunk/Source/WebCore/bindings/v8/V8DOMActivityLogger.h (144987 => 144988)
--- trunk/Source/WebCore/bindings/v8/V8DOMActivityLogger.h 2013-03-06 22:55:28 UTC (rev 144987)
+++ trunk/Source/WebCore/bindings/v8/V8DOMActivityLogger.h 2013-03-06 22:56:30 UTC (rev 144988)
@@ -31,7 +31,8 @@
#ifndef V8DOMActivityLogger_h
#define V8DOMActivityLogger_h
-#include "v8.h"
+#include <v8.h>
+#include <wtf/text/WTFString.h>
namespace WebCore {
@@ -39,7 +40,7 @@
public:
virtual ~V8DOMActivityLogger() { }
- virtual void log(const char* apiName, int argc, const v8::Handle<v8::Value>* argv, const char* extraInfo) { }
+ virtual void log(const String& apiName, int argc, const v8::Handle<v8::Value>* argv, const String& extraInfo) { }
};
} // namespace WebCore
Modified: trunk/Source/WebKit/chromium/ChangeLog (144987 => 144988)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-03-06 22:55:28 UTC (rev 144987)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-03-06 22:56:30 UTC (rev 144988)
@@ -1,3 +1,20 @@
+2013-03-06 Ankur Taly <[email protected]>
+
+ Modify log method in WebDOMActivityLogger so that the apiName and
+ extraInfo arguments are of type const WebString& instead of const char*.
+ This change gets rid of some of the memory ownership issues that arise
+ with char* pointers.
+ https://bugs.webkit.org/show_bug.cgi?id=111483
+
+ Reviewed by Adam Barth.
+
+ There are no new tests as there is no change in behavior.
+
+ * public/WebDOMActivityLogger.h: Added property svn:eol-style.
+ (WebKit::WebDOMActivityLogger::log):
+ * src/WebDOMActivityLogger.cpp: Added property svn:eol-style.
+ (WebKit::DOMActivityLoggerContainer::log):
+
2013-03-06 Sheriff Bot <[email protected]>
Unreviewed. Rolled Chromium DEPS to r186511. Requested by
Modified: trunk/Source/WebKit/chromium/public/WebDOMActivityLogger.h (144987 => 144988)
--- trunk/Source/WebKit/chromium/public/WebDOMActivityLogger.h 2013-03-06 22:55:28 UTC (rev 144987)
+++ trunk/Source/WebKit/chromium/public/WebDOMActivityLogger.h 2013-03-06 22:56:30 UTC (rev 144988)
@@ -32,6 +32,7 @@
#define WebDOMActivityLogger_h
#include "../../../Platform/chromium/public/WebCommon.h"
+#include "../../../Platform/chromium/public/WebString.h"
#include <v8.h>
namespace WebKit {
@@ -39,7 +40,7 @@
class WebDOMActivityLogger {
public:
virtual ~WebDOMActivityLogger() { }
- virtual void log(const char* apiName, int argc, const v8::Handle<v8::Value>* argv, const char* extraInfo) { }
+ virtual void log(const WebString& apiName, int argc, const v8::Handle<v8::Value>* argv, const WebString& extraInfo) { }
};
// Checks if a logger already exists for the world identified
Modified: trunk/Source/WebKit/chromium/src/WebDOMActivityLogger.cpp (144987 => 144988)
--- trunk/Source/WebKit/chromium/src/WebDOMActivityLogger.cpp 2013-03-06 22:55:28 UTC (rev 144987)
+++ trunk/Source/WebKit/chromium/src/WebDOMActivityLogger.cpp 2013-03-06 22:56:30 UTC (rev 144988)
@@ -34,6 +34,7 @@
#include "DOMWrapperWorld.h"
#include "V8DOMActivityLogger.h"
#include <wtf/PassRefPtr.h>
+#include <wtf/text/WTFString.h>
using namespace WebCore;
@@ -46,9 +47,9 @@
{
}
- virtual void log(const char* apiName, int argc, const v8::Handle<v8::Value>* argv, const char* extraInfo)
+ virtual void log(const String& apiName, int argc, const v8::Handle<v8::Value>* argv, const String& extraInfo)
{
- m_domActivityLogger->log(apiName, argc, argv, extraInfo);
+ m_domActivityLogger->log(WebString(apiName), argc, argv, WebString(extraInfo));
}
private:
