Title: [144977] trunk/Source/WebKit/blackberry
- Revision
- 144977
- Author
- nghanavat...@rim.com
- Date
- 2013-03-06 14:12:27 -0800 (Wed, 06 Mar 2013)
Log Message
[BlackBerry] Selection handles don't drag to expand correctly for RTL languages
https://bugs.webkit.org/show_bug.cgi?id=111618
Reviewed by Rob Buis.
PR 303712
If we are using a RTL language, we should ensure that the selection handles are angled the right way.
Further, when expanding the selection, the start and end handles should be appropriately set so that
expansion in the natural direction is possible.
Internally reviewed by Mike Fenton.
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::SelectionHandler):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
* WebKitSupport/SelectionHandler.h:
(SelectionHandler):
Modified Paths
Diff
Modified: trunk/Source/WebKit/blackberry/ChangeLog (144976 => 144977)
--- trunk/Source/WebKit/blackberry/ChangeLog 2013-03-06 21:38:19 UTC (rev 144976)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2013-03-06 22:12:27 UTC (rev 144977)
@@ -1,3 +1,23 @@
+2013-03-06 Nima Ghanavatian <nghanavat...@rim.com>
+
+ [BlackBerry] Selection handles don't drag to expand correctly for RTL languages
+ https://bugs.webkit.org/show_bug.cgi?id=111618
+
+ Reviewed by Rob Buis.
+
+ PR 303712
+ If we are using a RTL language, we should ensure that the selection handles are angled the right way.
+ Further, when expanding the selection, the start and end handles should be appropriately set so that
+ expansion in the natural direction is possible.
+
+ Internally reviewed by Mike Fenton.
+
+ * WebKitSupport/SelectionHandler.cpp:
+ (BlackBerry::WebKit::SelectionHandler::SelectionHandler):
+ (BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
+ * WebKitSupport/SelectionHandler.h:
+ (SelectionHandler):
+
2013-03-06 Carlos Garcia Campos <cgar...@igalia.com>
[BlackBerry] Use the new authenticationChallenge API in WebPage
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp (144976 => 144977)
--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2013-03-06 21:38:19 UTC (rev 144976)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2013-03-06 22:12:27 UTC (rev 144977)
@@ -1205,7 +1205,7 @@
}
}
- if (!frame->selection()->selection().isBaseFirst() || isRTL ) {
+ if (!frame->selection()->selection().isBaseFirst()) {
// End handle comes before start, invert the caret reference points.
WebCore::IntRect tmpCaret(startCaret);
startCaret = endCaret;
@@ -1220,10 +1220,9 @@
if (m_webPage->m_selectionOverlay)
m_webPage->m_selectionOverlay->draw(visibleSelectionRegion);
-
VisibleSelection currentSelection = frame->selection()->selection();
SelectionDetails details(startCaret, endCaret, visibleSelectionRegion, inputNodeOverridesTouch(),
- m_lastSelection != currentSelection, requestedSelectionHandlePosition(frame->selection()->selection()));
+ m_lastSelection != currentSelection, requestedSelectionHandlePosition(frame->selection()->selection()), isRTL);
m_webPage->m_client->notifySelectionDetailsChanged(details);
m_lastSelection = currentSelection;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
