Title: [144789] trunk
- Revision
- 144789
- Author
- scher...@chromium.org
- Date
- 2013-03-05 11:37:18 -0800 (Tue, 05 Mar 2013)
Log Message
REGRESSION(r142191): Fix closed caption buttons for ports still using the painting path.
https://bugs.webkit.org/show_bug.cgi?id=111109
Reviewed by Eric Carlson.
Source/WebCore:
Covered by following tests:
media/track/track-cue-rendering-horizontal.html
media/track/track-cue-rendering-vertical.html
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
* rendering/RenderTheme.h:
(WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton):
LayoutTests:
* platform/chromium/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (144788 => 144789)
--- trunk/LayoutTests/ChangeLog 2013-03-05 19:17:19 UTC (rev 144788)
+++ trunk/LayoutTests/ChangeLog 2013-03-05 19:37:18 UTC (rev 144789)
@@ -1,3 +1,12 @@
+2013-03-04 Andrew Scherkus <scher...@chromium.org>
+
+ REGRESSION(r142191): Fix closed caption buttons for ports still using the painting path.
+ https://bugs.webkit.org/show_bug.cgi?id=111109
+
+ Reviewed by Eric Carlson.
+
+ * platform/chromium/TestExpectations:
+
2013-03-05 Bem Jones-Bey <bjone...@adobe.com>
[CSS Exclusions] shape-outside on floats for polygon shapes
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (144788 => 144789)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2013-03-05 19:17:19 UTC (rev 144788)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-03-05 19:37:18 UTC (rev 144789)
@@ -4413,3 +4413,7 @@
# These test are failing since r144519
webkit.org/b/109769 [ Mac ] fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html [ Failure ]
webkit.org/b/109769 [ Mac ] fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html [ Failure ]
+
+# Current baselines are incorrect -- needs rebaseline after webkit.org/b/111388 lands.
+webkit.org/b/111388 media/track/track-cue-rendering-horizontal.html [ ImageOnlyFailure ]
+webkit.org/b/111388 media/track/track-cue-rendering-vertical.html [ ImageOnlyFailure ]
Modified: trunk/Source/WebCore/ChangeLog (144788 => 144789)
--- trunk/Source/WebCore/ChangeLog 2013-03-05 19:17:19 UTC (rev 144788)
+++ trunk/Source/WebCore/ChangeLog 2013-03-05 19:37:18 UTC (rev 144789)
@@ -1,3 +1,19 @@
+2013-03-04 Andrew Scherkus <scher...@chromium.org>
+
+ REGRESSION(r142191): Fix closed caption buttons for ports still using the painting path.
+ https://bugs.webkit.org/show_bug.cgi?id=111109
+
+ Reviewed by Eric Carlson.
+
+ Covered by following tests:
+ media/track/track-cue-rendering-horizontal.html
+ media/track/track-cue-rendering-vertical.html
+
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::paint):
+ * rendering/RenderTheme.h:
+ (WebCore::RenderTheme::paintMediaToggleClosedCaptionsButton):
+
2013-03-05 Gwang Yoon Hwang <ryum...@company100.net>
Coordinated Graphics: CoordinatedGraphicsLayer makes CoordinatedGraphicsScene perform via CoordinatedGraphicsState.
Modified: trunk/Source/WebCore/rendering/RenderTheme.cpp (144788 => 144789)
--- trunk/Source/WebCore/rendering/RenderTheme.cpp 2013-03-05 19:17:19 UTC (rev 144788)
+++ trunk/Source/WebCore/rendering/RenderTheme.cpp 2013-03-05 19:37:18 UTC (rev 144789)
@@ -341,6 +341,8 @@
return paintMediaRewindButton(o, paintInfo, r);
case MediaReturnToRealtimeButtonPart:
return paintMediaReturnToRealtimeButton(o, paintInfo, r);
+ case MediaToggleClosedCaptionsButtonPart:
+ return paintMediaToggleClosedCaptionsButton(o, paintInfo, r);
case MediaSliderPart:
return paintMediaSliderTrack(o, paintInfo, r);
case MediaSliderThumbPart:
Modified: trunk/Source/WebCore/rendering/RenderTheme.h (144788 => 144789)
--- trunk/Source/WebCore/rendering/RenderTheme.h 2013-03-05 19:17:19 UTC (rev 144788)
+++ trunk/Source/WebCore/rendering/RenderTheme.h 2013-03-05 19:37:18 UTC (rev 144789)
@@ -338,6 +338,7 @@
virtual bool paintMediaVolumeSliderThumb(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
virtual bool paintMediaRewindButton(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
virtual bool paintMediaReturnToRealtimeButton(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
+ virtual bool paintMediaToggleClosedCaptionsButton(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
virtual bool paintMediaControlsBackground(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
virtual bool paintMediaCurrentTime(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
virtual bool paintMediaTimeRemaining(RenderObject*, const PaintInfo&, const IntRect&) { return true; }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
