Diff
Modified: trunk/Source/WebCore/ChangeLog (144648 => 144649)
--- trunk/Source/WebCore/ChangeLog 2013-03-04 19:01:56 UTC (rev 144648)
+++ trunk/Source/WebCore/ChangeLog 2013-03-04 19:04:27 UTC (rev 144649)
@@ -1,3 +1,14 @@
+2013-03-04 Tony Chang <t...@chromium.org>
+
+ Unreviewed, rolling out r144562.
+ http://trac.webkit.org/changeset/144562
+ https://bugs.webkit.org/show_bug.cgi?id=85642
+
+ Caused KeyPadInsert faluires in webkit_unittests
+
+ * platform/chromium/KeyCodeConversionGtk.cpp:
+ (WebCore::windowsKeyCodeForKeyEvent):
+
2013-03-04 Uday Kiran <udayki...@motorola.com>
getComputedStyle not implemented for -webkit-columns shorthand
Modified: trunk/Source/WebCore/platform/chromium/KeyCodeConversionGtk.cpp (144648 => 144649)
--- trunk/Source/WebCore/platform/chromium/KeyCodeConversionGtk.cpp 2013-03-04 19:01:56 UTC (rev 144648)
+++ trunk/Source/WebCore/platform/chromium/KeyCodeConversionGtk.cpp 2013-03-04 19:04:27 UTC (rev 144649)
@@ -88,12 +88,6 @@
return VKEY_RIGHT; // (27) RIGHT ARROW key
case GDK_KP_Down:
return VKEY_DOWN; // (28) DOWN ARROW key
- case GDK_KP_Begin:
- return VKEY_CLEAR; // (12) CLEAR key
- case GDK_KP_Insert:
- return VKEY_INSERT; // (45) INS key
- case GDK_KP_Delete:
- return VKEY_DELETE; // (46) DEL key
case GDK_BackSpace:
return VKEY_BACK; // (08) BACKSPACE key
@@ -120,7 +114,6 @@
case GDK_Alt_L:
return VKEY_LMENU; // (A4) Left ALT key
case GDK_Alt_R:
- case GDK_ISO_Level3_Shift:
return VKEY_RMENU; // (A5) Right ALT key
case GDK_Pause:
Modified: trunk/Source/WebKit/chromium/ChangeLog (144648 => 144649)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-03-04 19:01:56 UTC (rev 144648)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-03-04 19:04:27 UTC (rev 144649)
@@ -1,3 +1,14 @@
+2013-03-04 Tony Chang <t...@chromium.org>
+
+ Unreviewed, rolling out r144562.
+ http://trac.webkit.org/changeset/144562
+ https://bugs.webkit.org/show_bug.cgi?id=85642
+
+ Caused KeyPadInsert faluires in webkit_unittests
+
+ * WebKit.gypi:
+ * tests/KeyCodeConversionTestGtk.cpp: Removed.
+
2013-03-04 Levi Weintraub <le...@chromium.org>
Add support for 8 bit TextRuns on Chromium Linux & Mac
Modified: trunk/Source/WebKit/chromium/WebKit.gypi (144648 => 144649)
--- trunk/Source/WebKit/chromium/WebKit.gypi 2013-03-04 19:01:56 UTC (rev 144648)
+++ trunk/Source/WebKit/chromium/WebKit.gypi 2013-03-04 19:04:27 UTC (rev 144649)
@@ -159,7 +159,6 @@
}],
['toolkit_uses_gtk == 1', {
'webkit_unittest_files': [
- 'tests/KeyCodeConversionTestGtk.cpp',
'tests/WebInputEventFactoryTestGtk.cpp',
],
}],
Deleted: trunk/Source/WebKit/chromium/tests/KeyCodeConversionTestGtk.cpp (144648 => 144649)
--- trunk/Source/WebKit/chromium/tests/KeyCodeConversionTestGtk.cpp 2013-03-04 19:01:56 UTC (rev 144648)
+++ trunk/Source/WebKit/chromium/tests/KeyCodeConversionTestGtk.cpp 2013-03-04 19:04:27 UTC (rev 144649)
@@ -1,66 +0,0 @@
-/*
- * Copyright (C) 2013 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-
-#include "KeyCodeConversion.h"
-
-#include "KeyboardCodes.h"
-#include <gdk/gdkkeysyms.h>
-#include <gtest/gtest.h>
-
-using namespace WebCore;
-
-namespace {
-
-TEST(KeyCodeConversionTest, KeyPadClear)
-{
- EXPECT_EQ(VKEY_CLEAR, windowsKeyCodeForKeyEvent(GDK_KP_Begin));
-}
-
-TEST(KeyCodeConversionTest, KeyPadInsert)
-{
- EXPECT_EQ(windowsKeyCodeForKeyEvent(GDK_Insert),
- windowsKeyCodeForKeyEvent(GDK_KP_Begin));
-}
-
-TEST(KeyCodeConversionTest, KeyPadDelete)
-{
- EXPECT_EQ(windowsKeyCodeForKeyEvent(GDK_Delete),
- windowsKeyCodeForKeyEvent(GDK_KP_Delete));
-}
-
-TEST(KeyCodeConversionTest, AltGr)
-{
- EXPECT_EQ(windowsKeyCodeForKeyEvent(GDK_Alt_R),
- windowsKeyCodeForKeyEvent(GDK_ISO_Level3_Shift));
-}
-
-} // anonymous namespace
