Title: [144638] trunk/Source
- Revision
- 144638
- Author
- [email protected]
- Date
- 2013-03-04 09:24:42 -0800 (Mon, 04 Mar 2013)
Log Message
Remove unused return value from SourceBufferPrivate::abort() and WebSourceBuffer::abort().
https://bugs.webkit.org/show_bug.cgi?id=111195
Reviewed by Adam Barth.
Source/WebCore:
No new tests. No user visible behavior changed.
* platform/graphics/SourceBufferPrivate.h:
(SourceBufferPrivate):
Source/WebKit/chromium:
* public/WebSourceBuffer.h:
(WebSourceBuffer):
* src/SourceBufferPrivateImpl.cpp:
(WebKit::SourceBufferPrivateImpl::abort):
* src/SourceBufferPrivateImpl.h:
(SourceBufferPrivateImpl):
* src/WebMediaPlayerClientImpl.cpp:
(WebSourceBufferImpl):
(WebKit::WebSourceBufferImpl::abort):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (144637 => 144638)
--- trunk/Source/WebCore/ChangeLog 2013-03-04 17:16:05 UTC (rev 144637)
+++ trunk/Source/WebCore/ChangeLog 2013-03-04 17:24:42 UTC (rev 144638)
@@ -1,3 +1,15 @@
+2013-03-04 Aaron Colwell <[email protected]>
+
+ Remove unused return value from SourceBufferPrivate::abort() and WebSourceBuffer::abort().
+ https://bugs.webkit.org/show_bug.cgi?id=111195
+
+ Reviewed by Adam Barth.
+
+ No new tests. No user visible behavior changed.
+
+ * platform/graphics/SourceBufferPrivate.h:
+ (SourceBufferPrivate):
+
2013-03-04 David Hyatt <[email protected]>
[New Multicolumn] Eliminate the unique multicolumn flow thread style creation function
Modified: trunk/Source/WebCore/platform/graphics/SourceBufferPrivate.h (144637 => 144638)
--- trunk/Source/WebCore/platform/graphics/SourceBufferPrivate.h 2013-03-04 17:16:05 UTC (rev 144637)
+++ trunk/Source/WebCore/platform/graphics/SourceBufferPrivate.h 2013-03-04 17:24:42 UTC (rev 144638)
@@ -43,7 +43,7 @@
virtual PassRefPtr<TimeRanges> buffered() = 0;
virtual void append(const unsigned char* data, unsigned length) = 0;
- virtual bool abort() = 0;
+ virtual void abort() = 0;
virtual bool setTimestampOffset(double) = 0;
virtual void removedFromMediaSource() = 0;
};
Modified: trunk/Source/WebKit/chromium/ChangeLog (144637 => 144638)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-03-04 17:16:05 UTC (rev 144637)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-03-04 17:24:42 UTC (rev 144638)
@@ -1,3 +1,20 @@
+2013-03-04 Aaron Colwell <[email protected]>
+
+ Remove unused return value from SourceBufferPrivate::abort() and WebSourceBuffer::abort().
+ https://bugs.webkit.org/show_bug.cgi?id=111195
+
+ Reviewed by Adam Barth.
+
+ * public/WebSourceBuffer.h:
+ (WebSourceBuffer):
+ * src/SourceBufferPrivateImpl.cpp:
+ (WebKit::SourceBufferPrivateImpl::abort):
+ * src/SourceBufferPrivateImpl.h:
+ (SourceBufferPrivateImpl):
+ * src/WebMediaPlayerClientImpl.cpp:
+ (WebSourceBufferImpl):
+ (WebKit::WebSourceBufferImpl::abort):
+
2013-03-04 Andrey Lushnikov <[email protected]>
Web Inspector: add Ace editor experiment
Modified: trunk/Source/WebKit/chromium/public/WebSourceBuffer.h (144637 => 144638)
--- trunk/Source/WebKit/chromium/public/WebSourceBuffer.h 2013-03-04 17:16:05 UTC (rev 144637)
+++ trunk/Source/WebKit/chromium/public/WebSourceBuffer.h 2013-03-04 17:24:42 UTC (rev 144638)
@@ -41,7 +41,7 @@
virtual WebTimeRanges buffered() = 0;
virtual void append(const unsigned char* data, unsigned length) = 0;
- virtual bool abort() = 0;
+ virtual void abort() = 0;
virtual bool setTimestampOffset(double) = 0;
virtual void removedFromMediaSource() = 0;
};
Modified: trunk/Source/WebKit/chromium/src/SourceBufferPrivateImpl.cpp (144637 => 144638)
--- trunk/Source/WebKit/chromium/src/SourceBufferPrivateImpl.cpp 2013-03-04 17:16:05 UTC (rev 144637)
+++ trunk/Source/WebKit/chromium/src/SourceBufferPrivateImpl.cpp 2013-03-04 17:24:42 UTC (rev 144638)
@@ -61,11 +61,11 @@
m_sourceBuffer->append(data, length);
}
-bool SourceBufferPrivateImpl::abort()
+void SourceBufferPrivateImpl::abort()
{
if (!m_sourceBuffer)
- return false;
- return m_sourceBuffer->abort();
+ return;
+ m_sourceBuffer->abort();
}
bool SourceBufferPrivateImpl::setTimestampOffset(double offset)
Modified: trunk/Source/WebKit/chromium/src/SourceBufferPrivateImpl.h (144637 => 144638)
--- trunk/Source/WebKit/chromium/src/SourceBufferPrivateImpl.h 2013-03-04 17:16:05 UTC (rev 144637)
+++ trunk/Source/WebKit/chromium/src/SourceBufferPrivateImpl.h 2013-03-04 17:24:42 UTC (rev 144638)
@@ -49,7 +49,7 @@
// SourceBufferPrivate methods.
virtual PassRefPtr<WebCore::TimeRanges> buffered();
virtual void append(const unsigned char* data, unsigned length);
- virtual bool abort();
+ virtual void abort();
virtual bool setTimestampOffset(double);
virtual void removedFromMediaSource();
Modified: trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp (144637 => 144638)
--- trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp 2013-03-04 17:16:05 UTC (rev 144637)
+++ trunk/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp 2013-03-04 17:24:42 UTC (rev 144638)
@@ -81,7 +81,7 @@
// WebSourceBuffer methods.
virtual WebTimeRanges buffered();
virtual void append(const unsigned char* data, unsigned length);
- virtual bool abort();
+ virtual void abort();
virtual bool setTimestampOffset(double);
virtual void removedFromMediaSource();
@@ -141,9 +141,9 @@
m_webMediaPlayer->sourceAppend(m_id, data, length);
}
-bool WebSourceBufferImpl::abort()
+void WebSourceBufferImpl::abort()
{
- return m_webMediaPlayer->sourceAbort(m_id);
+ m_webMediaPlayer->sourceAbort(m_id);
}
bool WebSourceBufferImpl::setTimestampOffset(double offset)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
