Title: [143794] trunk
- Revision
- 143794
- Author
- [email protected]
- Date
- 2013-02-22 14:12:47 -0800 (Fri, 22 Feb 2013)
Log Message
[chromium] enable the fixed version of freetype on linux
https://bugs.webkit.org/show_bug.cgi?id=110542
Reviewed by Tony Chang.
Tools:
Switch to building with a fixed version of FreeType for
just DumpRenderTree. This allows us to share one version
of pixel baselines for both Lucid and Precise, and run
the layout tests in a stock Precise install (instead of a Lucid
chroot). Going forward, this approach isolates us from os-level
changes to the version of FreeType. Note that Chromium itself
still uses the system FreeType and is unaffected by this change.
This setting can still be turned off (at compile/gyp-time) by
manually setting use_custom_freetype=0.
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
LayoutTests:
Add entries for two tests that pass on Lucid but fail on Precise
even with the Freetype change. This isn't worth adding in
Lucid and Precise keywords for just these two tests.
* platform/chromium/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (143793 => 143794)
--- trunk/LayoutTests/ChangeLog 2013-02-22 22:10:38 UTC (rev 143793)
+++ trunk/LayoutTests/ChangeLog 2013-02-22 22:12:47 UTC (rev 143794)
@@ -1,3 +1,16 @@
+2013-02-22 Dirk Pranke <[email protected]>
+
+ [chromium] enable the fixed version of freetype on linux
+ https://bugs.webkit.org/show_bug.cgi?id=110542
+
+ Reviewed by Tony Chang.
+
+ Add entries for two tests that pass on Lucid but fail on Precise
+ even with the Freetype change. This isn't worth adding in
+ Lucid and Precise keywords for just these two tests.
+
+ * platform/chromium/TestExpectations:
+
2013-02-22 Kenneth Russell <[email protected]>
Uint8ClampedArray constructor is wrong in WorkerContext.idl
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (143793 => 143794)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2013-02-22 22:10:38 UTC (rev 143793)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-02-22 22:12:47 UTC (rev 143794)
@@ -4416,3 +4416,7 @@
webkit.org/b/110568 [ MountainLion ] fast/multicol/newmulticol/positioned-split.html [ ImageOnlyFailure ]
+# These pass on Lucid and fail on Precise; font differences, maybe?
+# We can rebaseline them when we stop running on Lucid.
+webkit.org/b/110540 [ Linux ] platform/chromium-linux/fast/text/chromium-linux-fontconfig-renderstyle.html [ Failure Pass ]
+webkit.org/b/110540 [ Linux ] fast/text/international/thai-line-breaks.html [ ImageOnlyFailure Pass ]
Modified: trunk/Tools/ChangeLog (143793 => 143794)
--- trunk/Tools/ChangeLog 2013-02-22 22:10:38 UTC (rev 143793)
+++ trunk/Tools/ChangeLog 2013-02-22 22:12:47 UTC (rev 143794)
@@ -1,3 +1,23 @@
+2013-02-22 Dirk Pranke <[email protected]>
+
+ [chromium] enable the fixed version of freetype on linux
+ https://bugs.webkit.org/show_bug.cgi?id=110542
+
+ Reviewed by Tony Chang.
+
+ Switch to building with a fixed version of FreeType for
+ just DumpRenderTree. This allows us to share one version
+ of pixel baselines for both Lucid and Precise, and run
+ the layout tests in a stock Precise install (instead of a Lucid
+ chroot). Going forward, this approach isolates us from os-level
+ changes to the version of FreeType. Note that Chromium itself
+ still uses the system FreeType and is unaffected by this change.
+
+ This setting can still be turned off (at compile/gyp-time) by
+ manually setting use_custom_freetype=0.
+
+ * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
+
2013-02-22 Anders Carlsson <[email protected]>
Move pluginLoadPolicy to the page loader client
Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp (143793 => 143794)
--- trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2013-02-22 22:10:38 UTC (rev 143793)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp 2013-02-22 22:12:47 UTC (rev 143794)
@@ -45,9 +45,7 @@
'chromium_src_dir': '<(tools_dir)/../../..',
}],
['OS=="linux"', {
- # FIXME: This should be on by default.
- # See https://bugs.webkit.org/show_bug.cgi?id=107338
- 'use_custom_freetype%': 0,
+ 'use_custom_freetype%': 1,
}, {
'use_custom_freetype%': 0,
}],
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
