Title: [143764] trunk/Source/WebKit2
- Revision
- 143764
- Author
- jer.no...@apple.com
- Date
- 2013-02-22 11:48:02 -0800 (Fri, 22 Feb 2013)
Log Message
Two video contollers appear after exiting the fullscreen video when using menubar to exit.
https://bugs.webkit.org/show_bug.cgi?id=110506
Reviewed by Eric Carlson.
When we are notified that the fullscreen window is about to exit fullscreen mode unrequested,
call requestExitFullScreen(), as that will result in Document::webkitExitFullScreen() correctly
tearing down the fullscreen state.
* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (143763 => 143764)
--- trunk/Source/WebKit2/ChangeLog 2013-02-22 19:44:44 UTC (rev 143763)
+++ trunk/Source/WebKit2/ChangeLog 2013-02-22 19:48:02 UTC (rev 143764)
@@ -1,3 +1,17 @@
+2013-02-21 Jer Noble <jer.no...@apple.com>
+
+ Two video contollers appear after exiting the fullscreen video when using menubar to exit.
+ https://bugs.webkit.org/show_bug.cgi?id=110506
+
+ Reviewed by Eric Carlson.
+
+ When we are notified that the fullscreen window is about to exit fullscreen mode unrequested,
+ call requestExitFullScreen(), as that will result in Document::webkitExitFullScreen() correctly
+ tearing down the fullscreen state.
+
+ * UIProcess/mac/WKFullScreenWindowController.mm:
+ (-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):
+
2013-02-22 Balazs Kelemen <kbal...@webkit.org>
Yet another unreviewed buildfix after r143714.
Modified: trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm (143763 => 143764)
--- trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm 2013-02-22 19:44:44 UTC (rev 143763)
+++ trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm 2013-02-22 19:48:02 UTC (rev 143764)
@@ -577,6 +577,7 @@
if (_isFullScreen) {
// We still believe we're in full screen mode, so we must have been asked to exit full
// screen by the system full screen button.
+ [self _manager]->requestExitFullScreen();
[self exitFullScreen];
_isExitingFullScreen = YES;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes