Title: [143675] trunk/Source/WebKit2
Revision
143675
Author
commit-qu...@webkit.org
Date
2013-02-21 17:42:06 -0800 (Thu, 21 Feb 2013)

Log Message

QuickTime plugin doesn't load when accelerated compositing is disabled
https://bugs.webkit.org/show_bug.cgi?id=110534

Patch by Dima Gorbik <dgor...@apple.com> on 2013-02-21
Reviewed by Anders Carlsson.

We shouldn't disable accelerated compositing for plugins, because
plugins such as QuickTime rely on this and will try to set other drawing
models that we don't support.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::isAcceleratedCompositingEnabled):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (143674 => 143675)


--- trunk/Source/WebKit2/ChangeLog	2013-02-22 01:40:21 UTC (rev 143674)
+++ trunk/Source/WebKit2/ChangeLog	2013-02-22 01:42:06 UTC (rev 143675)
@@ -1,3 +1,17 @@
+2013-02-21  Dima Gorbik  <dgor...@apple.com>
+
+        QuickTime plugin doesn't load when accelerated compositing is disabled
+        https://bugs.webkit.org/show_bug.cgi?id=110534
+
+        Reviewed by Anders Carlsson.
+
+        We shouldn't disable accelerated compositing for plugins, because
+        plugins such as QuickTime rely on this and will try to set other drawing
+        models that we don't support.
+
+        * WebProcess/Plugins/PluginView.cpp:
+        (WebKit::PluginView::isAcceleratedCompositingEnabled):
+
 2013-02-21  Dean Jackson  <d...@apple.com>
 
         Plug-in snapshotting code always accepts first snapshot

Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp (143674 => 143675)


--- trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp	2013-02-22 01:40:21 UTC (rev 143674)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp	2013-02-22 01:42:06 UTC (rev 143675)
@@ -1346,8 +1346,6 @@
     if (!settings)
         return false;
 
-    if (m_pluginElement->displayState() < HTMLPlugInElement::PlayingWithPendingMouseClick)
-        return false;
     return settings->acceleratedCompositingEnabled();
 }
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to