Title: [143538] trunk/Source/WebCore
- Revision
- 143538
- Author
- alecfl...@chromium.org
- Date
- 2013-02-20 16:49:57 -0800 (Wed, 20 Feb 2013)
Log Message
LevelDB: Remove excess vector copy
https://bugs.webkit.org/show_bug.cgi?id=110399
Reviewed by Tony Chang.
Remove an extra copy introduced by the makeVector function.
No new tests, this is covered by existing tests.
* platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::safeGet):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (143537 => 143538)
--- trunk/Source/WebCore/ChangeLog 2013-02-21 00:48:45 UTC (rev 143537)
+++ trunk/Source/WebCore/ChangeLog 2013-02-21 00:49:57 UTC (rev 143538)
@@ -1,3 +1,17 @@
+2013-02-20 Alec Flett <alecfl...@chromium.org>
+
+ LevelDB: Remove excess vector copy
+ https://bugs.webkit.org/show_bug.cgi?id=110399
+
+ Reviewed by Tony Chang.
+
+ Remove an extra copy introduced by the makeVector function.
+
+ No new tests, this is covered by existing tests.
+
+ * platform/leveldb/LevelDBDatabase.cpp:
+ (WebCore::LevelDBDatabase::safeGet):
+
2013-02-20 Simon Fraser <simon.fra...@apple.com>
Zoomed, slow-scrolling pages keep recreating tiles when scrolled
Modified: trunk/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp (143537 => 143538)
--- trunk/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp 2013-02-21 00:48:45 UTC (rev 143537)
+++ trunk/Source/WebCore/platform/leveldb/LevelDBDatabase.cpp 2013-02-21 00:49:57 UTC (rev 143538)
@@ -75,13 +75,6 @@
return LevelDBSlice(s.data(), s.data() + s.size());
}
-static Vector<char> makeVector(const std::string& s)
-{
- Vector<char> res;
- res.append(s.c_str(), s.length());
- return res;
-}
-
class ComparatorAdapter : public leveldb::Comparator {
public:
ComparatorAdapter(const LevelDBComparator* comparator)
@@ -227,7 +220,8 @@
const leveldb::Status s = m_db->Get(readOptions, makeSlice(key), &result);
if (s.ok()) {
found = true;
- value = makeVector(result);
+ value.clear();
+ value.append(result.c_str(), result.length());
return true;
}
if (s.IsNotFound())
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
