Diff
Modified: trunk/ChangeLog (143504 => 143505)
--- trunk/ChangeLog 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/ChangeLog 2013-02-20 22:14:04 UTC (rev 143505)
@@ -1,3 +1,16 @@
+2013-02-20 Dirk Schulze <k...@webkit.org>
+
+ Enable CANVAS_PATH flag
+ https://bugs.webkit.org/show_bug.cgi?id=108508
+
+ Reviewed by Simon Fraser.
+
+ Enable CANVAS_PATH flag on trunk.
+
+ Existing tests cover the feature.
+
+ * Source/cmake/WebKitFeatures.cmake:
+
2013-02-19 Claudio Saavedra <csaave...@igalia.com>
Unreviewed build fix.
Modified: trunk/LayoutTests/ChangeLog (143504 => 143505)
--- trunk/LayoutTests/ChangeLog 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/LayoutTests/ChangeLog 2013-02-20 22:14:04 UTC (rev 143505)
@@ -1,3 +1,21 @@
+2013-02-20 Dirk Schulze <k...@webkit.org>
+
+ Enable CANVAS_PATH flag
+ https://bugs.webkit.org/show_bug.cgi?id=108508
+
+ Reviewed by Simon Fraser.
+
+ Enable CANVAS_PATH flag on trunk.
+
+ Existing tests cover the feature.
+
+ * fast/canvas/canvas-path-object-expected.txt:
+ * inspector/profiler/canvas2d/canvas2d-api-changes.html:
+ * platform/chromium/TestExpectations:
+ * platform/efl/TestExpectations:
+ * platform/gtk/TestExpectations:
+ * platform/mac/TestExpectations:
+
2013-02-20 Ian Vollick <voll...@chromium.org>
[chromium] Unreviewed gardening.
Modified: trunk/LayoutTests/fast/canvas/canvas-path-object-expected.txt (143504 => 143505)
--- trunk/LayoutTests/fast/canvas/canvas-path-object-expected.txt 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/LayoutTests/fast/canvas/canvas-path-object-expected.txt 2013-02-20 22:14:04 UTC (rev 143505)
@@ -1,11 +1,19 @@
-CONSOLE MESSAGE: line 5: ReferenceError: Can't find variable: Path
Ensure that the constructor for Path object and dependent functions exist.
On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
PASS typeof document.getElementById is "function"
-FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined).
+PASS path is an instance of Path
+PASS typeof path.closePath is "function"
+PASS typeof path.moveTo is "function"
+PASS typeof path.lineTo is "function"
+PASS typeof path.quadraticCurveTo is "function"
+PASS typeof path.bezierCurveTo is "function"
+PASS typeof path.arcTo is "function"
+PASS typeof path.arc is "function"
+PASS typeof path.rect is "function"
+PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/inspector/profiler/canvas2d/canvas2d-api-changes.html (143504 => 143505)
--- trunk/LayoutTests/inspector/profiler/canvas2d/canvas2d-api-changes.html 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/LayoutTests/inspector/profiler/canvas2d/canvas2d-api-changes.html 2013-02-20 22:14:04 UTC (rev 143505)
@@ -10,6 +10,7 @@
* @type {Array.<string>}
*/
CanvasRenderingContext2DResource.AttributeProperties = [
+ "currentPath",
"strokeStyle",
"fillStyle",
"globalAlpha",
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (143504 => 143505)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2013-02-20 22:14:04 UTC (rev 143505)
@@ -4321,12 +4321,6 @@
webkit.org/b/109136 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html [ ImageOnlyFailure Pass ]
webkit.org/b/109158 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html [ ImageOnlyFailure Pass ]
-# Rebaseline after currentPath
-webkit.org/b/108246 fast/canvas/canvas-currentPath.html [ Failure ]
-webkit.org/b/108246 platform/chromium/virtual/gpu/fast/canvas/canvas-currentPath.html [ Failure ]
-webkit.org/b/108246 fast/canvas/canvas-currentPath-crash.html [ Failure ]
-webkit.org/b/108246 platform/chromium/virtual/gpu/fast/canvas/canvas-currentPath-crash.html [ Failure ]
-
# Broken by Skia flag changes in r139445
crbug.com/169550 [ Debug ] fast/lists/big-list-marker.html [ Crash ]
crbug.com/169550 [ Debug ] platform/chromium/virtual/deferred/fast/images/icon-decoding.html [ Crash ]
@@ -4348,14 +4342,6 @@
webkit.org/b/106858 [ Mac Debug ] scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ ImageOnlyFailure ]
webkit.org/b/106858 [ Linux Win Debug ] scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html [ ImageOnlyFailure Pass ]
-
-# Needs rebaseline after enabling CANVAS_PATH.
-webkit.org/b/108508 fast/canvas/canvas-path-constructors.html [ Failure ]
-webkit.org/b/108508 platform/chromium/virtual/gpu/fast/canvas/canvas-path-constructors.html [ Failure ]
-webkit.org/b/108508 fast/canvas/canvas-path-object.html [ Failure ]
-webkit.org/b/108508 platform/chromium/virtual/gpu/fast/canvas/canvas-path-object.html [ Failure ]
-webkit.org/b/108508 inspector/profiler/canvas2d/canvas2d-api-changes.html [ Failure ]
-
# This is won't fix, as the debug and release versions differ.
webkit.org/b/107204 fast/events/touch/multi-touch-inside-iframes.html [ Pass Failure ]
Modified: trunk/LayoutTests/platform/efl/TestExpectations (143504 => 143505)
--- trunk/LayoutTests/platform/efl/TestExpectations 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/LayoutTests/platform/efl/TestExpectations 2013-02-20 22:14:04 UTC (rev 143505)
@@ -1797,10 +1797,6 @@
inspector/editor/text-editor-home-button.html
inspector/editor/text-editor-smart-braces.html
-# Remove from list after enabling CANVAS_PATH
-webkit.org/b/108508 fast/canvas/canvas-path-constructors.html [ Failure ]
-webkit.org/b/108508 fast/canvas/canvas-currentPath.html [ Failure ]
-
# Test fails on JSC platforms due to GC timing problems
webkit.org/b/106957 svg/dom/SVGViewSpec-invalid-ref-crash.html [ Failure ]
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (143504 => 143505)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2013-02-20 22:14:04 UTC (rev 143505)
@@ -1382,10 +1382,6 @@
webkit.org/b/103740 editing/selection/caret-alignment-for-vertical-text.html [ Failure ]
-# Remove from list after enabling CANVAS_PATH
-webkit.org/b/108508 fast/canvas/canvas-currentPath.html [ Failure ]
-webkit.org/b/108508 fast/canvas/canvas-path-constructors.html [ Failure ]
-
webkit.org/b/104054 svg/custom/use-href-update-crash.svg [ Failure ]
webkit.org/b/104680 http/tests/security/xss-DENIED-xml-external-entity.xhtml [ Failure ]
Modified: trunk/LayoutTests/platform/mac/TestExpectations (143504 => 143505)
--- trunk/LayoutTests/platform/mac/TestExpectations 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2013-02-20 22:14:04 UTC (rev 143505)
@@ -144,11 +144,6 @@
http/tests/security/cross-origin-worker-indexeddb.html
http/tests/security/no-indexeddb-from-sandbox.html
-# Remove from list after enabling CANVAS_PATH
-fast/canvas/canvas-currentPath.html
-fast/canvas/canvas-path-constructors.html
-fast/canvas/canvas-currentPath-crash.html
-
# This port doesn't support DeviceMotion or DeviceOrientation.
fast/dom/DeviceMotion
fast/dom/DeviceOrientation
Modified: trunk/Source/_javascript_Core/ChangeLog (143504 => 143505)
--- trunk/Source/_javascript_Core/ChangeLog 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-02-20 22:14:04 UTC (rev 143505)
@@ -1,3 +1,16 @@
+2013-02-20 Dirk Schulze <k...@webkit.org>
+
+ Enable CANVAS_PATH flag
+ https://bugs.webkit.org/show_bug.cgi?id=108508
+
+ Reviewed by Simon Fraser.
+
+ Enable CANVAS_PATH flag on trunk.
+
+ Existing tests cover the feature.
+
+ * Configurations/FeatureDefines.xcconfig:
+
2013-02-19 Mark Rowe <mr...@apple.com>
Unreviewed, uninteresting change to test a theory about bad dependency handling.
Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (143504 => 143505)
--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig 2013-02-20 22:14:04 UTC (rev 143505)
@@ -34,7 +34,7 @@
ENABLE_3D_RENDERING = ENABLE_3D_RENDERING;
ENABLE_ACCELERATED_2D_CANVAS = ;
ENABLE_BLOB = ENABLE_BLOB;
-ENABLE_CANVAS_PATH = ;
+ENABLE_CANVAS_PATH = ENABLE_CANVAS_PATH;
ENABLE_CANVAS_PROXY = ;
ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;
ENABLE_CSP_NEXT = ;
Modified: trunk/Source/WTF/wtf/FeatureDefines.h (143504 => 143505)
--- trunk/Source/WTF/wtf/FeatureDefines.h 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/Source/WTF/wtf/FeatureDefines.h 2013-02-20 22:14:04 UTC (rev 143505)
@@ -325,7 +325,7 @@
#endif
#if !defined(ENABLE_CANVAS_PATH)
-#define ENABLE_CANVAS_PATH 0
+#define ENABLE_CANVAS_PATH 1
#endif
#if !defined(ENABLE_CANVAS_PROXY)
Modified: trunk/Source/WebCore/ChangeLog (143504 => 143505)
--- trunk/Source/WebCore/ChangeLog 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/Source/WebCore/ChangeLog 2013-02-20 22:14:04 UTC (rev 143505)
@@ -1,3 +1,16 @@
+2013-02-20 Dirk Schulze <k...@webkit.org>
+
+ Enable CANVAS_PATH flag
+ https://bugs.webkit.org/show_bug.cgi?id=108508
+
+ Reviewed by Simon Fraser.
+
+ Enable CANVAS_PATH flag on trunk.
+
+ Existing tests cover the feature.
+
+ * Configurations/FeatureDefines.xcconfig:
+
2013-02-20 Sheriff Bot <webkit.review....@gmail.com>
Unreviewed, rolling out r143441.
Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (143504 => 143505)
--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig 2013-02-20 22:14:04 UTC (rev 143505)
@@ -34,7 +34,7 @@
ENABLE_3D_RENDERING = ENABLE_3D_RENDERING;
ENABLE_ACCELERATED_2D_CANVAS = ;
ENABLE_BLOB = ENABLE_BLOB;
-ENABLE_CANVAS_PATH = ;
+ENABLE_CANVAS_PATH = ENABLE_CANVAS_PATH;
ENABLE_CANVAS_PROXY = ;
ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;
ENABLE_CSP_NEXT = ;
Modified: trunk/Source/WebKit/chromium/ChangeLog (143504 => 143505)
--- trunk/Source/WebKit/chromium/ChangeLog 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/Source/WebKit/chromium/ChangeLog 2013-02-20 22:14:04 UTC (rev 143505)
@@ -1,3 +1,14 @@
+2013-02-20 Dirk Schulze <k...@webkit.org>
+
+ Enable CANVAS_PATH flag
+ https://bugs.webkit.org/show_bug.cgi?id=108508
+
+ Reviewed by Simon Fraser.
+
+ Enable CANVAS_PATH flag on trunk.
+
+ * features.gypi:
+
2013-02-15 Dirk Schulze <k...@webkit.org>
[Chromium] Add runtime flag for CanvasPath
Modified: trunk/Source/WebKit/chromium/features.gypi (143504 => 143505)
--- trunk/Source/WebKit/chromium/features.gypi 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/Source/WebKit/chromium/features.gypi 2013-02-20 22:14:04 UTC (rev 143505)
@@ -36,7 +36,7 @@
'ENABLE_BATTERY_STATUS=0',
'ENABLE_BLOB=1',
'ENABLE_BLOB_SLICE=1',
- 'ENABLE_CANVAS_PATH=0',
+ 'ENABLE_CANVAS_PATH=1',
'ENABLE_CANVAS_PROXY=1',
'ENABLE_CHANNEL_MESSAGING=1',
'ENABLE_CSP_NEXT=1',
Modified: trunk/Source/WebKit/mac/ChangeLog (143504 => 143505)
--- trunk/Source/WebKit/mac/ChangeLog 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/Source/WebKit/mac/ChangeLog 2013-02-20 22:14:04 UTC (rev 143505)
@@ -1,3 +1,14 @@
+2013-02-20 Dirk Schulze <k...@webkit.org>
+
+ Enable CANVAS_PATH flag
+ https://bugs.webkit.org/show_bug.cgi?id=108508
+
+ Reviewed by Simon Fraser.
+
+ Enable CANVAS_PATH flag on trunk.
+
+ * Configurations/FeatureDefines.xcconfig:
+
2013-02-19 Tim Horton <timothy_hor...@apple.com>
Clarify isInWindow vs. isVisible path through to RenderLayerCompositor
Modified: trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig (143504 => 143505)
--- trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig 2013-02-20 22:14:04 UTC (rev 143505)
@@ -34,7 +34,7 @@
ENABLE_3D_RENDERING = ENABLE_3D_RENDERING;
ENABLE_ACCELERATED_2D_CANVAS = ;
ENABLE_BLOB = ENABLE_BLOB;
-ENABLE_CANVAS_PATH = ;
+ENABLE_CANVAS_PATH = ENABLE_CANVAS_PATH;
ENABLE_CANVAS_PROXY = ;
ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;
ENABLE_CSP_NEXT = ;
Modified: trunk/Source/WebKit2/ChangeLog (143504 => 143505)
--- trunk/Source/WebKit2/ChangeLog 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/Source/WebKit2/ChangeLog 2013-02-20 22:14:04 UTC (rev 143505)
@@ -1,3 +1,14 @@
+2013-02-20 Dirk Schulze <k...@webkit.org>
+
+ Enable CANVAS_PATH flag
+ https://bugs.webkit.org/show_bug.cgi?id=108508
+
+ Reviewed by Simon Fraser.
+
+ Enable CANVAS_PATH flag on trunk.
+
+ * Configurations/FeatureDefines.xcconfig:
+
2013-02-20 Laszlo Gombos <l.gom...@samsung.com>
Remove unnecessary includes for Platform.h from headers
Modified: trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig (143504 => 143505)
--- trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig 2013-02-20 22:14:04 UTC (rev 143505)
@@ -34,7 +34,7 @@
ENABLE_3D_RENDERING = ENABLE_3D_RENDERING;
ENABLE_ACCELERATED_2D_CANVAS = ;
ENABLE_BLOB = ENABLE_BLOB;
-ENABLE_CANVAS_PATH = ;
+ENABLE_CANVAS_PATH = ENABLE_CANVAS_PATH;
ENABLE_CANVAS_PROXY = ;
ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;
ENABLE_CSP_NEXT = ;
Modified: trunk/Source/cmake/WebKitFeatures.cmake (143504 => 143505)
--- trunk/Source/cmake/WebKitFeatures.cmake 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/Source/cmake/WebKitFeatures.cmake 2013-02-20 22:14:04 UTC (rev 143505)
@@ -18,7 +18,7 @@
WEBKIT_OPTION_DEFINE(ENABLE_ASSEMBLER_WX_EXCLUSIVE "Toggel Assembler WX Exclusive support" OFF)
WEBKIT_OPTION_DEFINE(ENABLE_BATTERY_STATUS "Toggle battery status API support" OFF)
WEBKIT_OPTION_DEFINE(ENABLE_BLOB "Toggle Blob support" OFF)
- WEBKIT_OPTION_DEFINE(ENABLE_CANVAS_PATH "Toggle Canvas Path support" OFF)
+ WEBKIT_OPTION_DEFINE(ENABLE_CANVAS_PATH "Toggle Canvas Path support" ON)
WEBKIT_OPTION_DEFINE(ENABLE_CANVAS_PROXY "Toggle CanvasProxy support" OFF)
WEBKIT_OPTION_DEFINE(ENABLE_CHANNEL_MESSAGING "Toggle MessageChannel and MessagePort support" ON)
WEBKIT_OPTION_DEFINE(ENABLE_CSP_NEXT "Toggle Content Security Policy 1.1 support" OFF)
Modified: trunk/Tools/ChangeLog (143504 => 143505)
--- trunk/Tools/ChangeLog 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/Tools/ChangeLog 2013-02-20 22:14:04 UTC (rev 143505)
@@ -1,3 +1,14 @@
+2013-02-20 Dirk Schulze <k...@webkit.org>
+
+ Enable CANVAS_PATH flag
+ https://bugs.webkit.org/show_bug.cgi?id=108508
+
+ Reviewed by Simon Fraser.
+
+ Enable CANVAS_PATH flag on trunk.
+
+ * Scripts/webkitperl/FeatureList.pm:
+
2013-02-20 Tony Chang <t...@chromium.org>
Parse author names with commas in ChangeLogs
Modified: trunk/Tools/Scripts/webkitperl/FeatureList.pm (143504 => 143505)
--- trunk/Tools/Scripts/webkitperl/FeatureList.pm 2013-02-20 22:03:49 UTC (rev 143504)
+++ trunk/Tools/Scripts/webkitperl/FeatureList.pm 2013-02-20 22:14:04 UTC (rev 143505)
@@ -165,7 +165,7 @@
define => "ENABLE_BLOB", default => (isAppleMacWebKit() || isGtk() || isChromium() || isBlackBerry() || isEfl()), value => \$blobSupport },
{ option => "canvas-path", desc => "Toggle Canvas Path support",
- define => "ENABLE_CANVAS_PATH", default => 0, value => \$canvasPathSupport },
+ define => "ENABLE_CANVAS_PATH", default => 1, value => \$canvasPathSupport },
{ option => "canvas-proxy", desc => "Toggle CanvasProxy support",
define => "ENABLE_CANVAS_PROXY", default => 0, value => \$canvasProxySupport },
