Title: [143411] trunk/Source/_javascript_Core
- Revision
- 143411
- Author
- oli...@apple.com
- Date
- 2013-02-19 16:47:52 -0800 (Tue, 19 Feb 2013)
Log Message
Silence some analyzer warnings
https://bugs.webkit.org/show_bug.cgi?id=110281
Reviewed by Mark Hahnenberg.
The static analyzer believes that callerCodeBlock can be null,
based on other code performing null tests. This should not
ever be the case, but we'll add RELEASE_ASSERTs to make it
obvious if we're ever wrong.
* interpreter/Interpreter.cpp:
(JSC::getCallerInfo):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (143410 => 143411)
--- trunk/Source/_javascript_Core/ChangeLog 2013-02-20 00:45:40 UTC (rev 143410)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-02-20 00:47:52 UTC (rev 143411)
@@ -1,5 +1,20 @@
2013-02-19 Oliver Hunt <oli...@apple.com>
+ Silence some analyzer warnings
+ https://bugs.webkit.org/show_bug.cgi?id=110281
+
+ Reviewed by Mark Hahnenberg.
+
+ The static analyzer believes that callerCodeBlock can be null,
+ based on other code performing null tests. This should not
+ ever be the case, but we'll add RELEASE_ASSERTs to make it
+ obvious if we're ever wrong.
+
+ * interpreter/Interpreter.cpp:
+ (JSC::getCallerInfo):
+
+2013-02-19 Oliver Hunt <oli...@apple.com>
+
Don't force everything to be blinded in debug builds
https://bugs.webkit.org/show_bug.cgi?id=110279
Modified: trunk/Source/_javascript_Core/interpreter/Interpreter.cpp (143410 => 143411)
--- trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2013-02-20 00:45:40 UTC (rev 143410)
+++ trunk/Source/_javascript_Core/interpreter/Interpreter.cpp 2013-02-20 00:47:52 UTC (rev 143411)
@@ -651,10 +651,14 @@
}
} else
#endif
+ {
+ RELEASE_ASSERT(callerCodeBlock);
bytecodeOffset = callerCodeBlock->bytecodeOffset(callerFrame, callFrame->returnPC());
+ }
#endif
}
+ RELEASE_ASSERT(callerCodeBlock);
lineNumber = callerCodeBlock->lineNumberForBytecodeOffset(bytecodeOffset);
return callerFrame;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
