Title: [143027] trunk/Source
Revision
143027
Author
gga...@apple.com
Date
2013-02-15 11:54:09 -0800 (Fri, 15 Feb 2013)

Log Message

Merged the global function cache into the source code cache
https://bugs.webkit.org/show_bug.cgi?id=108660

Reviewed by Sam Weinig.

Responding to review comments by Darin Adler.

../_javascript_Core: 

* runtime/CodeCache.h:
(JSC::SourceCodeKey::SourceCodeKey): Don't initialize m_name and m_flags
in the hash table deleted value because they're meaningless.

../WTF: 

* wtf/HashTraits.h: Added a using directive to simplify client code.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (143026 => 143027)


--- trunk/Source/_javascript_Core/ChangeLog	2013-02-15 19:53:17 UTC (rev 143026)
+++ trunk/Source/_javascript_Core/ChangeLog	2013-02-15 19:54:09 UTC (rev 143027)
@@ -1,3 +1,16 @@
+2013-02-15  Geoffrey Garen  <gga...@apple.com>
+
+        Merged the global function cache into the source code cache
+        https://bugs.webkit.org/show_bug.cgi?id=108660
+
+        Reviewed by Sam Weinig.
+
+        Responding to review comments by Darin Adler.
+
+        * runtime/CodeCache.h:
+        (JSC::SourceCodeKey::SourceCodeKey): Don't initialize m_name and m_flags
+        in the hash table deleted value because they're meaningless.
+
 2013-02-14  Filip Pizlo  <fpi...@apple.com>
 
         DFG AbstractState should filter operands to NewArray more precisely

Modified: trunk/Source/_javascript_Core/runtime/CodeCache.h (143026 => 143027)


--- trunk/Source/_javascript_Core/runtime/CodeCache.h	2013-02-15 19:53:17 UTC (rev 143026)
+++ trunk/Source/_javascript_Core/runtime/CodeCache.h	2013-02-15 19:54:09 UTC (rev 143027)
@@ -99,8 +99,6 @@
 
     SourceCodeKey(WTF::HashTableDeletedValueType)
         : m_sourceString(WTF::HashTableDeletedValue)
-        , m_name(WTF::HashTableDeletedValue)
-        , m_flags(0)
     {
     }
 
@@ -129,7 +127,7 @@
     static const bool safeToCompareToEmptyOrDeleted = false;
 };
 
-struct SourceCodeKeyHashTraits : WTF::SimpleClassHashTraits<SourceCodeKey> {
+struct SourceCodeKeyHashTraits : SimpleClassHashTraits<SourceCodeKey> {
     static const bool hasIsEmptyValueFunction = true;
     static bool isEmptyValue(const SourceCodeKey& sourceCodeKey) { return sourceCodeKey.isNull(); }
 };

Modified: trunk/Source/WTF/ChangeLog (143026 => 143027)


--- trunk/Source/WTF/ChangeLog	2013-02-15 19:53:17 UTC (rev 143026)
+++ trunk/Source/WTF/ChangeLog	2013-02-15 19:54:09 UTC (rev 143027)
@@ -1,3 +1,14 @@
+2013-02-15  Geoffrey Garen  <gga...@apple.com>
+
+        Merged the global function cache into the source code cache
+        https://bugs.webkit.org/show_bug.cgi?id=108660
+
+        Reviewed by Sam Weinig.
+
+        Responding to review comments by Darin Adler.
+
+        * wtf/HashTraits.h: Added a using directive to simplify client code.
+
 2013-02-14  Dan Bernstein  <m...@apple.com>
 
         No easy way to use a RetainPtr as a key in a HashMap using object (rather than pointer) equality

Modified: trunk/Source/WTF/wtf/HashTraits.h (143026 => 143027)


--- trunk/Source/WTF/wtf/HashTraits.h	2013-02-15 19:53:17 UTC (rev 143026)
+++ trunk/Source/WTF/wtf/HashTraits.h	2013-02-15 19:54:09 UTC (rev 143027)
@@ -243,5 +243,6 @@
 using WTF::HashTraits;
 using WTF::PairHashTraits;
 using WTF::NullableHashTraits;
+using WTF::SimpleClassHashTraits;
 
 #endif // WTF_HashTraits_h
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to