Title: [142890] trunk/Source/WebCore
- Revision
- 142890
- Author
- dgro...@chromium.org
- Date
- 2013-02-14 10:17:54 -0800 (Thu, 14 Feb 2013)
Log Message
IndexedDB: Add a few more histogram calls
https://bugs.webkit.org/show_bug.cgi?id=109762
Reviewed by Tony Chang.
A few places where commits could fail weren't being logged.
* Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::deleteDatabase):
(WebCore::IDBBackingStore::Transaction::commit):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (142889 => 142890)
--- trunk/Source/WebCore/ChangeLog 2013-02-14 17:53:16 UTC (rev 142889)
+++ trunk/Source/WebCore/ChangeLog 2013-02-14 18:17:54 UTC (rev 142890)
@@ -1,3 +1,16 @@
+2013-02-14 David Grogan <dgro...@chromium.org>
+
+ IndexedDB: Add a few more histogram calls
+ https://bugs.webkit.org/show_bug.cgi?id=109762
+
+ Reviewed by Tony Chang.
+
+ A few places where commits could fail weren't being logged.
+
+ * Modules/indexeddb/IDBBackingStore.cpp:
+ (WebCore::IDBBackingStore::deleteDatabase):
+ (WebCore::IDBBackingStore::Transaction::commit):
+
2013-02-14 Tony Chang <t...@chromium.org>
Padding and border changes doesn't trigger relayout of children
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp (142889 => 142890)
--- trunk/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp 2013-02-14 17:53:16 UTC (rev 142889)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp 2013-02-14 18:17:54 UTC (rev 142890)
@@ -71,6 +71,8 @@
GetNewDatabaseId,
GetNewVersionNumber,
CreateIDBDatabaseMetaData,
+ DeleteDatabase,
+ TransactionCommit,
IDBLevelDBBackingStoreInternalErrorMax,
};
@@ -587,7 +589,11 @@
const Vector<char> key = DatabaseNameKey::encode(m_identifier, name);
transaction->remove(key);
- return transaction->commit();
+ if (!transaction->commit()) {
+ INTERNAL_WRITE_ERROR(DeleteDatabase);
+ return false;
+ }
+ return true;
}
static bool checkObjectStoreAndMetaDataType(const LevelDBIterator* it, const Vector<char>& stopKey, int64_t objectStoreId, int64_t metaDataType)
@@ -1843,6 +1849,8 @@
ASSERT(m_transaction);
bool result = m_transaction->commit();
m_transaction.clear();
+ if (!result)
+ INTERNAL_WRITE_ERROR(TransactionCommit);
return result;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
