Title: [142055] trunk/Source/WebKit2
Revision
142055
Author
enr...@apple.com
Date
2013-02-06 16:47:03 -0800 (Wed, 06 Feb 2013)

Log Message

ASSERT(!m_findPageOverlay) in FindController.cpp after r140769.
https://bugs.webkit.org/show_bug.cgi?id=109105.

Reviewed by Tim Horton.

In r140769 we changed the way the overlay is destroyed,
therefore the assert is no longer valid and should be removed.

* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindUIAfterPageScroll):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (142054 => 142055)


--- trunk/Source/WebKit2/ChangeLog	2013-02-07 00:41:07 UTC (rev 142054)
+++ trunk/Source/WebKit2/ChangeLog	2013-02-07 00:47:03 UTC (rev 142055)
@@ -1,3 +1,16 @@
+2013-02-06  Enrica Casucci  <enr...@apple.com>
+
+        ASSERT(!m_findPageOverlay) in FindController.cpp after r140769.
+        https://bugs.webkit.org/show_bug.cgi?id=109105.
+
+        Reviewed by Tim Horton.
+
+        In r140769 we changed the way the overlay is destroyed,
+        therefore the assert is no longer valid and should be removed.
+
+        * WebProcess/WebPage/FindController.cpp:
+        (WebKit::FindController::updateFindUIAfterPageScroll):
+
 2013-02-06  Anders Carlsson  <ander...@apple.com>
 
         Dispatch storage manager messages to the storage work queue

Modified: trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp (142054 => 142055)


--- trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp	2013-02-07 00:41:07 UTC (rev 142054)
+++ trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp	2013-02-07 00:47:03 UTC (rev 142055)
@@ -164,9 +164,7 @@
         if (m_findPageOverlay) {
             // Get rid of the overlay.
             m_webPage->uninstallPageOverlay(m_findPageOverlay, true);
-        }
-        
-        ASSERT(!m_findPageOverlay);
+        }        
     } else {
         if (!m_findPageOverlay) {
             RefPtr<PageOverlay> findPageOverlay = PageOverlay::create(this);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to